From patchwork Wed Jun 22 13:34:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Denis V. Lunev" X-Patchwork-Id: 9193003 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1189860756 for ; Wed, 22 Jun 2016 13:46:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 009AF283FD for ; Wed, 22 Jun 2016 13:46:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E6EF028406; Wed, 22 Jun 2016 13:46:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EDC2E283FD for ; Wed, 22 Jun 2016 13:45:58 +0000 (UTC) Received: from localhost ([::1]:58536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFiTe-0000aW-50 for patchwork-qemu-devel@patchwork.kernel.org; Wed, 22 Jun 2016 09:45:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFiJ4-0005qf-KO for qemu-devel@nongnu.org; Wed, 22 Jun 2016 09:35:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFiIy-00013Z-Gt for qemu-devel@nongnu.org; Wed, 22 Jun 2016 09:35:01 -0400 Received: from mail-db3on0128.outbound.protection.outlook.com ([157.55.234.128]:8805 helo=emea01-db3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFiIm-0000z7-8N; Wed, 22 Jun 2016 09:34:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=1Blaekrl8T8kjgDJyqdHYkfcicu90afoE7EnxapQxiw=; b=YrfGdVoKmNyvtnHjotoaWTNKr/krwhCHEE0mUT4s7Tq7H29oZeRtnCRjqSUlMVW1zPiaxlUOyUkY1tEEkBjXWSwkNXd5MB7VR/9/c3UED6LkxKnx+BaAuVR7nUgrMEwbldW3uEexXlEyFmSoodfpkJo/JO+k7G51qO6StBCuOo4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=den@virtuozzo.com; Received: from [10.30.2.139] (195.214.232.10) by DB5PR08MB0805.eurprd08.prod.outlook.com (10.164.42.155) with Microsoft SMTP Server (TLS) id 15.1.523.12; Wed, 22 Jun 2016 13:34:40 +0000 To: , , References: <1466174654-30130-1-git-send-email-den@openvz.org> From: "Denis V. Lunev" Message-ID: <576A93EB.90000@openvz.org> Date: Wed, 22 Jun 2016 16:34:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1466174654-30130-1-git-send-email-den@openvz.org> X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: HE1PR03CA0039.eurprd03.prod.outlook.com (10.163.170.177) To DB5PR08MB0805.eurprd08.prod.outlook.com (10.164.42.155) X-MS-Office365-Filtering-Correlation-Id: 03e8b9af-7dbf-48b8-d302-08d39aa1f761 X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0805; 2:3WJTUjsAIm/LkgeQVWpk0eMIj4ThRkz14wn8Gna4ODdhIsrP8IifwodmtBu78dPnZt3DJBIiC82J1KgdCQSCB4hgS/z8dc5+oW2CrEyo1k3vZjoV4EQsIfs7a3DbM9n0YnmOXP5akPmWJzdJDBmhv/82osx6KEHUGUWI1ZbrZKOPvWuCD3mxkzp8SkfpGn3f; 3:o208DErd1kpzRQlpPL5YyJglIGNLVEiEV0DD2J3DNDtPRqiMhXFgoT0OypW5WEkpgyVXZ3u3Ng/AhLV7pxa3hZ/y1ghBiUP4xUD4lNMlOpZX94aP01pkDgHeKWKfR0t1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR08MB0805; X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0805; 25:peFKG1KY+Xjg++RxA3FAk3qLBb7gqyKqPLCwdW0eN8GwOP8BlWNLW6Fpa/m3XvbP1M2OGwjxrzY+SiKQ3thsxM6Vyr+55lg2+Up65yWfIeRZnFkaozXx4WNfDCylRTUSwSqY6TDaAKALuH8Zpjt4L6puW9nEx/VA1MpLrknSdt39YtHkiiVGJF+GegCJvt+vQq/VRhfbfKt83MhfubfrK6JkdC4uS5GcjguosjFNVquZwxD9h/PriCCd+uBty81D44av0fO/bVdJEwZJ9A0Zdav5qftAPvRvNfebimt/i8qVzzT3FPX4YqWMBDfLP89d6GqlDVE/5g0HlUdeNHw4BkRd+M4Uy13vs3KIQNnfdw1YRAl4USEnn4hQscCrXbr/V3MPWRfw7EqL0yRLj00HBv6BQCZZ+FRVm8LI+ceoBf92GTg4kdKqJLqnqH73JMvclFVBeHQqit2E6h03ZtOQk9n3EFu7BBZpFKNhsKTaZua8zZyfjatFfPf9D4JSvifBtyW4frik5K2H4EnKNG/r9p3QTIdFhjKtcdPmcHQiZFA3KMui8IIf6isdgHnefodI+Q8XeSHkcrgPTA9R81PbGF/OiAAbrI5lgzo8zfxZ6ld/LKlNGqLxEnVxh1+Xm8nU3BO2mnBs5xwkIBu92zGSZ8qwzQpOrAa4Qs7IntOZhLmxlJ5mXmzdtjaHFLvEXYGx239RXEpOfv+2s6N3iEAS2Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041072)(6043046); SRVR:DB5PR08MB0805; BCL:0; PCL:0; RULEID:; SRVR:DB5PR08MB0805; X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0805; 4:67zgIXIFKj836rNqX+iFJxxVmVibfG6jIBypgXftbbxA460FybvQ6JdvdJuwKmwyEinLr2xJY1q50+q8MgwWMiFilDS9TMr7s7jFhxaLtw3zm1v1UZuN9uzRDL5VAaLn4HcVMstittm0cQrICnpxq3Tfl0tD26pi4gVZVYR5owf7wERRRyJc+OKonoQcqzaS7lM3D38eB1mZi7q14fjcBDzGZGh+7bvTCtFaxKKGRRmofrUQ6F2AAKE2UbktWfm5qTk+Fo6ddjs5w8o5/X58cukUn9agflzpVH/rv8k6mGnyu/pl5sVFFjKzi9Hvc14ji3Snqehk7QUGVY2tNA9Cxdm8tBvSbmsGRWnAFU621AHGOmTWwA3HGsTPpKQxXxD+d1phKhMigeY6t7Gfpzu3yGcU5wT28gq+blJwesuPUJg= X-Forefront-PRVS: 0981815F2F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(189002)(199003)(24454002)(377454003)(4326007)(64126003)(42186005)(5001770100001)(97736004)(7736002)(2950100001)(50466002)(189998001)(4001350100001)(36756003)(106356001)(105586002)(2906002)(101416001)(50986999)(3846002)(54356999)(76176999)(47776003)(81166006)(65816999)(77096005)(23746002)(66066001)(19580405001)(8676002)(81156014)(65806001)(586003)(19580395003)(68736007)(2201001)(92566002)(83506001)(230700001)(7846002)(65956001)(33656002)(6116002)(42882005)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:DB5PR08MB0805; H:[10.30.2.139]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: virtuozzo.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DB5PR08MB0805; 23:xVm4vtR1jU7ylw8EpCJ2K3LrE87aboYWwoXgz?= =?Windows-1252?Q?hJ9wt7db9p32YxZSYwrk/Cm2cdb1OjTvICPsREpl67hrtDMExTprL252?= =?Windows-1252?Q?eH7rUg0G08xQ+j8YXQl9uiVHcrSSXla8BidkS0KjnKmPvcpKNMoOS6tK?= =?Windows-1252?Q?A9uNKTS/ILP7mT4M/AOE+uazu+UUotMQH4biUu8xKFkMkWuUJOFnv8pQ?= =?Windows-1252?Q?ZuddAIBlMpiFWU0sjhU+IjAVNEDL+yZGXcZZENE+eaVI+zUSfmxwZEeb?= =?Windows-1252?Q?awzqVYiulPV5YL0Xc3DTovBj+P8760N8jwQEyHFilib/mcJ20wml+bV8?= =?Windows-1252?Q?0Ej+EgVAI6UoigPq5ksW3AGAC/V+U35+WVsNICbEquIZfngrNTZIrvmq?= =?Windows-1252?Q?6Oj26sGNql9q33RfxsKn8W3DzgnSuwOu6tejJWzKiJ85X1CR+LttY3SB?= =?Windows-1252?Q?D6iy4o8wRSIq2P0oBvnTRVRbVTVH+4oSinCi+5JlENmEc67yOjnzTVA+?= =?Windows-1252?Q?8mUddsLOzs/eOOUrbzy4ivf0PkOVCoLLtQ4NlRdwrtxOCAfTh7LjO65v?= =?Windows-1252?Q?ukNEIKgl0M6TGpvsIJiZvqs3XQ6P8+JG63sYAPOH7jdSV/PsQHPBeI7F?= =?Windows-1252?Q?53CVbW1shAvr5818v92SNkhEJEdzgRrUEwFJ8cmc8MzSCFjUIW0KbU3p?= =?Windows-1252?Q?BXD/P7UB+Tp3Y+wLKPeDcq++R69j79jbx9sPn9I+VWRaJ0ca7U8d6W6/?= =?Windows-1252?Q?dtPXeZMYC/Mw3AjxVeI4KUqJLmElETSpPx66BYepkfZwcLd0cLgi3jD2?= =?Windows-1252?Q?73cyY1+VFntedK2S6r5pRmXpw+9f49vyiZTl/Jpxs5L/Jq+ZJh83u6CD?= =?Windows-1252?Q?TphINVX2WdudJrS5uM0XM2wutkEOcFD9kahQRswze9Cy8te7/UwYwgno?= =?Windows-1252?Q?doGEF1Og6mX+ctHZju4Wj/CVn/PYz/b0y3P8mPc+0k2WQ/7x7MwuMhpx?= =?Windows-1252?Q?rKUm773mRxoiNS31vzJ9Ik4tca/rpVXk+H7LaoikWLra8lGfwl6mt76Q?= =?Windows-1252?Q?ahfb5ScFSib3J0DPA2TscKouWa+/DApbGoFkTNNgCvtMeymBy4ZMjpVs?= =?Windows-1252?Q?0HHsLQvIbjJblz0V+s9tcQotMuRK0bkwezAx0hLLsEvcdEYZ4RR6jWuw?= =?Windows-1252?Q?wucko2u1YXUSIDqrpRbiZxy9yWS2mpic+BAVxAs/OPc+pDtV6LFo5brL?= =?Windows-1252?Q?fopfV5qw360Vg89/03YzlpSrnT5kdZMukoPvTI+R1e9rk9DWC5OV2nhH?= =?Windows-1252?Q?3KGtS46g3ghPpYvhyNc7VMls7i5JzSxRZJNqR5ohQ+McBo=3D?= X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0805; 6:IUyRZanX0ahmZjnWfKHdDfhM/4oSMvifWOdgybK0s9zRXU9536Ogeu7blk1EgZG2N3NR3bjEfnWUsBo4foFjIuAMvcwB1WrZj01m1MwytF0m8XJeaBmD5CkaLY4iRmwC9hOhMcq5J4FqrhbWn7Kaqt6JbjgNGDDN5v3FnXk74Rfh+6Px0tb5OS54BX70Q27H4myAdgBDjtRHd0BMn7o+bpbMJcpZ2ENaawUbrZVQz2xdofy+U+tl4hDs314+ZgKcpU34doGLMYmbprYDnh2VpUpjQx47Yxty9rAgrqerax0GTbHrFgo6TQ/wL3LMJ6BHxcdXhrIa9rZkrWTAsNk+xA==; 5:uik6iwY+weSvBh9UKxqMav0VjHjiEvVERX7bTDeD6UWffpaOYaixLPlRVGa250KgkiEpbU32PWuYherSTfWcbf+yiPPcaOrMopFeFpbfoWEqL8d+qZMH41UToYCtnS7f924ujqsZ/4rxaL2sioCzyQ==; 24:AMd1Yy2OdsulibCsB4SBQq2OkOYACqnZ886HnYva48rAZnI2xUtfpPhM9X7rpWc1/Zy8ECNtVaOHXQg3v/JYs/BaFIYevVnlMqgPRKC5fH4=; 7:Oq5e1Lv43aoGx40HVuIkmERqZ93ysFslTZjGZO7W3D9TD7j+8da+pygV3Ova60zPpuXJ+jabnApKe01IsN0/6nYfbnn/chDsFL5HXBJOUtRtyVte/YCdt++iEQvQD5B67LluDvKzE05OIL7wBMtJ8eNQNiQM8EoWpzM2eSLZb2taIYXlTDdcWwIannHV0xdigZZPAHiKPOtlBGxeDdNI/XLKOX2ocE3suhBjW1hE98TlpCT1WmyFqoxLdg5P4DZkAHfFATDQ5UMIiJ1rZ8PZvw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB5PR08MB0805; 20:+emp+efETQK9bCUJc31DBF/S4PlM7JedtmQeVcguLEsMCU4fOphnSUM2NZv0SugoNYX7LKfAJD5/yxWEojURceOK6AhnzARKzpnA177QivPEifPv6F1zo5VQtN63T1VLE0I4sCTbJE0ODuq3MIsfTfJMTUNmiMtjfdAMhLT2On0= X-OriginatorOrg: openvz.org X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2016 13:34:40.8076 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB0805 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 X-Received-From: 157.55.234.128 Subject: Re: [Qemu-devel] [PATCH v9 0/7] trace: enable tracing in qemu-io/qemu-nbd/qemu-img X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Denis V. Lunev" , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 06/17/2016 05:44 PM, Denis V. Lunev wrote: > Changes from v8: > - fixed comment in patch 3 > - changed stub for trace_opt_parse() > > Changes from v7: > - added missed qemu-option-trace.texi > > Changes from v6: > - changed order of patches 1 & 2 > > Changes from v5: > - added missed hunk into patch #7 > > Changes from v4: > - synced help descriprion for --trace with man for qemu.1/qemu-img.1/qemu-nbd.8 > - moved @findex from qemu-option-trace.texi > > Changes from v3: > - fixed difference in help/man for qemu-img/qemu-nbd > - created separate .texi to contain trace description, proper dependency is > added to makefile > - added --version/--help description to qemu-img > - fixed crash induced by new option processing scheme in qemu-img which > has happened when invoked as './qemu-img -K' > > Changes from v2: > - tweaked man-pages of qemu-nbd/qemu-img > - added support for qemu-img (patches 4-5 as suggested) > > Changes from v1: > - fixed nits found by Eric > > Signed-off-by: Denis V. Lunev > Reviewed-by: Eric Blake > CC: Paolo Bonzini > CC: Stefan Hajnoczi > CC: Kevin Wolf > > Denis V. Lunev (7): > doc: sync help descriprion for --trace with man for qemu.1 > doc: move text describing --trace to specific .texi file > trace: move qemu_trace_opts to trace/control.c > trace: enable tracing in qemu-io > trace: enable tracing in qemu-nbd > qemu-img: move common options parsing before commands processing > trace: enable tracing in qemu-img > > Makefile | 7 ++++--- > qemu-img.c | 56 ++++++++++++++++++++++++++++++++++++++------------ > qemu-img.texi | 13 +++++++++++- > qemu-io.c | 18 ++++++++++++---- > qemu-nbd.c | 19 ++++++++++++++++- > qemu-nbd.texi | 3 +++ > qemu-option-trace.texi | 25 ++++++++++++++++++++++ > qemu-options.hx | 29 ++------------------------ > trace/control.c | 42 ++++++++++++++++++++++++++++++++++++- > trace/control.h | 25 ++++++++++++---------- > vl.c | 38 ++-------------------------------- > 11 files changed, 178 insertions(+), 97 deletions(-) > create mode 100644 qemu-option-trace.texi > Stefan, there is a problem in this patchset. It breaks block unit tests in a very interesting place. You should apply the following simple change on top or fix patch 6. Can you pls apply it or I can resend the series. irbis ~/src/qemu $ git diff irbis ~/src/qemu $ getopt_long() behaves very interesting.... Den diff --git a/qemu-img.c b/qemu-img.c index 3322a1e..2351686 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3866,7 +3866,7 @@ int main(int argc, char **argv) return 0; } argv += optind; - optind = 1; + optind = 0; if (!trace_init_backends()) { exit(1);