diff mbox series

[RFC,v3,75/78] migration: add fallthrough pseudo-keyword

Message ID	60edc70e7ff41ee87e39884a5fdf87fac1bd9f77.1697186560.git.manos.pitsidianakis@linaro.org (mailing list archive)
State	New, archived
Headers	show Return-Path: <qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org> From: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org> To: qemu-devel@nongnu.org Cc: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>, Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, Leonardo Bras <leobras@redhat.com> Subject: [RFC PATCH v3 75/78] migration: add fallthrough pseudo-keyword Date: Fri, 13 Oct 2023 11:46:43 +0300 Message-Id: <60edc70e7ff41ee87e39884a5fdf87fac1bd9f77.1697186560.git.manos.pitsidianakis@linaro.org> In-Reply-To: <cover.1697186560.git.manos.pitsidianakis@linaro.org> References: <cover.1697186560.git.manos.pitsidianakis@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=manos.pitsidianakis@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org
Series	Strict disable implicit fallthrough \| expand [RFC,v3,00/78] Strict disable implicit fallthrough [RFC,v3,01/78] include/qemu/compiler.h: replace QEMU_FALLTHROUGH with fallthrough [RFC,v3,02/78] block: add fallthrough pseudo-keyword [RFC,v3,03/78] fpu/softfloat: add fallthrough pseudo-keyword [RFC,v3,04/78] qapi/opts-visitor: add fallthrough pseudo-keyword [RFC,v3,05/78] qobject/json: add fallthrough pseudo-keyword [RFC,v3,06/78] tcg: add fallthrough pseudo-keyword [RFC,v3,07/78] hw/virtio/virtio-balloon.c: add fallthrough pseudo-keyword [RFC,v3,08/78] hw/block: add fallthrough pseudo-keyword [RFC,v3,09/78] hw/acpi/aml-build.c: add fallthrough pseudo-keyword [RFC,v3,10/78] hw/ide/atapi.c: add fallthrough pseudo-keyword [RFC,v3,11/78] hw/timer: add fallthrough pseudo-keyword [RFC,v3,12/78] hw/usb: add fallthrough pseudo-keyword [RFC,v3,13/78] hw/adc: add fallthrough pseudo-keyword [RFC,v3,14/78] util/error-report.c: add fallthrough pseudo-keyword [RFC,v3,15/78] accel/tcg: add fallthrough pseudo-keyword [RFC,v3,16/78] audio: add fallthrough pseudo-keyword [RFC,v3,17/78] ui/sdl2.c: add fallthrough pseudo-keyword [RFC,v3,18/78] ui/win32-kbd-hook.c: add fallthrough pseudo-keyword [RFC,v3,19/78] target/hppa: add fallthrough pseudo-keyword [RFC,v3,20/78] target/mips: add fallthrough pseudo-keyword [RFC,v3,21/78] target/sparc: add fallthrough pseudo-keyword [RFC,v3,22/78] target/ppc: add fallthrough pseudo-keyword [RFC,v3,23/78] target/arm: add fallthrough pseudo-keyword [RFC,v3,24/78] target/alpha: add fallthrough pseudo-keyword [RFC,v3,25/78] target/i386: add fallthrough pseudo-keyword [RFC,v3,26/78] target/s390x: add fallthrough pseudo-keyword [RFC,v3,27/78] target/riscv: add fallthrough pseudo-keyword [RFC,v3,28/78] target/avr: add fallthrough pseudo-keyword [RFC,v3,29/78] target/cris: add fallthrough pseudo-keyword [RFC,v3,30/78] target/nios2: add fallthrough pseudo-keyword [RFC,v3,31/78] target/xtensa: add fallthrough pseudo-keyword [RFC,v3,32/78] target/m68k: add fallthrough pseudo-keyword [RFC,v3,33/78] target/rx: add fallthrough pseudo-keyword [RFC,v3,34/78] target/tricore: add fallthrough pseudo-keyword [RFC,v3,35/78] target/sh4: add fallthrough pseudo-keyword [RFC,v3,36/78] target/openrisc: add fallthrough pseudo-keyword [RFC,v3,37/78] target/hexagon: add fallthrough pseudo-keyword [RFC,v3,38/78] system/rtc.c: add fallthrough pseudo-keyword [RFC,v3,39/78] hw/scsi: add fallthrough pseudo-keyword [RFC,v3,40/78] hw/sd/sdhci.c: add fallthrough pseudo-keyword [RFC,v3,41/78] linux-user: add fallthrough pseudo-keyword [RFC,v3,42/78] hw/i386: add fallthrough pseudo-keyword [RFC,v3,43/78] hw/misc: add fallthrough pseudo-keyword [RFC,v3,44/78] hw/m68k/mcf_intc.c: add fallthrough pseudo-keyword [RFC,v3,45/78] hw/dma: add fallthrough pseudo-keyword [RFC,v3,46/78] disas: add fallthrough pseudo-keyword [RFC,v3,47/78] contrib/rdmacm-mux: add fallthrough pseudo-keyword [RFC,v3,48/78] contrib/vhost-user-scsi: add fallthrough pseudo-keyword [RFC,v3,49/78] hw/arm: add fallthrough pseudo-keyword [RFC,v3,50/78] hw/audio: add fallthrough pseudo-keyword [RFC,v3,51/78] chardev: add fallthrough pseudo-keyword [RFC,v3,52/78] hw/char: add fallthrough pseudo-keyword [RFC,v3,53/78] nbd: add fallthrough pseudo-keyword [RFC,v3,54/78] hw/core: add fallthrough pseudo-keyword [RFC,v3,55/78] hw/display: add fallthrough pseudo-keyword [RFC,v3,56/78] hw/input: add fallthrough pseudo-keyword [RFC,v3,57/78] hw/net: add fallthrough pseudo-keyword [RFC,v3,58/78] hw/ppc: add fallthrough pseudo-keyword [RFC,v3,59/78] hw/intc: add fallthrough pseudo-keyword [RFC,v3,60/78] qga: add fallthrough pseudo-keyword [RFC,v3,61/78] semihosting: add fallthrough pseudo-keyword [RFC,v3,62/78] hw/gpio: add fallthrough pseudo-keyword [RFC,v3,63/78] hw/ipmi: add fallthrough pseudo-keyword [RFC,v3,64/78] hw/mips: add fallthrough pseudo-keyword [RFC,v3,65/78] hw/nvme: add fallthrough pseudo-keyword [RFC,v3,66/78] hw/nvram/eeprom_at24c.c: add fallthrough pseudo-keyword [RFC,v3,67/78] hw/pci-host/pnv_phb3.c: add fallthrough pseudo-keyword [RFC,v3,68/78] hw/pci: add fallthrough pseudo-keyword [RFC,v3,69/78] hw/rdma/rdma_backend.c: add fallthrough pseudo-keyword [RFC,v3,70/78] hw/rtc: add fallthrough pseudo-keyword [RFC,v3,71/78] hw/s390x: add fallthrough pseudo-keyword [RFC,v3,72/78] hw/ssi: add fallthrough pseudo-keyword [RFC,v3,73/78] hw/watchdog/wdt_diag288.c: add fallthrough pseudo-keyword [RFC,v3,74/78] hw/cxl/cxl-device-utils.c: add fallthrough pseudo-keyword [RFC,v3,75/78] migration: add fallthrough pseudo-keyword [RFC,v3,76/78] qemu-img.c: add fallthrough pseudo-keyword [RFC,v3,77/78] tests/unit/test-char.c: add fallthrough pseudo-keyword [RFC,v3,78/78] meson.build: increase -Wimplicit-fallthrough to 5

Commit Message

Manos Pitsidianakis Oct. 13, 2023, 8:46 a.m. UTC

In preparation of raising -Wimplicit-fallthrough to 5, replace all
fall-through comments with the fallthrough attribute pseudo-keyword.

Signed-off-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>
---
 migration/migration.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabiano Rosas Oct. 16, 2023, 2:02 p.m. UTC | #1

Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org> writes:

> In preparation of raising -Wimplicit-fallthrough to 5, replace all
> fall-through comments with the fallthrough attribute pseudo-keyword.
>
> Signed-off-by: Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org>

Reviewed-by: Fabiano Rosas <farosas@suse.de>

diff mbox series

Patch

diff --git a/migration/migration.c b/migration/migration.c
index 585d3c8f55..fdad37efbb 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2784,7 +2784,7 @@  static void migration_iteration_finish(MigrationState *s)
         assert(migrate_colo());
         migrate_start_colo_process(s);
         s->vm_old_state = RUN_STATE_RUNNING;
-        /* Fallthrough */
+        fallthrough;
     case MIGRATION_STATUS_FAILED:
     case MIGRATION_STATUS_CANCELLED:
     case MIGRATION_STATUS_CANCELLING: