| Message ID | 64de87ae9e03e9be6cb98dc75e2eb02503354904.1726293808.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add ACPI CPER firmware first error injection on ARM emulation | expand |
On Sat, 14 Sep 2024 08:13:29 +0200 Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > HEST source ID is actually a 16-bit value. Yet, make it a little > bit more generic using just an integer type. wouldn't uint16_t be better to use, to explicitly show expectations? > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> > --- > hw/acpi/ghes-stub.c | 2 +- > hw/acpi/ghes.c | 2 +- > include/hw/acpi/ghes.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/acpi/ghes-stub.c b/hw/acpi/ghes-stub.c > index c315de1802d6..58a04e935142 100644 > --- a/hw/acpi/ghes-stub.c > +++ b/hw/acpi/ghes-stub.c > @@ -11,7 +11,7 @@ > #include "qemu/osdep.h" > #include "hw/acpi/ghes.h" > > -int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address) > +int acpi_ghes_record_errors(int source_id, uint64_t physical_address) > { > return -1; > } > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > index 6e5f0e8cf0c9..4e34b16a6ca9 100644 > --- a/hw/acpi/ghes.c > +++ b/hw/acpi/ghes.c > @@ -416,7 +416,7 @@ void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s, > ags->present = true; > } > > -int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address) > +int acpi_ghes_record_errors(int source_id, uint64_t physical_address) > { > uint64_t hest_read_ack_start_addr, read_ack_start_addr; > uint64_t hest_addr, cper_addr, err_source_struct; > diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h > index 7485f54c28f2..6471934d7775 100644 > --- a/include/hw/acpi/ghes.h > +++ b/include/hw/acpi/ghes.h > @@ -75,7 +75,7 @@ void acpi_build_hest(GArray *table_data, GArray *hardware_errors, > const char *oem_id, const char *oem_table_id); > void acpi_ghes_add_fw_cfg(AcpiGhesState *vms, FWCfgState *s, > GArray *hardware_errors); > -int acpi_ghes_record_errors(uint8_t source_id, > +int acpi_ghes_record_errors(int source_id, > uint64_t error_physical_addr); > void ghes_record_cper_errors(const void *cper, size_t len, > uint16_t source_id, Error **errp);
diff --git a/hw/acpi/ghes-stub.c b/hw/acpi/ghes-stub.c index c315de1802d6..58a04e935142 100644 --- a/hw/acpi/ghes-stub.c +++ b/hw/acpi/ghes-stub.c @@ -11,7 +11,7 @@ #include "qemu/osdep.h" #include "hw/acpi/ghes.h" -int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address) +int acpi_ghes_record_errors(int source_id, uint64_t physical_address) { return -1; } diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index 6e5f0e8cf0c9..4e34b16a6ca9 100644 --- a/hw/acpi/ghes.c +++ b/hw/acpi/ghes.c @@ -416,7 +416,7 @@ void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s, ags->present = true; } -int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address) +int acpi_ghes_record_errors(int source_id, uint64_t physical_address) { uint64_t hest_read_ack_start_addr, read_ack_start_addr; uint64_t hest_addr, cper_addr, err_source_struct; diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h index 7485f54c28f2..6471934d7775 100644 --- a/include/hw/acpi/ghes.h +++ b/include/hw/acpi/ghes.h @@ -75,7 +75,7 @@ void acpi_build_hest(GArray *table_data, GArray *hardware_errors, const char *oem_id, const char *oem_table_id); void acpi_ghes_add_fw_cfg(AcpiGhesState *vms, FWCfgState *s, GArray *hardware_errors); -int acpi_ghes_record_errors(uint8_t source_id, +int acpi_ghes_record_errors(int source_id, uint64_t error_physical_addr); void ghes_record_cper_errors(const void *cper, size_t len, uint16_t source_id, Error **errp);
HEST source ID is actually a 16-bit value. Yet, make it a little bit more generic using just an integer type. Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- hw/acpi/ghes-stub.c | 2 +- hw/acpi/ghes.c | 2 +- include/hw/acpi/ghes.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)