[v2,1/5] cpus: correct coding style in qmp_memsave/qmp_pmemsave

Commit Message

Simon Ruderich April 12, 2018, 12:50 p.m. UTC

Signed-off-by: Simon Ruderich <[e-mail]>
---
 cpus.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Eric Blake April 17, 2018, 8:56 p.m. UTC | #1

On 04/12/2018 07:50 AM, Simon Ruderich wrote:
> Signed-off-by: Simon Ruderich <[e-mail]>
> ---
>  cpus.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <[e-mail]>

However, as a meta-comment, this message was sent with:

> Message-Id: <[e-mail]>
> In-Reply-To: <[e-mail]>
> References: <[e-mail]>

Looking on patchew, I see:
http://patchew.org/QEMU/[e-mail]/
The requested URL /QEMU/[e-mail]/ was not
found on this server.

For most messages, looking up the In-Reply-To: message-id gives the
cover letter (for example,
http://patchew.org/QEMU/[e-mail]/)

Similarly, looking on the list archives, I don't see the 0/5 cover
letter, but rather that your messages are treated as threaded to your v1
thread:

https://lists.gnu.org/archive/html/qemu-devel/2018-04/threads.html#01388

For the sake of tooling, it's best to send a v2 series with a new cover
letter as a new top-level thread.

Simon Ruderich April 22, 2018, 9:19 a.m. UTC | #2

On Tue, Apr 17, 2018 at 03:56:58PM -0500, Eric Blake wrote:
> On 04/12/2018 07:50 AM, Simon Ruderich wrote:
>> Signed-off-by: Simon Ruderich <[e-mail]>
>> ---
>>  cpus.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> Reviewed-by: Eric Blake <[e-mail]>
>
> However, as a meta-comment, this message was sent with:
>
>> Message-Id: <[e-mail]>
>> In-Reply-To: <[e-mail]>
>> References: <[e-mail]>
>
> Looking on patchew, I see:
> http://patchew.org/QEMU/[e-mail]/
> The requested URL /QEMU/[e-mail]/ was not
> found on this server.
>
> For most messages, looking up the In-Reply-To: message-id gives the
> cover letter (for example,
> http://patchew.org/QEMU/[e-mail]/)
>
> Similarly, looking on the list archives, I don't see the 0/5 cover
> letter, but rather that your messages are treated as threaded to your v1
> thread:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-04/threads.html#01388
>
> For the sake of tooling, it's best to send a v2 series with a new cover
> letter as a new top-level thread.

Yeah, I screwed that part up. Sorry for the extra work. Will fix
when I resend the series.

Regards
Simon

Patch

diff --git a/cpus.c b/cpus.c
index 38eba8bff3..c78f430532 100644
--- a/cpus.c
+++ b/cpus.c
@@ -2263,8 +2263,9 @@  void qmp_memsave(int64_t addr, int64_t size, const char *filename,
 
     while (size != 0) {
         l = sizeof(buf);
-        if (l > size)
+        if (l > size) {
             l = size;
+        }
         if (cpu_memory_rw_debug(cpu, addr, buf, l, 0) != 0) {
             error_setg(errp, "Invalid addr 0x%016" PRIx64 "/size %" PRId64
                              " specified", orig_addr, orig_size);
@@ -2297,8 +2298,9 @@  void qmp_pmemsave(int64_t addr, int64_t size, const char *filename,
 
     while (size != 0) {
         l = sizeof(buf);
-        if (l > size)
+        if (l > size) {
             l = size;
+        }
         cpu_physical_memory_read(addr, buf, l);
         if (fwrite(buf, 1, l, f) != l) {
             error_setg(errp, QERR_IO_ERROR);