| Message ID | 8f8a151dae565027208268ed8d120e4612ef5f9f.1537367701.git.berto@igalia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Don't pass flags to bdrv_reopen_queue() | expand |
On 19.09.18 16:47, Alberto Garcia wrote: > This patch replaces the bdrv_reopen() calls that set and remove the > BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Ha! Got you! It's just one call this time, not "calls"! :-) > Signed-off-by: Alberto Garcia <berto@igalia.com> > --- > blockdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Max Reitz <mreitz@redhat.com>
On Mon 08 Oct 2018 03:31:08 AM CEST, Max Reitz wrote: > On 19.09.18 16:47, Alberto Garcia wrote: >> This patch replaces the bdrv_reopen() calls that set and remove the >> BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. > > Ha! Got you! It's just one call this time, not "calls"! :-) :-D Berto
diff --git a/blockdev.c b/blockdev.c index 58e057b0d9..2f2359593e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1701,8 +1701,7 @@ static void external_snapshot_commit(BlkActionState *common) * bdrv_reopen_multiple() across all the entries at once, because we * don't want to abort all of them if one of them fails the reopen */ if (!atomic_read(&state->old_bs->copy_on_read)) { - bdrv_reopen(state->old_bs, state->old_bs->open_flags & ~BDRV_O_RDWR, - NULL); + bdrv_reopen_set_read_only(state->old_bs, true, NULL); } aio_context_release(aio_context);
This patch replaces the bdrv_reopen() calls that set and remove the BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function. Signed-off-by: Alberto Garcia <berto@igalia.com> --- blockdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)