From patchwork Sat Feb 17 11:26:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 10226073 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BD50D602CB for ; Sat, 17 Feb 2018 11:28:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A32C428765 for ; Sat, 17 Feb 2018 11:28:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 97856287D0; Sat, 17 Feb 2018 11:28:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0328428765 for ; Sat, 17 Feb 2018 11:28:08 +0000 (UTC) Received: from localhost ([::1]:38977 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1en0f1-0002Yj-Ub for patchwork-qemu-devel@patchwork.kernel.org; Sat, 17 Feb 2018 06:28:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1en0dt-0001kB-TA for qemu-devel@nongnu.org; Sat, 17 Feb 2018 06:26:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1en0dq-0001VW-P0 for qemu-devel@nongnu.org; Sat, 17 Feb 2018 06:26:57 -0500 Received: from mout.web.de ([217.72.192.78]:49739) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1en0dq-0001Ub-FK for qemu-devel@nongnu.org; Sat, 17 Feb 2018 06:26:54 -0500 Received: from [192.168.1.10] ([95.157.57.47]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MWAwH-1fFyXT0oB7-00XI05; Sat, 17 Feb 2018 12:26:50 +0100 To: Gerd Hoffmann From: Jan Kiszka Message-ID: <902aaef8-d20e-0530-dea2-cdfe3db33ff3@web.de> Date: Sat, 17 Feb 2018 12:26:49 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 Content-Language: en-US X-Provags-ID: V03:K0:xyzSUBFtd0/MP9xeYU8csqzFSW1FfJqC/9b3Rq++4ptwX1bxMDd 6WDdf4eEUt1kV9EExPKVEa9NcNFzOLS9xHx1mmBVCF7i+5Qn+LHssavIUt5H2BfX/Zebs+0 9EIz+2lvetf3WpyuvjheeHFmOPK4V6JSbBt3IU25hLQgAJSaacfNhb8zrSUHmBxnwb0fQVX Dd2uMj5Y59XxmnCPE39ng== X-UI-Out-Filterresults: notjunk:1; V01:K0:lhHpBaVyedU=:HKFNGX6jCv76+RBVa/v49j 2Wd5vhReD/1fXxbgoxImiI5SZyNf+kulrI6CTDB1j/IqC1e1dj82+B5/vdsLdyyMKbwFBNDQ3 YmIV3dX9O4zJSr3yz8w/M5nhR9it9CyTuhvbnOvGap7pju84jkywZO16tIiEYjRDVR4EnDtGv tiJxYUUT8KFM9Y6jMQZZOAkvCNoM/8R/0DEMalrn4KLHMZMfVdGm2+OHTTHc9sUu+bQdogHJG tL5qYXmzxzsrPntvM1palEQ4Pb/sIxXukQRqY+9Y6522eOoyRQ4cLoB925rj+yOxwGLVE3TKD g0VL3kirhsp7cHlTB0ye7jY8WxI1PhO2KNAFA/5nRb8y7TPUTi+g62KFpyOL6y6upKHjXaO35 f7398iv78fKh4NNEZ7e4ziZ2KRZORVTsf7wkOp+BbcZl+JnlfPH5piO6IpveuPoAGKYSMPLgY 6DvtTDwScjYng/+SPpbF5Uv+AI4PJgdihsIGcivWnIYcEuXvau/Y3Xw/kRwpt0NZfmuy0B6Dq 2Qi3c0A9ObFoHF+OhxL9nVCLVHR3ryWI/2Jjk8+aJRUykX8513ZA74NZRCSiRa7ATcHRcZLOZ la4BgywM5wP1qW9ZdkD42rVjTJILmKJ4+8JISr5AqYOBdzA4c6GItVHxYe6usGNgdZDo3Y0ar 8Oya4t3+Dt5AIUw2PMGe/GeyeaVdmvd9ItLR+DRnFAgJ+aEvObLWSZ6fjGYOlxR0y/nuzDI6o 0GV85Grp0K6n8NDSvFcikOVD+7pnM3cqTcNL8e1yCbiQaCAGW9ISJeydA/4J8hE+e1bXa/ic0 4xFXsFYUKhY1/Nu3oD1S8nWNnsc5Li3+mxFBIk1lNqlOpZlbB8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.72.192.78 Subject: [Qemu-devel] [PATCH] ui: Reorder vte terminal packing to avoid gtk3 warnings X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Jan Kiszka Fill the terminal box from right to left to avoid Gtk-WARNING **: Allocating size to GtkScrollbar 0x55f6d54b0200 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate? Signed-off-by: Jan Kiszka --- ui/gtk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 1537751afa..81f729316b 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1945,8 +1945,8 @@ static GSList *gd_vc_vte_init(GtkDisplayState *s, VirtualConsole *vc, scrollbar = gtk_vscrollbar_new(vadjustment); #endif - gtk_box_pack_start(GTK_BOX(box), vc->vte.terminal, TRUE, TRUE, 0); - gtk_box_pack_start(GTK_BOX(box), scrollbar, FALSE, FALSE, 0); + gtk_box_pack_end(GTK_BOX(box), scrollbar, FALSE, FALSE, 0); + gtk_box_pack_end(GTK_BOX(box), vc->vte.terminal, TRUE, TRUE, 0); vc->vte.box = box; vc->vte.scrollbar = scrollbar;