| Message ID | 947fcb0c386e77b5ef59f4a6ca48baeee0d1a980.1706279540.git.manos.pitsidianakis@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix resource freeing bugs in virtio-gpu-rutabaga | expand |
On Fri, Jan 26, 2024 at 7:43 PM Manos Pitsidianakis <manos.pitsidianakis@linaro.org> wrote: > > While the VirtioGPU type has a reset_bh field to specify a reset > callback, it's never used. virtio_gpu_reset() calls the general > virtio_gpu_reset_bh() function for all devices that inherit from > VirtioGPU. > > While no devices override reset_bh at the moment, a device reset might > require special logic for implementations in the future. > > Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > hw/display/virtio-gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c > index f8a675eb30..2b73ae585b 100644 > --- a/hw/display/virtio-gpu.c > +++ b/hw/display/virtio-gpu.c > @@ -1515,7 +1515,7 @@ void virtio_gpu_reset(VirtIODevice *vdev) > qemu_cond_wait_bql(&g->reset_cond); > } > } else { > - virtio_gpu_reset_bh(g); > + aio_bh_call(g->reset_bh); > } > > while (!QTAILQ_EMPTY(&g->cmdq)) { > -- > γαῖα πυρί μιχθήτω > >
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index f8a675eb30..2b73ae585b 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -1515,7 +1515,7 @@ void virtio_gpu_reset(VirtIODevice *vdev) qemu_cond_wait_bql(&g->reset_cond); } } else { - virtio_gpu_reset_bh(g); + aio_bh_call(g->reset_bh); } while (!QTAILQ_EMPTY(&g->cmdq)) {
While the VirtioGPU type has a reset_bh field to specify a reset callback, it's never used. virtio_gpu_reset() calls the general virtio_gpu_reset_bh() function for all devices that inherit from VirtioGPU. While no devices override reset_bh at the moment, a device reset might require special logic for implementations in the future. Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> --- hw/display/virtio-gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)