From patchwork Thu Nov 3 21:48:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Evans X-Patchwork-Id: 9411695 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 10FA460234 for ; Fri, 4 Nov 2016 00:52:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01AFC2B02D for ; Fri, 4 Nov 2016 00:52:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E70322B035; Fri, 4 Nov 2016 00:52:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 59D4E2B02D for ; Fri, 4 Nov 2016 00:52:29 +0000 (UTC) Received: from localhost ([::1]:35828 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2Sk7-0004IG-Pf for patchwork-qemu-devel@patchwork.kernel.org; Thu, 03 Nov 2016 20:52:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <3yLAbWAMKCl8AGBDLLDIB.9LJNBJR-ABSBIKLKDKR.LOD@flex--dje.bounces.google.com>) id 1c2Psa-0006gR-AK for qemu-devel@nongnu.org; Thu, 03 Nov 2016 17:49:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <3yLAbWAMKCl8AGBDLLDIB.9LJNBJR-ABSBIKLKDKR.LOD@flex--dje.bounces.google.com>) id 1c2PsZ-0002mz-Jx for qemu-devel@nongnu.org; Thu, 03 Nov 2016 17:49:00 -0400 Received: from mail-pa0-x249.google.com ([2607:f8b0:400e:c03::249]:35893) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <3yLAbWAMKCl8AGBDLLDIB.9LJNBJR-ABSBIKLKDKR.LOD@flex--dje.bounces.google.com>) id 1c2PsZ-0002kw-DG for qemu-devel@nongnu.org; Thu, 03 Nov 2016 17:48:59 -0400 Received: by mail-pa0-x249.google.com with SMTP id xn9so302289pac.3 for ; Thu, 03 Nov 2016 14:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:message-id:date:subject:from:to; bh=jNnLiKH4eoV3408B5wOZoagpzErdXIfOxN2kL+1v9SA=; b=HAi5dd2PPEDDqX5tlr1t0pXGiuFGDhbAgJ9zAS7H95cUtCDJHSCduEch6RWrjJsWTg wDGdlOrKjzRcncBeCT0NAzgPbxHO76tHeYPaNFG3F5W0QHaGc865QW8a0ugX52b9OVKA v9kKkJ7zhkURIHHa5ta69FDfRZTJYGF/yZXbxAMds/j18Xv+pS+KbEziZVaAXy6lAQVp 8ORNBeTDtlpTdqi2llfu0I5wOL3OiPqe5RvphKILZFBF/BvLB3H+LYRjAeopbwJ6/aeP k10UNHS7w0UQXL3cPLhsRkb1e+q+Pry+EzzKPAaJa6jgA8Kmoi1BNAEAgaXdvSIsDMAb itYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:message-id:date:subject:from:to; bh=jNnLiKH4eoV3408B5wOZoagpzErdXIfOxN2kL+1v9SA=; b=OByC4Wy/w/bs3ZWTYaTUsRcjyFrr1tyao8u3bOj19l4FMIAlfaYJCIETn1o5wKkH2E 6izktO8600pgvkfffsl8oLHfft0EqIb/KDPICYkTkkoGNyMATqz05oRzUXvzykWuEOCJ QZvVt9Br3PezTafTtWAU40+1P4YlcNZnessd2T4A/4M6Aj48FJya1nYu85CZs1Wm4QyV UZeEaTtYSqB2+hGtakbxs35LC6n6WI5PNBM8BDr5cV7NeKjBKB+U6KJVo2jVAHn9zUqG Es4e5uea2RwUcbPvWyItZ0ZmMoJzVrplNOiHUx4jT+pZU5rIb4bME4gc4BkRJNji1GM2 nR7Q== X-Gm-Message-State: ABUngve030//HuxHMviBbVbwvu0ZWkmGxLBVqaNinowqIwBYo0xns1K1Wprl8LdDn5T1AcEd9/AU0gVSVCmx/Qm0JIGfXS40rPno1RcrIXpigxCF9eVTpWZGuPhmBvYV8UdDgMFJjnpZK2KlWWXutQi4AX3G0+thwcZfRdGyjv358QI= MIME-Version: 1.0 X-Received: by 10.98.201.151 with SMTP id l23mr3302317pfk.26.1478209736769; Thu, 03 Nov 2016 14:48:56 -0700 (PDT) Message-ID: <94eb2c187eda43dba005406c86f7@google.com> Date: Thu, 03 Nov 2016 21:48:56 +0000 From: Doug Evans To: qemu-devel@nongnu.org, pbonzini@redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c03::249 X-Mailman-Approved-At: Thu, 03 Nov 2016 20:51:37 -0400 Subject: [Qemu-devel] [PATCH] Document how x86 gdb_num_core_regs is computed. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Hi. It helps when reading the code to see how the number is arrived at. Signed-off-by: Doug Evans --- target-i386/cpu.c | 2 ++ 1 file changed, 2 insertions(+) cc->debug_excp_handler = breakpoint_handler; -- diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 14c5186..01f1ab0 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -3721,6 +3721,8 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data) cc->write_elf32_qemunote = x86_cpu_write_elf32_qemunote; cc->vmsd = &vmstate_x86_cpu; #endif + /* CPU_NB_REGS * 2 = general regs + xmm regs + 25 = eip, eflags, 6 seg regs, st[0-7], fctrl,...,fop, mxcsr */ cc->gdb_num_core_regs = CPU_NB_REGS * 2 + 25; #ifndef CONFIG_USER_ONLY