From patchwork Tue Apr 12 18:22:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nutan Shinde X-Patchwork-Id: 8814051 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6BDEAC0554 for ; Tue, 12 Apr 2016 18:22:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C5C8E2034C for ; Tue, 12 Apr 2016 18:22:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 227C0201CD for ; Tue, 12 Apr 2016 18:22:51 +0000 (UTC) Received: from localhost ([::1]:54932 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aq2xe-00086z-Gc for patchwork-qemu-devel@patchwork.kernel.org; Tue, 12 Apr 2016 14:22:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aq2xT-00084Y-Qj for qemu-devel@nongnu.org; Tue, 12 Apr 2016 14:22:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aq2xT-000624-0H for qemu-devel@nongnu.org; Tue, 12 Apr 2016 14:22:39 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34433) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aq2xS-00061y-Px for qemu-devel@nongnu.org; Tue, 12 Apr 2016 14:22:38 -0400 Received: by mail-wm0-x244.google.com with SMTP id n3so7633734wmn.1 for ; Tue, 12 Apr 2016 11:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=r8lykSICotYLECVXwg7MfIEPe6A0sdUT/fACzh8P4+M=; b=BVlGcWaWy6yPmgW2os3/dmbkZFpzxFyZ8u+BtZZkuW2O4CiecdN6ijNux72eLCC/tY ovu/xMT8m2dKvUKBEqhdD8UNBAR33oKHqSpZGkcuLH1r9GIwVNZgb3FUy+QEbdQ437GJ xFnVpGUvJ7/iiEjtxd1fYgogvR7XNrkea+gqC+Yt5269lieRINDbii8r5Z+j82rs6CbR lDt8KduW2/jW5Qr0CHGC5C1hgevKAD+QuP4d05KQKcXrBrKGilObquvXaCZhKJQLjZl+ jyPWV+sHKPo16MwmiVW7VSQWGuBj124rUaYI7H9aicKuyAF3GP6fh/cwVormBEDBxqZ1 Fleg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=r8lykSICotYLECVXwg7MfIEPe6A0sdUT/fACzh8P4+M=; b=eBM8wwTh5QLOt7ZU+Cg+f/XRBQVyHy1qMAGRG17+ZknMTEKJ09fF1RHrKffm3sxWaL KSC5YeYXffr8asSMtD72b+u13xZGckgvUDu2oyr28yUu7zwkuL+aH2NTfq02rQAvDEn9 sMP0nvk9iO9b8qzSBPzjqXdaHrXuKukuddcXwYlejo8b8AUeKQ26CGCHa+u+l87k4ZUt /mQrHwfipLPJoqGJ4LDNmCeoMIsXzDInmlizk601At8ICjAr2T6+Z3jgsDjWA0Cn416N itV/YVRynUkOZepM5Ynh3hJaxVSoQ6LkQhmpqfCcpDyE/hfawoAZp/dXcyBU0Kjaz7Bg aMNw== X-Gm-Message-State: AOPr4FUNY7tl5HHhOzvRJ+uPha7qgH2tM7VvF0VK+5uOgKYcwrP9OOxQHfYpaIC7Jg4TJVQixsRUhj3XbrbP/g== MIME-Version: 1.0 X-Received: by 10.194.21.131 with SMTP id v3mr5259336wje.132.1460485358101; Tue, 12 Apr 2016 11:22:38 -0700 (PDT) Received: by 10.194.38.101 with HTTP; Tue, 12 Apr 2016 11:22:38 -0700 (PDT) In-Reply-To: <1460485283-6007-1-git-send-email-nutanshinde1992@gmail.com> References: <1460485283-6007-1-git-send-email-nutanshinde1992@gmail.com> Date: Tue, 12 Apr 2016 23:52:38 +0530 Message-ID: From: Nutan Shinde To: QEMU Developers , cornelia.huck@de.ibm.com, borntraeger@de.ibm.com, agraf@suse.de, pbonzini@redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::244 Subject: [Qemu-devel] Fwd: [PATCH v2 3/5] Change return type of functions that are named *_exit or *_exitfn in hw/core from int to void X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This change is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/core package. Signed-off-by: Nutan Shinde --- hw/core/qdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- 1.9.1 diff --git a/hw/core/qdev.c b/hw/core/qdev.c index db41aa1..7495fcf 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -237,11 +237,7 @@ static void device_unrealize(DeviceState *dev, Error **errp) DeviceClass *dc = DEVICE_GET_CLASS(dev); if (dc->exit) { - int rc = dc->exit(dev); - if (rc < 0) { - error_setg(errp, "Device exit failed."); - return; - } + dc->exit(dev); } }