From patchwork Tue Apr 12 18:27:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nutan Shinde X-Patchwork-Id: 8814101 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E907A9F3D1 for ; Tue, 12 Apr 2016 18:27:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 245E2201CD for ; Tue, 12 Apr 2016 18:27:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FEAB201BB for ; Tue, 12 Apr 2016 18:27:18 +0000 (UTC) Received: from localhost ([::1]:55013 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aq31x-00068t-F6 for patchwork-qemu-devel@patchwork.kernel.org; Tue, 12 Apr 2016 14:27:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aq31o-00065K-Ih for qemu-devel@nongnu.org; Tue, 12 Apr 2016 14:27:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aq31n-0007Q7-HR for qemu-devel@nongnu.org; Tue, 12 Apr 2016 14:27:08 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:36687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aq31n-0007Or-3K for qemu-devel@nongnu.org; Tue, 12 Apr 2016 14:27:07 -0400 Received: by mail-wm0-x243.google.com with SMTP id l6so7645565wml.3 for ; Tue, 12 Apr 2016 11:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=nUl5yjD53uk2TJTIXErLejfQN2ZsGvjR565vprSkTxA=; b=zN4rddkbEBWBLXGfjhtIorjYX1pSJ0Qes46PivCU7bAkUhM7DktE1goZRFHT3RfSPV 4mYXqHrsKWHxpt74kPDo4OrHiQi3ZRmkHKlooAmDMJGNzWPU0jRKqaYB+c2xibJx5mGg CVp0VxFELFOw+Wp7qRYro28IFZJiV7HpwLCfSOTAZQoeBOSGctttYMdwGgKFiDpAxR/P IksUw6jYonEpe65UI1SajhN9Pg5y13/KCfP2JDnHP1p+yxCEwxXdEbzPjDZFaP+Jko9U E7QJ+otDcd+vTk0gDFYEjrDdNAsjehUTOqxshMKvKYKLQvc/okL55hhpb+jlKadFw42Z INEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=nUl5yjD53uk2TJTIXErLejfQN2ZsGvjR565vprSkTxA=; b=hsltVsfhBnCFhhqDMq+gh7qiz/jNMnp3aTeYKjcvvsDkv5rpadrxzP4gRO9SnjlpsW TGypNO0BcxUYcmLbs7hASdU2ftyVlL13jcQ/3+w1IpTGYnb10gwaCFovy/YSGUeitpSz YyIhk0zZuHiqQDmx5yiMinvOoM2MeqwUJ2IH3FQpmrc5iHuMHK8oo9lPmB0AujN7GJG9 LVaX6OgLMbvV0VuAarMUCxZ4JmpXZwewj020pJKsrxaAU4giyyuValIOqkKu+CtLd+El 1bE2dLGXmZfK7FKSZwoG+Ob3GTJvYf0f0TMZs5adE6+tA7hNz1Hr2rgiHanYymeV4SMF cRPQ== X-Gm-Message-State: AOPr4FU1xh10qqv6BSjAcmqTQPTM5eTqBJBYblzdCldZlLxD9wN3WwoBjnhpHDCtPDxwaOce/brBXswlYEGJwA== MIME-Version: 1.0 X-Received: by 10.28.143.207 with SMTP id r198mr6007269wmd.56.1460485626461; Tue, 12 Apr 2016 11:27:06 -0700 (PDT) Received: by 10.194.38.101 with HTTP; Tue, 12 Apr 2016 11:27:06 -0700 (PDT) In-Reply-To: <1460485534-6116-1-git-send-email-nutanshinde1992@gmail.com> References: <1460485534-6116-1-git-send-email-nutanshinde1992@gmail.com> Date: Tue, 12 Apr 2016 23:57:06 +0530 Message-ID: From: Nutan Shinde To: QEMU Developers , cornelia.huck@de.ibm.com, borntraeger@de.ibm.com, agraf@suse.de, pbonzini@redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] Fwd: [PATCH v2 4/5] Change return type of functions that are named *_exit or *_exitfn in hw/s390x from int to void X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This change is required because the return type of exit(error) function is not used. This patch only has changes for files in hw/s390x package. Signed-off-by: Nutan Shinde --- hw/s390x/virtio-ccw.c | 7 +++---- hw/s390x/virtio-ccw.h | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) the -- 1.9.1 diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index d51642d..e8b5a38 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -878,7 +878,7 @@ out_err: g_free(sch); } -static int virtio_ccw_exit(VirtioCcwDevice *dev) +static void virtio_ccw_exit(VirtioCcwDevice *dev) { SubchDev *sch = dev->sch; @@ -890,7 +890,6 @@ static int virtio_ccw_exit(VirtioCcwDevice *dev) release_indicator(&dev->routes.adapter, dev->indicators); dev->indicators = NULL; } - return 0; } static void virtio_ccw_net_realize(VirtioCcwDevice *ccw_dev, Error **errp) @@ -1735,12 +1734,12 @@ static void virtio_ccw_busdev_realize(DeviceState *dev, Error **errp) virtio_ccw_device_realize(_dev, errp); } -static int virtio_ccw_busdev_exit(DeviceState *dev) +static void virtio_ccw_busdev_exit(DeviceState *dev) { VirtioCcwDevice *_dev = (VirtioCcwDevice *)dev; VirtIOCCWDeviceClass *_info = VIRTIO_CCW_DEVICE_GET_CLASS(dev); - return _info->exit(_dev); + _info->exit(_dev); } static void virtio_ccw_busdev_unplug(HotplugHandler *hotplug_dev, diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio-ccw.h index 66c831b..854602f 100644 --- a/hw/s390x/virtio-ccw.h +++ b/hw/s390x/virtio-ccw.h @@ -68,7 +68,7 @@ typedef struct VirtioCcwDevice VirtioCcwDevice; typedef struct VirtIOCCWDeviceClass { DeviceClass parent_class; void (*realize)(VirtioCcwDevice *dev, Error **errp); - int (*exit)(VirtioCcwDevice *dev); + void (*exit)(VirtioCcwDevice *dev); } VirtIOCCWDeviceClass; /* Performance improves when virtqueue kick processing is decoupled from