From patchwork Wed Mar 16 17:42:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 8603171 Return-Path: X-Original-To: patchwork-qemu-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 91AD79F6E1 for ; Wed, 16 Mar 2016 17:43:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DC312202A1 for ; Wed, 16 Mar 2016 17:43:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D61A2020F for ; Wed, 16 Mar 2016 17:43:12 +0000 (UTC) Received: from localhost ([::1]:57888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agFTT-0007aI-G9 for patchwork-qemu-devel@patchwork.kernel.org; Wed, 16 Mar 2016 13:43:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agFTE-0007RT-Tu for qemu-devel@nongnu.org; Wed, 16 Mar 2016 13:42:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agFTD-0000iX-TB for qemu-devel@nongnu.org; Wed, 16 Mar 2016 13:42:56 -0400 Received: from mail-vk0-x22e.google.com ([2607:f8b0:400c:c05::22e]:36064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agFTD-0000iP-Fh for qemu-devel@nongnu.org; Wed, 16 Mar 2016 13:42:55 -0400 Received: by mail-vk0-x22e.google.com with SMTP id c3so71311449vkb.3 for ; Wed, 16 Mar 2016 10:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-transfer-encoding; bh=4PUN4eYg81rFL0srR565QduN+Izt9Wzw119s1rPB8mA=; b=QOQmMsob8sjrXN7DKgVry4XIeVbFATuvDy6VHJlwtorMYZE8wkZfdOkvPYOUJgDrU9 FB2PfUN6WDco84RiPoMU/HKakbEuhiX0CRnWOt9KyqQy2BPEHJ6sK5EIL0qNAGjEveMB 7oJoAY2Ip2OwLO7J9Qm2RQy8ni0ZYXWC0VvM0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-transfer-encoding; bh=4PUN4eYg81rFL0srR565QduN+Izt9Wzw119s1rPB8mA=; b=mWGSnrB8kXpDOPSn7T2QpuvCJlvZTpxJkWi+rxBTP+7NofSGPc5SZ/EC4Z33pVqiOi ct3re4Kr0jXfT09MGOVpLuUa8l82eD3+W0aQacvYieFB9iDBO/ty5wWZT8PJgmk3W6sJ F4zIGLwzbxLa4gkN0gbN6oQF0/MeUz7oDCOdEqpM29ZiKDjuW5+FSGpj8EpcEt0aVB6h fjKSqHyMXtpEzkj40iVCOVoMMq0YtKX3Ve6QjPCltpRD6TTGBaAI5VCCPRlkoo6YdsJL soaKJjnSJYj5HDj1a3JVfWSvJRygC0+sA01DJoLN/RHldpAMETOraxmHy88xOgs16LEL p3AA== X-Gm-Message-State: AD7BkJIo0Af/E9e+8tBdbRWRQYohYFjp9KzccohWemF+wnkVm3cqtXCn3On0J5+33wcuUpr1mh/TrS/qvS9etfmb X-Received: by 10.31.7.138 with SMTP id 132mr6080988vkh.92.1458150175036; Wed, 16 Mar 2016 10:42:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.216.1 with HTTP; Wed, 16 Mar 2016 10:42:35 -0700 (PDT) In-Reply-To: <1458148715-16864-1-git-send-email-peter.maydell@linaro.org> References: <1458148715-16864-1-git-send-email-peter.maydell@linaro.org> From: Peter Maydell Date: Wed, 16 Mar 2016 17:42:35 +0000 Message-ID: To: QEMU Developers X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c05::22e Subject: Re: [Qemu-devel] [PULL 00/21] target-arm queue X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 16 March 2016 at 17:18, Peter Maydell wrote: > Here's the target-arm queue; I'm a bit hesitant about the late-landing > various new board/SoC patches, but they won't affect anybody who isn't > trying to use those boards, so I think it's OK. > > (There are a few other patches on list which I definitely want to > get in before rc0 but they need a bit more review time I think.) > > thanks > -- PMM > > > The following changes since commit 0ebc03bc065329eaefb6493f5fa7df08df528f2a: > > util/base64.c: Clean includes (2016-03-16 12:48:11 +0000) > > are available in the git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20160316 > > for you to fetch changes up to 10b27d1ab391dbf36f92e1a33179662082401d7a: > > sd: Fix "info qtree" on boards with SD cards (2016-03-16 17:12:46 +0000) > > ---------------------------------------------------------------- > target-arm queue: > * loader: Fix incorrect parameter name in load_image_mr() > * Implement MRS (banked) and MSR (banked) instructions > * virt: Implement versioning for machine model > * i.MX: some initial patches preparing for i.MX6 support > * new ASPEED AST2400 SoC and palmetto-bmc machine > * bcm2835: add some more raspi2 devices > * sd: fix segfault running "info qtree" Some versions of gcc appear to give false positive 'may be used uninitialized' warnings about the msr/mrs code: /home/petmay01/linaro/qemu-for-merges/target-arm/translate.c: In function ‘gen_msr_banked .isra.45’: /home/petmay01/linaro/qemu-for-merges/target-arm/translate.c:4321:17: error: ‘tgtmode’ ma y be used uninitialized in this function [-Werror=maybe-uninitialized] tcg_tgtmode = tcg_const_i32(tgtmode); ^ /home/petmay01/linaro/qemu-for-merges/target-arm/translate.c:4322:15: error: ‘regno’ may be used uninitialized in this function [-Werror=maybe-uninitialized] tcg_regno = tcg_const_i32(regno); ^ /home/petmay01/linaro/qemu-for-merges/target-arm/translate.c: In function ‘gen_mrs_banked.isra.48’: /home/petmay01/linaro/qemu-for-merges/target-arm/translate.c:4343:17: error: ‘tgtmode’ may be used uninitialized in this function [-Werror=maybe-uninitialized] tcg_tgtmode = tcg_const_i32(tgtmode); ^ /home/petmay01/linaro/qemu-for-merges/target-arm/translate.c:4344:15: error: ‘regno’ may be used uninitialized in this function [-Werror=maybe-uninitialized] tcg_regno = tcg_const_i32(regno); ^ Fixup: return; which I'll squash into the appropriate patch and respin. thanks -- PMM --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -4308,7 +4308,7 @@ undef: static void gen_msr_banked(DisasContext *s, int r, int sysm, int rn) { TCGv_i32 tcg_reg, tcg_tgtmode, tcg_regno; - int tgtmode, regno; + int tgtmode = 0, regno = 0; if (!msr_banked_access_decode(s, r, sysm, rn, &tgtmode, ®no)) { return; @@ -4330,7 +4330,7 @@ static void gen_msr_banked(DisasContext *s, int r, int sysm, int rn) static void gen_mrs_banked(DisasContext *s, int r, int sysm, int rn) { TCGv_i32 tcg_reg, tcg_tgtmode, tcg_regno; - int tgtmode, regno; + int tgtmode = 0, regno = 0; if (!msr_banked_access_decode(s, r, sysm, rn, &tgtmode, ®no)) {