From patchwork Thu Jan 11 18:43:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Clark X-Patchwork-Id: 10158339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E7D6B60170 for ; Thu, 11 Jan 2018 18:44:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D9D532882F for ; Thu, 11 Jan 2018 18:44:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CB6E028834; Thu, 11 Jan 2018 18:44:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 47D2B2882F for ; Thu, 11 Jan 2018 18:44:33 +0000 (UTC) Received: from localhost ([::1]:33753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZhq4-0004TG-GF for patchwork-qemu-devel@patchwork.kernel.org; Thu, 11 Jan 2018 13:44:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZhox-0003dT-Gz for qemu-devel@nongnu.org; Thu, 11 Jan 2018 13:43:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZhow-0005ZV-77 for qemu-devel@nongnu.org; Thu, 11 Jan 2018 13:43:23 -0500 Received: from mail-oi0-x235.google.com ([2607:f8b0:4003:c06::235]:38173) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZhov-0005YT-Vr for qemu-devel@nongnu.org; Thu, 11 Jan 2018 13:43:22 -0500 Received: by mail-oi0-x235.google.com with SMTP id m65so2291008oig.5 for ; Thu, 11 Jan 2018 10:43:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7+eUbk9giOY29ntywML/ZvQPUNeSgsmCrnV9LLQ89Vw=; b=FsltcZF8qX/JKMyW830x64443BLfOHIPbMsAFdB9cUu/trE//MJz8psxC0w9cF6ke5 9Vlu862Zhj02EkBBjqUlLoaiAviGdbAVD0vdMfv+/ip8SSW205es7N1aBWcNb6B8Ygzo vhdLR8fk20u+H1dOGvQ4bP8KFq2EtsRCFoJzj559sgniyDnKoBladi/Te3eFSBCKwKwF PDXW2k9iwerTFfTMGy99Puw4oWCAZIKG+jB5YxalhRoH+4nKS7qGgXNdX9icTxI5wPku ouS9bK7B5dmQ454/FggxtCxGJp6YfHe1sw48FYi8dT34bAroLLu4C4JCg0A+uIhdk1WL Om0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7+eUbk9giOY29ntywML/ZvQPUNeSgsmCrnV9LLQ89Vw=; b=JeDsmfMgZ4p6Ba51YjGLwvNpfveDGJYlIA75KXZ1w+e/04RJjvstwDHP0FlQqBb+NX w2V/Q06UVrwQl3ScopeqMxIERS5Lw0O4vQ7kEktiXBHBBx1eAniwmOxUzjYJsh9elfb8 H6vGrQEAPEc6sDkDCmFURRZMCI7++T1wrl1xMFM92iEbwP5iHz4JzHb6cLHWdaV4eElE rEWwbZB7z9sih8NSnQ1g1wndjICHDLUUrhT5hErqIaklvU8nQtat1ENGrD0V8sGnKkY6 tA7HJ/qEfc/Py5iFVRh2p34i01JwptQ1wxq7+tJkoS6tb6GRDp90fk6jdL/PFZ3sF+HS 729Q== X-Gm-Message-State: AKwxytfm66neFhVfnu7ow3tqLGBGmimXzL4ZQRLRxTwgu7daQpASLBDW dnNNX9pBwQ2fr18BXjwrf/qnHs6BjxUC4oxx6WYsnA== X-Google-Smtp-Source: ACJfBouPsz6yogHKGnprBwftuLbHAgLXVynsV7xgN8zKYEUoso3vBt09VZc+AiDT5EjiR2KWgKB1CziaX+Z3aYVfr1k= X-Received: by 10.202.252.73 with SMTP id a70mr6209075oii.256.1515696201236; Thu, 11 Jan 2018 10:43:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.127.202 with HTTP; Thu, 11 Jan 2018 10:43:20 -0800 (PST) In-Reply-To: References: <1515637324-96034-1-git-send-email-mjc@sifive.com> <1515637324-96034-22-git-send-email-mjc@sifive.com> From: Michael Clark Date: Fri, 12 Jan 2018 07:43:20 +1300 Message-ID: To: Eric Blake X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::235 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH v3 21/21] RISC-V Build Infrastructure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Palmer Dabbelt , qemu-devel@nongnu.org, Sagar Karandikar , RISC-V Patches Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Jan 12, 2018 at 3:05 AM, Eric Blake wrote: > On 01/10/2018 08:22 PM, Michael Clark wrote: > > This adds RISC-V into the build system enabling the following targets: > > > > - riscv32-softmmu > > - riscv64-softmmu > > - riscv32-linux-user > > - riscv64-linux-user > > > > This adds defaults configs for RISC-V, enables the build for the RISC-V > > CPU core, hardware, and Linux User Emulation. The 'qemu-binfmt-conf.sh' > > script is updated to add the RISC-V ELF magic. > > > > +++ b/qapi-schema.json > > @@ -413,7 +413,7 @@ > > # Since: 2.6 > > ## > > { 'enum': 'CpuInfoArch', > > - 'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 'other' ] } > > + 'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 'riscv', 'other' ] > } > > Still missing documentation that riscv was added in 2.12 (see my > comments on v1). My apologies. I had a look at QKeyCode and it was not clear to me how to specify since on an enum value vs a field. ## { 'enum': 'CpuInfoArch', 'data': ['x86', 'sparc', 'ppc', 'mips', 'tricore', 'riscv', 'other' ] } Is this correct? > --- /dev/null > > +++ b/target/riscv/trace-events > > @@ -0,0 +1 @@ > > +# See docs/devel/tracing.txt for syntax documentation. > > > > Do we really need this file if you don't have any traces yet? > I'll remove the file or add some tracing in the next spin. --- a/qapi-schema.json +++ b/qapi-schema.json @@ -411,6 +411,9 @@ # @query-cpus. why is this @query-cpus and not @CpuInfoArch: as is the case for @QKeyCode? # # Since: 2.6 +# +# @riscv: since 2.12 +#