diff mbox series

Fix typo in comment (uin32_t -> uint32_t)

Message ID CAHt6W4fiLh+bBOX1qwvm-1qJVG=j9SrT5rMJnEaMSWPjwwZr1g@mail.gmail.com (mailing list archive)
State New, archived
Headers show
Series Fix typo in comment (uin32_t -> uint32_t) | expand

Commit Message

Frediano Ziglio March 1, 2024, 6:55 p.m. UTC 
Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
---
 hw/vfio/pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 {
     return (vendor == PCI_ANY_ID || vendor == vdev->vendor_id) &&

Comments

Zhao Liu March 2, 2024, 7:06 a.m. UTC | #1 
On Fri, Mar 01, 2024 at 06:55:35PM +0000, Frediano Ziglio wrote:
> Date: Fri, 1 Mar 2024 18:55:35 +0000
> From: Frediano Ziglio <freddy77@gmail.com>
> Subject: [PATCH] Fix typo in comment (uin32_t -> uint32_t)
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> ---
>  hw/vfio/pci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
> index 6e64a2654e..4bb7d7d257 100644
> --- a/hw/vfio/pci.h
> +++ b/hw/vfio/pci.h
> @@ -181,7 +181,7 @@ struct VFIOPCIDevice {
>      Notifier irqchip_change_notifier;
>  };
> 
> -/* Use uin32_t for vendor & device so PCI_ANY_ID expands and cannot match hw */
> +/* Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
> match hw */

It would be better to also change the comment style as:

/*
 * Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
 * match hw.
 */

Otherwise,

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

>  static inline bool vfio_pci_is(VFIOPCIDevice *vdev, uint32_t vendor,
> uint32_t device)
>  {
>      return (vendor == PCI_ANY_ID || vendor == vdev->vendor_id) &&
> -- 
> 2.34.1
>
Cédric Le Goater March 4, 2024, 6:04 a.m. UTC | #2 
On 3/2/24 08:06, Zhao Liu wrote:
> On Fri, Mar 01, 2024 at 06:55:35PM +0000, Frediano Ziglio wrote:
>> Date: Fri, 1 Mar 2024 18:55:35 +0000
>> From: Frediano Ziglio <freddy77@gmail.com>
>> Subject: [PATCH] Fix typo in comment (uin32_t -> uint32_t)
>>
>> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
>> ---
>>   hw/vfio/pci.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
>> index 6e64a2654e..4bb7d7d257 100644
>> --- a/hw/vfio/pci.h
>> +++ b/hw/vfio/pci.h
>> @@ -181,7 +181,7 @@ struct VFIOPCIDevice {
>>       Notifier irqchip_change_notifier;
>>   };
>>
>> -/* Use uin32_t for vendor & device so PCI_ANY_ID expands and cannot match hw */
>> +/* Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
>> match hw */
> 
> It would be better to also change the comment style as:
> 
> /*
>   * Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
>   * match hw.
>   */

yes and there is a similar typo in linux-user/fd-trans.c.

Thanks,

C.
diff mbox series

Patch

diff --git a/hw/vfio/pci.h b/hw/vfio/pci.h
index 6e64a2654e..4bb7d7d257 100644
--- a/hw/vfio/pci.h
+++ b/hw/vfio/pci.h
@@ -181,7 +181,7 @@  struct VFIOPCIDevice {
     Notifier irqchip_change_notifier;
 };

-/* Use uin32_t for vendor & device so PCI_ANY_ID expands and cannot match hw */
+/* Use uint32_t for vendor & device so PCI_ANY_ID expands and cannot
match hw */
 static inline bool vfio_pci_is(VFIOPCIDevice *vdev, uint32_t vendor,
uint32_t device)