From patchwork Tue Mar 23 18:55:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Schoenebeck X-Patchwork-Id: 12159197 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED24C433C1 for ; Tue, 23 Mar 2021 20:34:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E85E619BA for ; Tue, 23 Mar 2021 20:34:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E85E619BA Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lOnjF-0007IO-G5 for qemu-devel@archiver.kernel.org; Tue, 23 Mar 2021 16:34:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOni8-0005gq-OF for qemu-devel@nongnu.org; Tue, 23 Mar 2021 16:33:08 -0400 Received: from lizzy.crudebyte.com ([91.194.90.13]:58119) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lOni7-00078K-35 for qemu-devel@nongnu.org; Tue, 23 Mar 2021 16:33:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=lizzy; h=Cc:To:Subject:Date:From:References:In-Reply-To: Message-Id:Content-Type:Content-Transfer-Encoding:MIME-Version:Content-ID: Content-Description; bh=2D19tss3Rq3wIX7E3eq38tEnoGR9eq23qg4gxCDXyfU=; b=XPrR3 Ik0T7v7k/QV2SB5Z97rHu3FaYp4XPpxYV1CzwN28O7sFJvT/1wqlfKAC3IfSob7nylSzLWD2B3lEM 0Mnko15Y86fXhb2lgbu8uenOH1C6xxtlaj94HFI9uAGNsSQ8s4q1VFEiHeeT3fuHdwQYCpGCwU5S7 ovLE1IvsNbvZHPvpXFx2rrKBnXFqMa2R6+pNOOl5ysmU6U4mUIJrhxgfu65qykybkoe6di46hXxz8 xzQlAP3JiKiN/VtLQMYhcYli1IUodGuFxUMOBCIOC/FRVScZ4dHfhJruVJz3+E9KGU1/AASQwEN8X DWj3f/2LryjP9w37+FKHpQnCulC/Q==; Message-Id: In-Reply-To: References: From: Christian Schoenebeck Date: Tue, 23 Mar 2021 19:55:46 +0100 Subject: [PATCH 3/4] docs/devel/9p: fix references to pictures To: qemu-devel@nongnu.org Cc: Greg Kurz , Paolo Bonzini , Peter Maydell Received-SPF: none client-ip=91.194.90.13; envelope-from=a1ef93da295669d939df344e9169e1e8db57d9fd@lizzy.crudebyte.com; helo=lizzy.crudebyte.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The original source https://wiki.qemu.org/Documentation/9p does not use a prefixed path for pictures. The (auto converted) in-tree .rst version of the 9p documentation though uses pictures that are placed into the subdirectory 'img' for not mixing them with .rst files within the same directory, so prefix references to those pictures with 'img/'. Also the auto conversion tool 'pandoc' did not replace the image references by a correct 'image' rst keyword, so correct that as well. Signed-off-by: Christian Schoenebeck --- docs/devel/9p.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/devel/9p.rst b/docs/devel/9p.rst index e2a57b77b2..f326edc8d7 100644 --- a/docs/devel/9p.rst +++ b/docs/devel/9p.rst @@ -64,7 +64,7 @@ Topology The following figure shows the basic structure of the 9pfs implementation in QEMU. -`frameless|upright=3.0 `__ +.. image:: img/9pfs_topology.png The implementation consists of 3 modular components: 9p server, 9p filesystem drivers and 9p transport drivers. The 9p client on guest OS @@ -219,7 +219,7 @@ Another important aspect to know is that once a thread leaves the scope of a Coroutine, then that thread is back at using its own thread-owned stack again. -`frameless|upright=2.4 `__ +.. image:: img/Coroutines_stacks.png Each coroutine instance usually handles a certain "collaborative" task, where "collaborative" means that individual parts of the task usually @@ -253,7 +253,7 @@ Control Flow The following figure shows the control flow and relationship of Threads and Coroutines of the 9pfs implementation. -`frameless|upright=3.5 `__ +.. image:: img/9pfs_control_flow.png Getting back to 9pfs as concrete user of Coroutines, every 9P client request that comes in on 9P server side is a task the 9P server needs to