| Message ID | a3273a3c-c294-6340-7ea7-73e5696c7b2e@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Failing QEMU iotests | expand |
On 17.11.21 11:07, Thomas Huth wrote: > > Hi! > > I think it has been working fine for me a couple of weeks ago, > but when I now run: > > make check SPEED=slow > > I'm getting a couple of failing iotests... not sure whether > these are known issues already, so I thought I'd summarize them > here: Thanks! > *** First one is 045 in raw mode: *** > > TEST iotest-raw: 045 [fail] > QEMU -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64" > -nodefaults -display none -accel qtest > QEMU_IMG -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img" > QEMU_IO -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache > writeback --aio threads -f raw > QEMU_NBD -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd" > IMGFMT -- raw > IMGPROTO -- file > PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64 > TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch > SOCK_DIR -- /tmp/tmphlexdrlt > GDB_OPTIONS -- > VALGRIND_QEMU -- > PRINT_QEMU_OUTPUT -- > > --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out > +++ 045.out.bad > @@ -1,5 +1,77 @@ > -........... > +......EE.EE > +====================================================================== > +ERROR: test_add_fd (__main__.TestSCMFd) > +---------------------------------------------------------------------- > +Traceback (most recent call last): > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in > test_add_fd > + self._send_fd_by_SCM() > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in > _send_fd_by_SCM > + ret = self.vm.send_fd_scm(file_path=image0) > + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line > 229, in send_fd_scm > + self._qmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, > in send_fd_scm > + self._aqmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line > 149, in _wrapper > + return func(proto, *args, **kwargs) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line > 644, in send_fd_scm > + sock = sock._sock # pylint: disable=protected-access > +AttributeError: 'socket' object has no attribute '_sock' > + > +====================================================================== > +ERROR: test_closefd (__main__.TestSCMFd) > +---------------------------------------------------------------------- > +Traceback (most recent call last): > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 165, in > test_closefd > + self._send_fd_by_SCM() > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in > _send_fd_by_SCM > + ret = self.vm.send_fd_scm(file_path=image0) > + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line > 229, in send_fd_scm > + self._qmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, > in send_fd_scm > + self._aqmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line > 149, in _wrapper > + return func(proto, *args, **kwargs) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line > 644, in send_fd_scm > + sock = sock._sock # pylint: disable=protected-access > +AttributeError: 'socket' object has no attribute '_sock' > + > +====================================================================== > +ERROR: test_getfd (__main__.TestSCMFd) > +---------------------------------------------------------------------- > +Traceback (most recent call last): > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 153, in > test_getfd > + self._send_fd_by_SCM() > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in > _send_fd_by_SCM > + ret = self.vm.send_fd_scm(file_path=image0) > + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line > 229, in send_fd_scm > + self._qmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, > in send_fd_scm > + self._aqmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line > 149, in _wrapper > + return func(proto, *args, **kwargs) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line > 644, in send_fd_scm > + sock = sock._sock # pylint: disable=protected-access > +AttributeError: 'socket' object has no attribute '_sock' > + > +====================================================================== > +ERROR: test_getfd_invalid_fdname (__main__.TestSCMFd) > +---------------------------------------------------------------------- > +Traceback (most recent call last): > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 158, in > test_getfd_invalid_fdname > + self._send_fd_by_SCM() > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in > _send_fd_by_SCM > + ret = self.vm.send_fd_scm(file_path=image0) > + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line > 229, in send_fd_scm > + self._qmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, > in send_fd_scm > + self._aqmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line > 149, in _wrapper > + return func(proto, *args, **kwargs) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line > 644, in send_fd_scm > + sock = sock._sock # pylint: disable=protected-access > +AttributeError: 'socket' object has no attribute '_sock' > + > ---------------------------------------------------------------------- > Ran 11 tests > > -OK > +FAILED (errors=4) Sounds like something for John. O:) > > *** Second failure is in 206 in qcow2 mode: *** > > TEST iotest-qcow2: 206 [fail] > QEMU -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64" > -nodefaults -display none -accel qtest > QEMU_IMG -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img" > QEMU_IO -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache > writeback --aio threads -f qcow2 > QEMU_NBD -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd" > IMGFMT -- qcow2 > IMGPROTO -- file > PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64 > TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch > SOCK_DIR -- /tmp/tmpqg73ug_s > GDB_OPTIONS -- > VALGRIND_QEMU -- > PRINT_QEMU_OUTPUT -- > > --- /home/thuth/devel/qemu/tests/qemu-iotests/206.out > +++ 206.out.bad > @@ -99,55 +99,19 @@ > > {"execute": "blockdev-create", "arguments": {"job-id": "job0", > "options": {"driver": "qcow2", "encrypt": {"cipher-alg": > "twofish-128", "cipher-mode": "ctr", "format": "luks", "hash-alg": > "sha1", "iter-time": 10, "ivgen-alg": "plain64", "ivgen-hash-alg": > "md5", "key-secret": "keysec0"}, "file": {"driver": "file", > "filename": "TEST_DIR/PID-t.qcow2"}, "size": 33554432}}} > {"return": {}} > +Job failed: Unsupported cipher algorithm twofish-128 with ctr mode > {"execute": "job-dismiss", "arguments": {"id": "job0"}} > {"return": {}} > > image: TEST_IMG > file format: IMGFMT > virtual size: 32 MiB (33554432 bytes) > -encrypted: yes > cluster_size: 65536 > Format specific information: > compat: 1.1 > compression type: zlib > lazy refcounts: false > refcount bits: 16 > - encrypt: > - ivgen alg: plain64 > - hash alg: sha1 > - cipher alg: twofish-128 > - uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX > - format: luks > - cipher mode: ctr > - slots: > - [0]: > - active: true > - iters: XXX > - key offset: 4096 > - stripes: 4000 > - [1]: > - active: false > - key offset: 69632 > - [2]: > - active: false > - key offset: 135168 > - [3]: > - active: false > - key offset: 200704 > - [4]: > - active: false > - key offset: 266240 > - [5]: > - active: false > - key offset: 331776 > - [6]: > - active: false > - key offset: 397312 > - [7]: > - active: false > - key offset: 462848 > - payload offset: 528384 > - master key iters: XXX > corrupt: false > extended l2: false I doubt this worked a couple of weeks ago, but it’s definitely one that we should just get around to fixing. :/ > > *** Third one is in 297, both raw and qcow2 mode: *** > > --- /home/thuth/devel/qemu/tests/qemu-iotests/297.out > +++ 297.out.bad > @@ -1,2 +1,21 @@ > === pylint === > +************* Module image-fleecing > +tests/image-fleecing:34:24: C0326: Exactly one space required after > comma > +patterns = [('0x5d', '0', '64k'), > + ^ (bad-whitespace) > +tests/image-fleecing:35:25: C0326: Exactly one space required after > comma > + ('0xd5', '1M', '64k'), > + ^ (bad-whitespace) > +tests/image-fleecing:36:26: C0326: Exactly one space required after > comma > + ('0xdc', '32M', '64k'), > + ^ (bad-whitespace) > +tests/image-fleecing:39:25: C0326: Exactly one space required after > comma > +overwrite = [('0xab', '0', '64k'), # Full overwrite > + ^ (bad-whitespace) > +tests/image-fleecing:48:32: C0326: Exactly one space required after > comma > +remainder = [('0xd5', '0x108000', '32k'), # Right-end of > partial-left [1] > + ^ (bad-whitespace) > +tests/image-fleecing:49:27: C0326: Exactly one space required after > comma > + ('0xdc', '32M', '32k'), # Left-end of > partial-right [2] > + ^ (bad-whitespace) This could be because your pylint is too old. At least for the python/ tests we at least require 2.8.0 (https://lists.nongnu.org/archive/html/qemu-block/2021-10/msg00768.html) and bad-whitespace was removed in 2.6. Hanna
On 17/11/2021 11.59, Hanna Reitz wrote: > On 17.11.21 11:07, Thomas Huth wrote: >> >> Hi! >> >> I think it has been working fine for me a couple of weeks ago, >> but when I now run: >> >> make check SPEED=slow >> >> I'm getting a couple of failing iotests... not sure whether >> these are known issues already, so I thought I'd summarize them >> here: ... >> --- /home/thuth/devel/qemu/tests/qemu-iotests/206.out >> +++ 206.out.bad >> @@ -99,55 +99,19 @@ >> >> {"execute": "blockdev-create", "arguments": {"job-id": "job0", "options": >> {"driver": "qcow2", "encrypt": {"cipher-alg": "twofish-128", >> "cipher-mode": "ctr", "format": "luks", "hash-alg": "sha1", "iter-time": >> 10, "ivgen-alg": "plain64", "ivgen-hash-alg": "md5", "key-secret": >> "keysec0"}, "file": {"driver": "file", "filename": >> "TEST_DIR/PID-t.qcow2"}, "size": 33554432}}} >> {"return": {}} >> +Job failed: Unsupported cipher algorithm twofish-128 with ctr mode >> {"execute": "job-dismiss", "arguments": {"id": "job0"}} >> {"return": {}} >> >> image: TEST_IMG >> file format: IMGFMT >> virtual size: 32 MiB (33554432 bytes) >> -encrypted: yes >> cluster_size: 65536 >> Format specific information: >> compat: 1.1 >> compression type: zlib >> lazy refcounts: false >> refcount bits: 16 >> - encrypt: >> - ivgen alg: plain64 >> - hash alg: sha1 >> - cipher alg: twofish-128 >> - uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX >> - format: luks >> - cipher mode: ctr >> - slots: >> - [0]: >> - active: true >> - iters: XXX >> - key offset: 4096 >> - stripes: 4000 >> - [1]: >> - active: false >> - key offset: 69632 >> - [2]: >> - active: false >> - key offset: 135168 >> - [3]: >> - active: false >> - key offset: 200704 >> - [4]: >> - active: false >> - key offset: 266240 >> - [5]: >> - active: false >> - key offset: 331776 >> - [6]: >> - active: false >> - key offset: 397312 >> - [7]: >> - active: false >> - key offset: 462848 >> - payload offset: 528384 >> - master key iters: XXX >> corrupt: false >> extended l2: false > > I doubt this worked a couple of weeks ago, but it’s definitely one that we > should just get around to fixing. :/ Hm, maybe I've did the successful run on a different system last time ... I even slightly remember now having seen this before in the past on my current system, so yes, likely not something new. >> +++ 297.out.bad >> @@ -1,2 +1,21 @@ >> === pylint === >> +************* Module image-fleecing >> +tests/image-fleecing:34:24: C0326: Exactly one space required after comma >> +patterns = [('0x5d', '0', '64k'), >> + ^ (bad-whitespace) >> +tests/image-fleecing:35:25: C0326: Exactly one space required after comma >> + ('0xd5', '1M', '64k'), >> + ^ (bad-whitespace) >> +tests/image-fleecing:36:26: C0326: Exactly one space required after comma >> + ('0xdc', '32M', '64k'), >> + ^ (bad-whitespace) >> +tests/image-fleecing:39:25: C0326: Exactly one space required after comma >> +overwrite = [('0xab', '0', '64k'), # Full overwrite >> + ^ (bad-whitespace) >> +tests/image-fleecing:48:32: C0326: Exactly one space required after comma >> +remainder = [('0xd5', '0x108000', '32k'), # Right-end of partial-left [1] >> + ^ (bad-whitespace) >> +tests/image-fleecing:49:27: C0326: Exactly one space required after comma >> + ('0xdc', '32M', '32k'), # Left-end of partial-right [2] >> + ^ (bad-whitespace) > > This could be because your pylint is too old. At least for the python/ > tests we at least require 2.8.0 > (https://lists.nongnu.org/archive/html/qemu-block/2021-10/msg00768.html) and > bad-whitespace was removed in 2.6. Thanks, updating pylint fixed this problem, indeed! But maybe the iotests should check the pylint version before using it? Thomas
On Wed, Nov 17, 2021 at 01:50:12PM +0100, Thomas Huth wrote: > On 17/11/2021 11.59, Hanna Reitz wrote: > > On 17.11.21 11:07, Thomas Huth wrote: > > > > > > Hi! > > > > > > I think it has been working fine for me a couple of weeks ago, > > > but when I now run: > > > > > > make check SPEED=slow > > > > > > I'm getting a couple of failing iotests... not sure whether > > > these are known issues already, so I thought I'd summarize them > > > here: > ... > > > --- /home/thuth/devel/qemu/tests/qemu-iotests/206.out > > > +++ 206.out.bad > > > @@ -99,55 +99,19 @@ > > > > > > {"execute": "blockdev-create", "arguments": {"job-id": "job0", > > > "options": {"driver": "qcow2", "encrypt": {"cipher-alg": > > > "twofish-128", "cipher-mode": "ctr", "format": "luks", "hash-alg": > > > "sha1", "iter-time": 10, "ivgen-alg": "plain64", "ivgen-hash-alg": > > > "md5", "key-secret": "keysec0"}, "file": {"driver": "file", > > > "filename": "TEST_DIR/PID-t.qcow2"}, "size": 33554432}}} > > > {"return": {}} > > > +Job failed: Unsupported cipher algorithm twofish-128 with ctr mode > > > {"execute": "job-dismiss", "arguments": {"id": "job0"}} > > > {"return": {}} > > > > > > image: TEST_IMG > > > file format: IMGFMT > > > virtual size: 32 MiB (33554432 bytes) > > > -encrypted: yes > > > cluster_size: 65536 > > > Format specific information: > > > compat: 1.1 > > > compression type: zlib > > > lazy refcounts: false > > > refcount bits: 16 > > > - encrypt: > > > - ivgen alg: plain64 > > > - hash alg: sha1 > > > - cipher alg: twofish-128 > > > - uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX > > > - format: luks > > > - cipher mode: ctr > > > - slots: > > > - [0]: > > > - active: true > > > - iters: XXX > > > - key offset: 4096 > > > - stripes: 4000 > > > - [1]: > > > - active: false > > > - key offset: 69632 > > > - [2]: > > > - active: false > > > - key offset: 135168 > > > - [3]: > > > - active: false > > > - key offset: 200704 > > > - [4]: > > > - active: false > > > - key offset: 266240 > > > - [5]: > > > - active: false > > > - key offset: 331776 > > > - [6]: > > > - active: false > > > - key offset: 397312 > > > - [7]: > > > - active: false > > > - key offset: 462848 > > > - payload offset: 528384 > > > - master key iters: XXX > > > corrupt: false > > > extended l2: false > > > > I doubt this worked a couple of weeks ago, but it’s definitely one that > > we should just get around to fixing. :/ > > Hm, maybe I've did the successful run on a different system last time ... I > even slightly remember now having seen this before in the past on my current > system, so yes, likely not something new. Triggered by me switching QEMU to prefer GNUTLS for crypto by default in 6.1, as it doesn't bother to support obscure crypto algs that no one uses in practice for LUKS. Regards, Daniel
On Wed, Nov 17, 2021 at 7:50 AM Thomas Huth <thuth@redhat.com> wrote: > On 17/11/2021 11.59, Hanna Reitz wrote: > > On 17.11.21 11:07, Thomas Huth wrote: > > >> +++ 297.out.bad > >> @@ -1,2 +1,21 @@ > >> === pylint === > >> +************* Module image-fleecing > >> +tests/image-fleecing:34:24: C0326: Exactly one space required after > comma > >> +patterns = [('0x5d', '0', '64k'), > >> + ^ (bad-whitespace) > >> +tests/image-fleecing:35:25: C0326: Exactly one space required after > comma > >> + ('0xd5', '1M', '64k'), > >> + ^ (bad-whitespace) > >> +tests/image-fleecing:36:26: C0326: Exactly one space required after > comma > >> + ('0xdc', '32M', '64k'), > >> + ^ (bad-whitespace) > >> +tests/image-fleecing:39:25: C0326: Exactly one space required after > comma > >> +overwrite = [('0xab', '0', '64k'), # Full overwrite > >> + ^ (bad-whitespace) > >> +tests/image-fleecing:48:32: C0326: Exactly one space required after > comma > >> +remainder = [('0xd5', '0x108000', '32k'), # Right-end of partial-left > [1] > >> + ^ (bad-whitespace) > >> +tests/image-fleecing:49:27: C0326: Exactly one space required after > comma > >> + ('0xdc', '32M', '32k'), # Left-end of partial-right > [2] > >> + ^ (bad-whitespace) > > > > This could be because your pylint is too old. At least for the python/ > > tests we at least require 2.8.0 > > (https://lists.nongnu.org/archive/html/qemu-block/2021-10/msg00768.html) > and > > bad-whitespace was removed in 2.6. > > Thanks, updating pylint fixed this problem, indeed! > > But maybe the iotests should check the pylint version before using it? > > Ideally, yes ... sorry, it's been a lot of work to try and get the python testing for this stuff in order. FWIW, the GitLab CI jobs for check-python-pipenv and check-python-tox now basically run "iotest 297", and those jobs will use virtual environments to force a supportable version of pylint/mypy/etc. These targets are the ones I put the most effort into, and those are the ones that "just work". It's on my list to, one way or another, drop 297 and use the python testing infra to cover this instead, but I have some ground to cover for usability/convenience before I can pitch it. (At the risk of sounding like I am task offloading, if you send a patch to add version checking to 297, I can review it.) --js
On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <thuth@redhat.com> wrote: > > Hi! > > I think it has been working fine for me a couple of weeks ago, > but when I now run: > > make check SPEED=slow > > I'm getting a couple of failing iotests... not sure whether > these are known issues already, so I thought I'd summarize them > here: > > *** First one is 045 in raw mode: *** > > TEST iotest-raw: 045 [fail] > QEMU -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64" > -nodefaults -display none -accel qtest > QEMU_IMG -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img" > QEMU_IO -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache > writeback --aio threads -f raw > QEMU_NBD -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd" > IMGFMT -- raw > IMGPROTO -- file > PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64 > TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch > SOCK_DIR -- /tmp/tmphlexdrlt > GDB_OPTIONS -- > VALGRIND_QEMU -- > PRINT_QEMU_OUTPUT -- > > --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out > +++ 045.out.bad > @@ -1,5 +1,77 @@ > -........... > +......EE.EE > +====================================================================== > +ERROR: test_add_fd (__main__.TestSCMFd) > +---------------------------------------------------------------------- > +Traceback (most recent call last): > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in > test_add_fd > + self._send_fd_by_SCM() > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in > _send_fd_by_SCM > + ret = self.vm.send_fd_scm(file_path=image0) > + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line 229, > in send_fd_scm > + self._qmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, in > send_fd_scm > + self._aqmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149, > in _wrapper > + return func(proto, *args, **kwargs) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line 644, > in send_fd_scm > + sock = sock._sock # pylint: disable=protected-access > +AttributeError: 'socket' object has no attribute '_sock' > Well, that's not good. Can you tell me some details about what system produced this failure? The python version used to run the test would be good, as well as distro release, kernel version, etc. If you can reproduce it, I might want to give you a test branch of the python code to produce some extra debugging information to help me understand what's gone wrong here. Get in touch on IRC when you have some spare time if you'd like to interactively debug it. --js
On 17/11/2021 19.13, John Snow wrote: > > > On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <thuth@redhat.com > <mailto:thuth@redhat.com>> wrote: > > > Hi! > > I think it has been working fine for me a couple of weeks ago, > but when I now run: > > make check SPEED=slow > > I'm getting a couple of failing iotests... not sure whether > these are known issues already, so I thought I'd summarize them > here: > > *** First one is 045 in raw mode: *** > > TEST iotest-raw: 045 [fail] > QEMU -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64" > -nodefaults -display none -accel qtest > QEMU_IMG -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img" > QEMU_IO -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache > writeback --aio threads -f raw > QEMU_NBD -- > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd" > IMGFMT -- raw > IMGPROTO -- file > PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64 > TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch > SOCK_DIR -- /tmp/tmphlexdrlt > GDB_OPTIONS -- > VALGRIND_QEMU -- > PRINT_QEMU_OUTPUT -- > > --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out > +++ 045.out.bad > @@ -1,5 +1,77 @@ > -........... > +......EE.EE <http://EE.EE> > +====================================================================== > +ERROR: test_add_fd (__main__.TestSCMFd) > +---------------------------------------------------------------------- > +Traceback (most recent call last): > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in > test_add_fd > + self._send_fd_by_SCM() > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in > _send_fd_by_SCM > + ret = self.vm.send_fd_scm(file_path=image0) > + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line > 229, in send_fd_scm > + self._qmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, > in send_fd_scm > + self._aqmp.send_fd_scm(fd) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149, > in _wrapper > + return func(proto, *args, **kwargs) > + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line > 644, in send_fd_scm > + sock = sock._sock # pylint: disable=protected-access > +AttributeError: 'socket' object has no attribute '_sock' > > > Well, that's not good. > > Can you tell me some details about what system produced this failure? > The python version used to run the test would be good, as well as distro > release, kernel version, etc. > > If you can reproduce it, I might want to give you a test branch of the > python code to produce some extra debugging information to help me > understand what's gone wrong here. Get in touch on IRC when you have some > spare time if you'd like to interactively debug it. As you likely saw in Hanna's mail a little bit later, the problem was the old version of pylint. I did still have version 2.2 installed - after upgrading, the problem went away. Thomas
On Wed, Nov 17, 2021 at 2:45 PM Thomas Huth <thuth@redhat.com> wrote: > On 17/11/2021 19.13, John Snow wrote: > > > > > > On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <thuth@redhat.com > > <mailto:thuth@redhat.com>> wrote: > > > > > > Hi! > > > > I think it has been working fine for me a couple of weeks ago, > > but when I now run: > > > > make check SPEED=slow > > > > I'm getting a couple of failing iotests... not sure whether > > these are known issues already, so I thought I'd summarize them > > here: > > > > *** First one is 045 in raw mode: *** > > > > TEST iotest-raw: 045 [fail] > > QEMU -- > > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64" > > -nodefaults -display none -accel qtest > > QEMU_IMG -- > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img" > > QEMU_IO -- > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache > > writeback --aio threads -f raw > > QEMU_NBD -- > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd" > > IMGFMT -- raw > > IMGPROTO -- file > > PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64 > > TEST_DIR -- > /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch > > SOCK_DIR -- /tmp/tmphlexdrlt > > GDB_OPTIONS -- > > VALGRIND_QEMU -- > > PRINT_QEMU_OUTPUT -- > > > > --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out > > +++ 045.out.bad > > @@ -1,5 +1,77 @@ > > -........... > > +......EE.EE <http://EE.EE> > > > +====================================================================== > > +ERROR: test_add_fd (__main__.TestSCMFd) > > > +---------------------------------------------------------------------- > > +Traceback (most recent call last): > > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in > > test_add_fd > > + self._send_fd_by_SCM() > > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in > > _send_fd_by_SCM > > + ret = self.vm.send_fd_scm(file_path=image0) > > + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line > > 229, in send_fd_scm > > + self._qmp.send_fd_scm(fd) > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line > 138, > > in send_fd_scm > > + self._aqmp.send_fd_scm(fd) > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line > 149, > > in _wrapper > > + return func(proto, *args, **kwargs) > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line > > 644, in send_fd_scm > > + sock = sock._sock # pylint: disable=protected-access > > +AttributeError: 'socket' object has no attribute '_sock' > > > > > > Well, that's not good. > > > > Can you tell me some details about what system produced this failure? > > The python version used to run the test would be good, as well as distro > > release, kernel version, etc. > > > > If you can reproduce it, I might want to give you a test branch of the > > python code to produce some extra debugging information to help me > > understand what's gone wrong here. Get in touch on IRC when you have > some > > spare time if you'd like to interactively debug it. > > As you likely saw in Hanna's mail a little bit later, the problem was the > old version of pylint. I did still have version 2.2 installed - after > upgrading, the problem went away. > > upgrading pylint made *this* problem in *045* go away and not just the failure in *297*, are you positive?
On 17/11/2021 20.59, John Snow wrote: > > > On Wed, Nov 17, 2021 at 2:45 PM Thomas Huth <thuth@redhat.com > <mailto:thuth@redhat.com>> wrote: > > On 17/11/2021 19.13, John Snow wrote: > > > > > > On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <thuth@redhat.com > <mailto:thuth@redhat.com> > > <mailto:thuth@redhat.com <mailto:thuth@redhat.com>>> wrote: > > > > > > Hi! > > > > I think it has been working fine for me a couple of weeks ago, > > but when I now run: > > > > make check SPEED=slow > > > > I'm getting a couple of failing iotests... not sure whether > > these are known issues already, so I thought I'd summarize them > > here: > > > > *** First one is 045 in raw mode: *** > > > > TEST iotest-raw: 045 [fail] > > QEMU -- > > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64" > > -nodefaults -display none -accel qtest > > QEMU_IMG -- > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img" > > QEMU_IO -- > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache > > writeback --aio threads -f raw > > QEMU_NBD -- > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd" > > IMGFMT -- raw > > IMGPROTO -- file > > PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64 > > TEST_DIR -- > /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch > > SOCK_DIR -- /tmp/tmphlexdrlt > > GDB_OPTIONS -- > > VALGRIND_QEMU -- > > PRINT_QEMU_OUTPUT -- > > > > --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out > > +++ 045.out.bad > > @@ -1,5 +1,77 @@ > > -........... > > +......EE.EE <http://EE.EE> <http://EE.EE <http://EE.EE>> > > > +====================================================================== > > +ERROR: test_add_fd (__main__.TestSCMFd) > > > +---------------------------------------------------------------------- > > +Traceback (most recent call last): > > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in > > test_add_fd > > + self._send_fd_by_SCM() > > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in > > _send_fd_by_SCM > > + ret = self.vm.send_fd_scm(file_path=image0) > > + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line > > 229, in send_fd_scm > > + self._qmp.send_fd_scm(fd) > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line > 138, > > in send_fd_scm > > + self._aqmp.send_fd_scm(fd) > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", > line 149, > > in _wrapper > > + return func(proto, *args, **kwargs) > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line > > 644, in send_fd_scm > > + sock = sock._sock # pylint: disable=protected-access > > +AttributeError: 'socket' object has no attribute '_sock' > > > > > > Well, that's not good. > > > > Can you tell me some details about what system produced this failure? > > The python version used to run the test would be good, as well as distro > > release, kernel version, etc. > > > > If you can reproduce it, I might want to give you a test branch of the > > python code to produce some extra debugging information to help me > > understand what's gone wrong here. Get in touch on IRC when you have > some > > spare time if you'd like to interactively debug it. > > As you likely saw in Hanna's mail a little bit later, the problem was the > old version of pylint. I did still have version 2.2 installed - after > upgrading, the problem went away. > > > upgrading pylint made *this* problem in *045* go away and not just the > failure in *297*, are you positive? Ah, no, of course not, I just mixed them up :-/ (For the records, as already discussed on IRC: It's Python 2.6.8 from RHEL8 where the problem occurred) Thomas
On Wed, Nov 17, 2021 at 4:33 PM Thomas Huth <thuth@redhat.com> wrote: > On 17/11/2021 20.59, John Snow wrote: > > > > > > On Wed, Nov 17, 2021 at 2:45 PM Thomas Huth <thuth@redhat.com > > <mailto:thuth@redhat.com>> wrote: > > > > On 17/11/2021 19.13, John Snow wrote: > > > > > > > > > On Wed, Nov 17, 2021 at 5:07 AM Thomas Huth <thuth@redhat.com > > <mailto:thuth@redhat.com> > > > <mailto:thuth@redhat.com <mailto:thuth@redhat.com>>> wrote: > > > > > > > > > Hi! > > > > > > I think it has been working fine for me a couple of weeks ago, > > > but when I now run: > > > > > > make check SPEED=slow > > > > > > I'm getting a couple of failing iotests... not sure whether > > > these are known issues already, so I thought I'd summarize > them > > > here: > > > > > > *** First one is 045 in raw mode: *** > > > > > > TEST iotest-raw: 045 [fail] > > > QEMU -- > > > > > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64" > > > -nodefaults -display none -accel qtest > > > QEMU_IMG -- > > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img" > > > QEMU_IO -- > > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" > --cache > > > writeback --aio threads -f raw > > > QEMU_NBD -- > > > "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd" > > > IMGFMT -- raw > > > IMGPROTO -- file > > > PLATFORM -- Linux/x86_64 thuth > 4.18.0-305.19.1.el8_4.x86_64 > > > TEST_DIR -- > > /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch > > > SOCK_DIR -- /tmp/tmphlexdrlt > > > GDB_OPTIONS -- > > > VALGRIND_QEMU -- > > > PRINT_QEMU_OUTPUT -- > > > > > > --- /home/thuth/devel/qemu/tests/qemu-iotests/045.out > > > +++ 045.out.bad > > > @@ -1,5 +1,77 @@ > > > -........... > > > +......EE.EE <http://EE.EE> <http://EE.EE <http://EE.EE>> > > > > > > +====================================================================== > > > +ERROR: test_add_fd (__main__.TestSCMFd) > > > > > > +---------------------------------------------------------------------- > > > +Traceback (most recent call last): > > > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line > 148, in > > > test_add_fd > > > + self._send_fd_by_SCM() > > > + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line > 144, in > > > _send_fd_by_SCM > > > + ret = self.vm.send_fd_scm(file_path=image0) > > > + File > "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line > > > 229, in send_fd_scm > > > + self._qmp.send_fd_scm(fd) > > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", > line > > 138, > > > in send_fd_scm > > > + self._aqmp.send_fd_scm(fd) > > > + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", > > line 149, > > > in _wrapper > > > + return func(proto, *args, **kwargs) > > > + File > "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line > > > 644, in send_fd_scm > > > + sock = sock._sock # pylint: disable=protected-access > > > +AttributeError: 'socket' object has no attribute '_sock' > > > > > > > > > Well, that's not good. > > > > > > Can you tell me some details about what system produced this > failure? > > > The python version used to run the test would be good, as well as > distro > > > release, kernel version, etc. > > > > > > If you can reproduce it, I might want to give you a test branch > of the > > > python code to produce some extra debugging information to help me > > > understand what's gone wrong here. Get in touch on IRC when you > have > > some > > > spare time if you'd like to interactively debug it. > > > > As you likely saw in Hanna's mail a little bit later, the problem > was the > > old version of pylint. I did still have version 2.2 installed - after > > upgrading, the problem went away. > > > > > > upgrading pylint made *this* problem in *045* go away and not just the > > failure in *297*, are you positive? > > Ah, no, of course not, I just mixed them up :-/ > > I was able to repro, I have a fix on the way but I am doing additional testing. I still have a fix prepared for some device-crash-test behaviors, but I found ... another bug that's even more annoying, so there is more development and testing to do there. (New problem is: device-crash-test does not set a timeout for QMP connections, so if the binary dies entirely before it dials out to connect to the QMP library in python at all, we will just hang waiting forever. I don't think this is specific to the Async QMP library, either -- it's a problem in machine.py. The iotests users all set a timeout, FWIW, but this is still less than ideal ...)
--- /home/thuth/devel/qemu/tests/qemu-iotests/045.out +++ 045.out.bad @@ -1,5 +1,77 @@ -........... +......EE.EE +====================================================================== +ERROR: test_add_fd (__main__.TestSCMFd) +---------------------------------------------------------------------- +Traceback (most recent call last): + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in test_add_fd + self._send_fd_by_SCM() + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in _send_fd_by_SCM + ret = self.vm.send_fd_scm(file_path=image0) + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line 229, in send_fd_scm + self._qmp.send_fd_scm(fd) + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, in send_fd_scm + self._aqmp.send_fd_scm(fd) + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149, in _wrapper + return func(proto, *args, **kwargs) + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line 644, in send_fd_scm + sock = sock._sock # pylint: disable=protected-access +AttributeError: 'socket' object has no attribute '_sock' + +====================================================================== +ERROR: test_closefd (__main__.TestSCMFd) +---------------------------------------------------------------------- +Traceback (most recent call last): + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 165, in test_closefd + self._send_fd_by_SCM() + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in _send_fd_by_SCM + ret = self.vm.send_fd_scm(file_path=image0) + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line 229, in send_fd_scm + self._qmp.send_fd_scm(fd) + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, in send_fd_scm + self._aqmp.send_fd_scm(fd) + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149, in _wrapper + return func(proto, *args, **kwargs) + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line 644, in send_fd_scm + sock = sock._sock # pylint: disable=protected-access +AttributeError: 'socket' object has no attribute '_sock' + +====================================================================== +ERROR: test_getfd (__main__.TestSCMFd) +---------------------------------------------------------------------- +Traceback (most recent call last): + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 153, in test_getfd + self._send_fd_by_SCM() + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in _send_fd_by_SCM + ret = self.vm.send_fd_scm(file_path=image0) + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line 229, in send_fd_scm + self._qmp.send_fd_scm(fd) + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, in send_fd_scm + self._aqmp.send_fd_scm(fd) + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149, in _wrapper + return func(proto, *args, **kwargs) + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line 644, in send_fd_scm + sock = sock._sock # pylint: disable=protected-access +AttributeError: 'socket' object has no attribute '_sock' + +====================================================================== +ERROR: test_getfd_invalid_fdname (__main__.TestSCMFd) +---------------------------------------------------------------------- +Traceback (most recent call last): + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 158, in test_getfd_invalid_fdname + self._send_fd_by_SCM() + File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in _send_fd_by_SCM + ret = self.vm.send_fd_scm(file_path=image0) + File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line 229, in send_fd_scm + self._qmp.send_fd_scm(fd) + File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138, in send_fd_scm + self._aqmp.send_fd_scm(fd) + File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line 149, in _wrapper + return func(proto, *args, **kwargs) + File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line 644, in send_fd_scm + sock = sock._sock # pylint: disable=protected-access +AttributeError: 'socket' object has no attribute '_sock' + ---------------------------------------------------------------------- Ran 11 tests -OK +FAILED (errors=4) *** Second failure is in 206 in qcow2 mode: *** TEST iotest-qcow2: 206 [fail] QEMU -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64" -nodefaults -display none -accel qtest QEMU_IMG -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img" QEMU_IO -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache writeback --aio threads -f qcow2 QEMU_NBD -- "/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd" IMGFMT -- qcow2 IMGPROTO -- file PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64 TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch SOCK_DIR -- /tmp/tmpqg73ug_s GDB_OPTIONS -- VALGRIND_QEMU -- PRINT_QEMU_OUTPUT -- --- /home/thuth/devel/qemu/tests/qemu-iotests/206.out +++ 206.out.bad @@ -99,55 +99,19 @@ {"execute": "blockdev-create", "arguments": {"job-id": "job0", "options": {"driver": "qcow2", "encrypt": {"cipher-alg": "twofish-128", "cipher-mode": "ctr", "format": "luks", "hash-alg": "sha1", "iter-time": 10, "ivgen-alg": "plain64", "ivgen-hash-alg": "md5", "key-secret": "keysec0"}, "file": {"driver": "file", "filename": "TEST_DIR/PID-t.qcow2"}, "size": 33554432}}} {"return": {}} +Job failed: Unsupported cipher algorithm twofish-128 with ctr mode {"execute": "job-dismiss", "arguments": {"id": "job0"}} {"return": {}} image: TEST_IMG file format: IMGFMT virtual size: 32 MiB (33554432 bytes) -encrypted: yes cluster_size: 65536 Format specific information: compat: 1.1 compression type: zlib lazy refcounts: false refcount bits: 16 - encrypt: - ivgen alg: plain64 - hash alg: sha1 - cipher alg: twofish-128 - uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX - format: luks - cipher mode: ctr - slots: - [0]: - active: true - iters: XXX - key offset: 4096 - stripes: 4000 - [1]: - active: false - key offset: 69632 - [2]: - active: false - key offset: 135168 - [3]: - active: false - key offset: 200704 - [4]: - active: false - key offset: 266240 - [5]: - active: false - key offset: 331776 - [6]: - active: false - key offset: 397312 - [7]: - active: false - key offset: 462848 - payload offset: 528384 - master key iters: XXX corrupt: false extended l2: false *** Third one is in 297, both raw and qcow2 mode: *** --- /home/thuth/devel/qemu/tests/qemu-iotests/297.out +++ 297.out.bad @@ -1,2 +1,21 @@ === pylint === +************* Module image-fleecing +tests/image-fleecing:34:24: C0326: Exactly one space required after comma +patterns = [('0x5d', '0', '64k'), + ^ (bad-whitespace) +tests/image-fleecing:35:25: C0326: Exactly one space required after comma + ('0xd5', '1M', '64k'), + ^ (bad-whitespace) +tests/image-fleecing:36:26: C0326: Exactly one space required after comma + ('0xdc', '32M', '64k'), + ^ (bad-whitespace) +tests/image-fleecing:39:25: C0326: Exactly one space required after comma +overwrite = [('0xab', '0', '64k'), # Full overwrite + ^ (bad-whitespace) +tests/image-fleecing:48:32: C0326: Exactly one space required after comma +remainder = [('0xd5', '0x108000', '32k'), # Right-end of partial-left [1] + ^ (bad-whitespace) +tests/image-fleecing:49:27: C0326: Exactly one space required after comma + ('0xdc', '32M', '32k'), # Left-end of partial-right [2] + ^ (bad-whitespace)