From patchwork Tue Sep 6 21:26:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 9317921 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 73176601C0 for ; Tue, 6 Sep 2016 21:29:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82FC028ECE for ; Tue, 6 Sep 2016 21:29:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7757828EF5; Tue, 6 Sep 2016 21:29:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1D59328ECE for ; Tue, 6 Sep 2016 21:29:32 +0000 (UTC) Received: from localhost ([::1]:36021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhNvu-0003ID-RA for patchwork-qemu-devel@patchwork.kernel.org; Tue, 06 Sep 2016 17:29:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhNtB-0001QC-6G for qemu-devel@nongnu.org; Tue, 06 Sep 2016 17:26:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhNt9-0004R0-6y for qemu-devel@nongnu.org; Tue, 06 Sep 2016 17:26:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhNt8-0004Qp-V5; Tue, 06 Sep 2016 17:26:39 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 49EF381227; Tue, 6 Sep 2016 21:26:38 +0000 (UTC) Received: from [10.36.116.48] (ovpn-116-48.ams2.redhat.com [10.36.116.48]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u86LQYer004478 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 6 Sep 2016 17:26:36 -0400 To: Paolo Bonzini , Peter Maydell , David Gibson References: <1473133253-17598-1-git-send-email-david@gibson.dropbear.id.au> <3ea1b88e-d2e0-3fca-8ea3-74433c741365@redhat.com> <5e9f1ff0-5c2b-74b4-2e7c-be9e8daf8a7f@redhat.com> From: Thomas Huth Message-ID: Date: Tue, 6 Sep 2016 23:26:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <5e9f1ff0-5c2b-74b4-2e7c-be9e8daf8a7f@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 06 Sep 2016 21:26:38 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PULL 00/66] ppc-for-2.8 queue 20160906 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Developers , peter.maydell@linearo.org, "qemu-ppc@nongnu.org" , Alexander Graf , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 06.09.2016 22:55, Thomas Huth wrote: > On 06.09.2016 22:23, Paolo Bonzini wrote: >> >> >> On 06/09/2016 21:35, Thomas Huth wrote: >>> D'oh! I'll have a look... >>> >>>>> I also see warnings on non-KVM hosts during 'make check' which seem >>>>> to be produced by this new test: >>>>> >>>>> TEST: tests/boot-serial-test... (pid=2836) >>>>> /i386/boot-serial/isapc: >>>>> warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit >>>>> 1] >>> That happens because the test is running QEMU with the isapc machine. I >>> also get that warning message if I simply run the following on the >>> command line: >>> >>> $ qemu-system-x86_64 -M isapc >>> warning: TCG doesn't support requested feature: CPUID.01H:EDX.vme [bit 1] >>> >>> So the warning is likely there since quite a while already, just nobody >>> is running with -M isapc nowadays anymore, so nobody noticed this ... >>> Does anybody have got a clue how to fix that warning? >> >> Implement vme... :) > > Hmmm, I was rather looking for an easier solution. I think I also found > one: By using "-cpu qemu32", the warning does not occur anymore... David, since you likely got to respin this pull request anyway, could you please squash the following patch into my "tests: Check serial output of firmware boot of some machines" patch? This silences the warning about the unsupported vme TCG feature: Thanks, Thomas diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c index b36c6bf..d98c564 100644 --- a/tests/boot-serial-test.c +++ b/tests/boot-serial-test.c @@ -29,10 +29,10 @@ static testdef_t tests[] = { { "ppc64", "ppce500", "", "U-Boot" }, { "ppc64", "prep", "", "Open Hack'Ware BIOS" }, { "ppc64", "pseries", "", "Open Firmware" }, - { "i386", "isapc", "-device sga", "SGABIOS" }, + { "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" }, { "i386", "pc", "-device sga", "SGABIOS" }, { "i386", "q35", "-device sga", "SGABIOS" }, - { "x86_64", "isapc", "-device sga", "SGABIOS" }, + { "x86_64", "isapc", "-cpu qemu32 -device sga", "SGABIOS" }, { "x86_64", "q35", "-device sga", "SGABIOS" }, { "s390x", "s390-ccw-virtio", "-nodefaults -device sclpconsole,chardev=serial0", "virtio device" },