From patchwork Tue Jul 11 12:07:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 9834575 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C525D60363 for ; Tue, 11 Jul 2017 12:12:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B075F223A6 for ; Tue, 11 Jul 2017 12:12:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A37662844E; Tue, 11 Jul 2017 12:12:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3603C223A6 for ; Tue, 11 Jul 2017 12:12:30 +0000 (UTC) Received: from localhost ([::1]:46025 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUu1l-0004mE-Bv for patchwork-qemu-devel@patchwork.kernel.org; Tue, 11 Jul 2017 08:12:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUu0H-0004h8-2F for qemu-devel@nongnu.org; Tue, 11 Jul 2017 08:11:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUu0C-0006Dg-QE for qemu-devel@nongnu.org; Tue, 11 Jul 2017 08:10:56 -0400 Received: from mail-bl2nam02on0087.outbound.protection.outlook.com ([104.47.38.87]:25952 helo=NAM02-BL2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dUu0C-0006AK-Fw for qemu-devel@nongnu.org; Tue, 11 Jul 2017 08:10:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=RuwaTsQbeiQXMGlqMSTdXlqFpi8uuOKI2tV3kvb32SQ=; b=H9YxzwU5nNFyk5+9jsMZS9jx77+60oBfdVTh66MdM5hdZqnAuymXtBh4k9ma2bBBPiQcmJVycayfO3eBJk7vuZ+vOS+d2qmTqm312+adaWqkC4znuBvP6QHijcexOEpo6EHR7Pg9LXxG4zvFr72VI8S8OHCDboh5+6PJKgK0sn8= Received: from BY2PR02CA0096.namprd02.prod.outlook.com (10.163.44.150) by BN6PR02MB2724.namprd02.prod.outlook.com (10.175.95.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1240.13; Tue, 11 Jul 2017 12:10:47 +0000 Received: from SN1NAM02FT006.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::209) by BY2PR02CA0096.outlook.office365.com (2a01:111:e400:5261::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1240.13 via Frontend Transport; Tue, 11 Jul 2017 12:10:46 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by SN1NAM02FT006.mail.protection.outlook.com (10.152.72.68) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1220.9 via Frontend Transport; Tue, 11 Jul 2017 12:10:44 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:59218 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1dUu04-0006ob-9a; Tue, 11 Jul 2017 05:10:44 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1dUu04-0001sg-6S; Tue, 11 Jul 2017 05:10:44 -0700 Received: from xsj-pvapsmtp01 (smtp3.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id v6BCAXlE031778; Tue, 11 Jul 2017 05:10:33 -0700 Received: from [172.19.2.220] (helo=localhost.localdomain) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1dUtzt-0001pw-Fm; Tue, 11 Jul 2017 05:10:33 -0700 From: Alistair Francis To: Date: Tue, 11 Jul 2017 05:07:23 -0700 Message-ID: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23188.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39860400002)(39850400002)(39840400002)(39450400003)(39400400002)(2980300002)(438002)(199003)(189002)(9170700003)(356003)(50226002)(76176999)(8936002)(4326008)(5003940100001)(36386004)(50986999)(478600001)(5660300001)(7406005)(7416002)(54906002)(39060400002)(9786002)(77096006)(8676002)(53946003)(305945005)(38730400002)(626005)(81166006)(110136004)(33646002)(2906002)(106466001)(575784001)(63266004)(47776003)(6916009)(50466002)(189998001)(36756003)(2950100002)(118296001)(48376002)(2351001)(6666003)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR02MB2724; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; MLV:ovrnspm; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT006; 1:j4sl0CZk6AIV8zKUMk0GUUEu1LaeBYiFmpbWtH/49WyCLWTHqCxLzLszZnr+MVwqkMcN6MTKMU2Wic5VX+rHM8Bhhj3VA66cHgT0fBudIGT+sykr2fkbWFBUdqkZt3wY94vwH2zqqJhIYNfbu+sulAanmKXlL867KN8c0Xclvf11JQYr17HP82HGl4R37cn0WxjIYC6+LEvd+2485V/cZFb0U0dsowzpsdiFWSr8CEH9Jm0P3qvhW2Wf7mku2mnZqyVrV0hT9+PYxeDb5/MCe/6mI8N4orCnCL9CMnY9GHNSXk/7FwmjNfHoVXRE57OLh02KcySENS1avO8OvbqWoFSFfGl2KtHshr0/80FUTcEYKuPCIxnNzfGPkmER30nh3yHv4Acz/OOsJwyzwNXAIYmxBEPYvKT18+q+6rvc1oio41Vfe19ZVhaPxEAT3yjeXbP7ijF9f9HPcQZFoqUvAGj77JArI0aFJB+LFNyBOzx7TeU3xLIYE0rXK76+FESEhk0/QXz5LKfq9+8zfSDqM93iqq2lfUG0g6GESru8B/oT+xJghM7G4b1Wti/dm6cyieYDzrTKeZJIA9nC8ycNNgA6C2MB2lHkxJ/Q/lRGpwlzG0z0l45Y64EJQTnbq1mlH+18dBpxBpUUzAjLBZpXDDaj7465kTSZOqIAx+It7Z+8x/p4Tn2uhORM8dvhAgmx2oUhkX9QNMqiLv0BmmS4+YciZ5gRYmA0TkbvRs20bXN+vExqzQKblUoof/lWJ83TGQPMreDfYzreKeV+uraIU8A7DMwyThAWL/jq387cvbIOZ5haGVkOx0Y7PUwMC8d5cxFyJOnyz0qE3kwertB2999UJm2Uwz0rgONZpPlX7D2ZTZxeara1/JKqkA9VmjFBu/X6pImN7+LYZvIDQ+zylA== MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e1cb04e-9b9f-4897-e382-08d4c855dc66 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(8251501002)(2017030254075)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BN6PR02MB2724; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR02MB2724; 3:nP5tzjw7E6xPYqSUG7lZXZOXSZ19q7IQWTkg2aJnkN?= =?us-ascii?Q?9GH9t/cdMrgG/AChfo24qaSnaGfq3AnOCCYfFA5ybhSnhnpq3R5M7OenNNak?= =?us-ascii?Q?kPQ6yfAYsvZBhhiiMsZ2fapMz1RbGQJNAZca7Vbo+nL5taX5X5IEBzlZ52Ue?= =?us-ascii?Q?bHPHiiccX4VF6cLvYcjhwC1JoHSwPGYA0KKDNTRmvn3/Bz+W2ul6ubWzv52b?= =?us-ascii?Q?1zsw2OrKZlprIoDqiNfOrsxPH2nPCua3eGuxzpYYqQWP0MzAsCNIAQeJhXjB?= =?us-ascii?Q?gUBTzng57RNjp410+2JcQqgPD2oVJedinNL0/O4Qf2qxQZiJQS2nFdCxBb1b?= =?us-ascii?Q?pCJFctMXKwwvYyxg4qbvRv0FNDFj+UMfl22sNoBaYtsY0dY79LKScApMKiHf?= =?us-ascii?Q?CV55JhSviEOKK//+odbw6oTFYOCqPeY6/+rt9XuNwWI8l4mJWSfdkoOe1VCB?= =?us-ascii?Q?4ERvaCfEGpc5sgGeRajOD5LTuVPfif7ousIotG07d+oK8kjUXptVReJrQxGT?= =?us-ascii?Q?exWyjWid+eEgK+Yb4z2ZKXXPX7troLyhvUWdM8VLn/0kefPzoVkoeq9E61C4?= =?us-ascii?Q?99rO81vHfgU4/Z0+Pdv+Pj9Dvem6Zj60ep91twQBKfARzWCB5b/NVKqVvu7R?= =?us-ascii?Q?zzJ6dPa8D3NK/YZ5Qdh8bqgJCDPCjRYacl+aM++3YZfeiUdwNrL+fN+8Q0QY?= =?us-ascii?Q?anAbB/aDsZkNVvnoa2FliIjR/W7Es0P56jUAH8qKG8MFkXOy3KSPHoKj0oyz?= =?us-ascii?Q?HNhqGRUW/WmJyOBwztYSIquMUhWmc1aa4WnRBsiYZzZ+4a7Zkyw4Oe5vWsRd?= =?us-ascii?Q?FIT/ulbI7fWKmoKp/KbtPD6cpGzbPhwR/B62+uorYWk9m3mmawdBUZ7OPS1d?= =?us-ascii?Q?PassxcFIg2zcKuk6GhzXe/wCSEUqruy0VgJ5wUmdwYOJYJG7B2S1Dm5rSWP7?= =?us-ascii?Q?TBHIlakHeh9LohpHQ6lxlUU6xsTxDcUrgG0MiBgQ=3D=3D?= X-MS-TrafficTypeDiagnostic: BN6PR02MB2724: X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2724; 25:nx9KQKg+Z/D/I8aK+Y22HUVTf0mpMPsCREL/M6YUqAWq5/9QaR/4gnMeod3h2rRotf6H0HwEGDnJHLtVyQA9/lyJrorjM/86rk2MveGN/GMctiGt4soYP8PPX3kz+HfA/iirm+VVkPo7o2DMhaqHVKTUA3KX64PVR83IresCvq4yrh07ckhCRWL0sY75Bon0pC3Cd+FFy7NRCkCq4R+PTVf27vE9uFLkWq/4KPAV9bqKQSIhIf7CO+D5RMR09oCw2T/htKSyFtvDjFGrLwJPcbsK6PTkMlzDlnbW50zCpNmWsZzlJ+WtuvhJy7jS804ijw0/mslZQMPpq/fV8n9BBrJVIfXWQlROspeyDVgmvl6gWRO6vC6uhpGmsdYaPSw7YL0TCZ9fB7DC56aYboCkjpPE4QJg/IeHWM82XeyWI9pyEmrAdqcm/swCqLZ2faMRnHXbb7LIehNY1BKxB5IgYMvOgRSHtwoQXdhFTyuoB0jvwjQy0TVihhYFyRBpvPkmRrC7ahX33puCJ6ejZjgh9AI/Zja8fMMJWNGH4ZIKt6GOgtbK4I4xafixQAXKNjbgv3aXW6lOUE8MRRHJvxXXVj5gf3hUlG/b8V+AN5M0Li3xgR63dTX7bFa3YB2jKOk4Jz3fv95K/HP/RyogKUxUO2m/Q9aNLDujk71XG4mjOtHzNj4wy6yzq7DvNZswdPCgzest0Gym4XZtJqXO/k+ezqjiDtlh/Y0XD/Pbn2CnBE7U27/aQaEoNz8u0fvd+4R2ShS9a29Mh373+A73xO0vnyqnVcCHQ4C3DGW7pDKvWMXRkJ9g5qnEa8evI3aaAUNlF98LFPiJ6yVJf7U/U0HR2LXACAUJ5IJz6N39reEKGFWoFaWe2plM9HoCoxLWVaahMpT8IGmIVlPFGQ/7Nx+wh5brh0l1R9ateVR8DkFZScE= X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2724; 31:V3JdKHdq348VFKP12lM0tgJHowu4Gn47e5PXbaUOv/PL4EMjtWbFd8vIkqIry/zXsr9/eMrrj2YE+MuzdCdZuHVRiieciFWwSgYInPIX4BuGbC29gkWu6+n3eFA/vg/OjyrHedbzCi21g8uqv0Fzx8tFkO0X5dagA/a6CtrKDweD9WlWUngJzhjTwbPaVhW4oqmfMvlzLwQ918szz6+rfAdOQ1VqBPAFz92TYXCVdmGBpvUaetkq8j15D8HQE0+YsgMbww8WuDKi4r35hlkTZlpcVp320+ntoFpVNcVqQDrImjKX2iW058fhk/C2EMbdGrzbVreK7Pq3dLhcg5v/HDkZAvpRKkUAOepFgb9jsTKAaJeiu7xcPSFdDgtQ7nqcDiTWBUi8U/Ani5b2QkbGaCo9g/ZZobTCN7TMfniGOWNAb2wrEG70i0xf5CLB65M3Ri8FPIBd+4CusTsg6QnpHAnxsuYpTLTNphRMcDaSfqICuQHEzamVxwTAXkeu2fqYLx64k6kVCveEqL3i2kUyi5JnASSwx9uY9j+sn1w5EkadF7Ft+VqEhywOBZLQ0SEYeIjg4H6gvrESbjZiFi0MJQVPglXtY78sy3UF6ePRxsPvC8sR6yMAHU5w/RJUl1x/r1kezRGEIH6f+ks7WKuTpS6CCeG5T3M0T1EfSPuCHBxquCJoOajwhj5Ng5fVgIH4vDWprK3AuWWh9q6jty/Oug== X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2724; 20:dxLfpHZXSo4f0dryoxPz+zAN6zX1OKKxg4EiDCW6zvuIxHY99o3MfbzOPDK4u33Dvp1A2o0alaHVdPrw1P3bG40BF9MfyoPrzDE9sbeyKYAs0k5tMYEMGrvzAkm+bs9QRxCzVbtXmNQL2jcFxicq7IyCFJlrckl9IyFVU0Kj9IQmXkuJXJxGhF0Gvgu/spAEHf8rd/1hadbYBxVcJqJfMCcqJFWlg3RLDFloSlAWS0zIy0jtp0xHO74fnGcKe6X26Llw7E3agYzyLutidyiT97FvjIUrnNtru5Q0Z2Xcqb1laodpJjdJ3I8+2SJUExlUiGIFurBeLOZcWDC5k6IwT4JHdbupkmcFzPbVcZkQH97zgMt0s8EWXSh/ERHihno+5X8XxDvQ87NGKF08XUh55HVdnrxNUEjNvH8H6i2lAmKTCxRcCKh5b0czZVify/EqA8tGOxtHtvTeFPGy2KSaBrdUfcC+lDG9DcMYEfnNbUggCkNf9102F2dNRWa4tqdO X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(125551606395959)(158342451672863)(133145235818549)(236129657087228)(190383065149520)(48057245064654)(192813158149592)(46150409022019)(104084551191319)(167848164394848); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(13016025)(8121501046)(2017060910075)(13018025)(100000703101)(100105400095)(93006095)(93004095)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123562025)(20161123558100)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BN6PR02MB2724; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BN6PR02MB2724; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR02MB2724; 4:4n6f2bKDU6xtQsDCiQjX6XHsB1PmqE7xyS81YVwOOV?= =?us-ascii?Q?x44iWo/EiZr/qlv1SIQg+3DGDfhK1409t+wdcnDMfNjD+2Zp6asuEl+dwisY?= =?us-ascii?Q?9fbhx/ZVW+XlOTt7c6RnyMNMUNNfq43xC0y9IFBzFq8NC0gTJXRLYhU/7dNC?= =?us-ascii?Q?gAlkgZfAhXOswoONa5vbXI/1al4NkPVuREHWfDofXlkbrf1IODzsVH5xCwzD?= =?us-ascii?Q?NeoK4fIpOw7wjVsUgHkLkmiHpa1ZZ+0L8ou3xN56CVEckbZsXaGffcrAHcAY?= =?us-ascii?Q?XfFDAzhVFYAVRT7/4AwMSo9e8Ht7qrpR5rF2nKcV8SuoYIJbNZRaneLIRs5t?= =?us-ascii?Q?QUt3Jl1aV5OOEPVvQ4Rd/S+vM5+gci5lh6Q2VCxEyXneTEniWZqI51Ca3Hy/?= =?us-ascii?Q?873F8iv5kjH0fVkl33LUK0CGMDgXtIFSw5Ep5KIlpyMZtbQLJ+erqBESFvfC?= =?us-ascii?Q?JIlNBJMf/qx+jyj/UcuWwtoK6zdd1XMfLzuQNJuEpMXyQgHG11Y1NJcT+kHv?= =?us-ascii?Q?IkWKgZfe+008trtrc4PV9vwCi78pcsaukWHDvzWITVt9AbPsSiFmqnvbOFKy?= =?us-ascii?Q?CJV31ULKqkrCCwROCUpys99IxIX3Bf5LMSrbpYluUEIOYfZdmFHAcL05jbSJ?= =?us-ascii?Q?hvUK2Qlg76awtJbvBCCbuio1Epk3G3UzhO57I+oTYmTNVrC2QAMgQBLKiEg2?= =?us-ascii?Q?bHEPILnOtVQHhxMBLm+tRxfFT7ZswOkwg58VZxgA8Wj1Yone3+d7FyOQGE5Y?= =?us-ascii?Q?86GXTmWRSjiDvMxeLgmV4kruYz8uy2taCmqS8XUQ+vdCedyDqocGM096fzJq?= =?us-ascii?Q?M9ZU49e6Ut/FlF2ksmMH4tfL+UkEifKvQZZBweBQ4LwXoUAlVUpXCIjc11mp?= =?us-ascii?Q?z6ZqbwXfph9AwhqE8I1Hi+68PS8ifKTd1lOpiUUrpUXT27CbYck+rgoaeDGp?= =?us-ascii?Q?9IHUzqfrQI7ooMkv0psj6qCuZq6J8toUXdB8uobqk6J+WNm0W0TMfcKlMHQv?= =?us-ascii?Q?ZRJaf/BvSR6IKJpVwL7cuz0gpZH+oCZw9/RWyRmSC50Fjf050jXguWqsOgN2?= =?us-ascii?Q?O9B2irBFO7pe9b48jrf3TR2dc1X8X+K0hjazENw5u24/XTG1pNjcSRb8ytoo?= =?us-ascii?Q?SZm0J6futec3hwfxSRuGWJfyxA7cnzOphfygAn7wTWPnPiG7mi4wfo0icoQX?= =?us-ascii?Q?R2S1jQD9z4xyXKujLztyuPn64fNWjtUUGTFo417MRrIgx3nx2ZuxnGj8ywRC?= =?us-ascii?Q?KaA07kdHmdX4yT4fkJoExyVP8X6bDhvXXxs9DdFBjHE97VofHO89ZV1QYa6H?= =?us-ascii?Q?vMOGtNjBOCCGZGWfVbLHTpEKuEqwbuWsbji0KGuSgoXGCe0wpfiy9JeN1Kgs?= =?us-ascii?Q?CmiBgBxYTpAS4DjzOCz/vCSwOUW4HlTit5G4z8miZK/HW1sBVtJ+3axWCeIF?= =?us-ascii?Q?izzN1BX05cSWWlVFrcnzAQGMUnV0ZP3oLNsdjgVSw1r64ST0jF1OSqMxZHHA?= =?us-ascii?Q?OpFI/iAeyW4Z1qYa8Pd+i/XbxmG7Ww20vRAchbkClRHmXDwKYeyaErVZKoqO?= =?us-ascii?Q?r8kYK+MhJxGZ8anWQROyfFtQLLTOhMzng5FjZOO4Q5V6fL1dRcx55rjgGy?= X-Forefront-PRVS: 0365C0E14B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR02MB2724; 23:DvCz0t40ELUUyprg9ADDGalmg2Zh/1m5t/5FFCXNh?= =?us-ascii?Q?edzWQwH7kAq8gjB76xTu31EtkRhknF5QuRKDcb/L7LamWLy4zV7xrkKiSe7b?= =?us-ascii?Q?0Yie1DXMP/J7TDpHjQictQkBMXdDBVDgEAX4dpRgxnIzMdCfth3fgd3lVC+4?= =?us-ascii?Q?jh2TgMAGzbAa91l/z08i97EFYz6CLBfxmhQxKxCIu5KcgJHi68afUoxsaOy0?= =?us-ascii?Q?HgMObHlcnY0um7DA2TATZMjqYsQErmerZ+ZqE2OF/MUyrNA2ubNyon0kL9bn?= =?us-ascii?Q?O3cL0RZCSo/SRCVi915myt6pKI1sr/TLwmGFoaIhr/xNr9XlodzQJP/C1pR/?= =?us-ascii?Q?exxzNpk1HnVCt63qwgLrsP0lFWq7JGp/cGaTgAFYffzAkEUkj/9ppOW3Qy7K?= =?us-ascii?Q?txdT2V3Sb7qciFxkV8z8k+eXya1xeesJqweBXWr5uZvSrAThuaLbP4xp5gao?= =?us-ascii?Q?ssHjsaDlaC0It5tIrPQCiYcxeT7WfInIS6y+xIqUiA0/1xXW/NZVPvMMoUR0?= =?us-ascii?Q?S75BDayLw3BaBIUVFxcawWbgp5ZxTDPvg8X8gED/51wX0VFzaUok9OKBdBrf?= =?us-ascii?Q?/af2lfOa7voJB2Wj425LjCV4BujGbKbCJ0u5GpYAmoFSOp7D6JLL/xBmHlD6?= =?us-ascii?Q?UGyqrjTFMUG0E5b66T8MMT9+qsuXJsafP8UW5i5ZoAdle3dGZWs5aQpI9lyw?= =?us-ascii?Q?VNLIMktGu+r/6l/BGsPrgfefnmfRlocEaNovHtocF+/Sl7xEvHyVoRfDi+D+?= =?us-ascii?Q?PCcwQM4i/IzHp5xqQ/BfOLC5gPISgDkVFx+Ybq6YGbM+uT8irYfK7arX/8ca?= =?us-ascii?Q?gqEn6K9XGy33PFUj/3Q5BYgdhTTz98OyHeOxcI4QZHdD9b/zeqeGSJEO1gOh?= =?us-ascii?Q?8lBOkki98xFdxFoLPpVHArD7cNOuqBnmAFiSsrDspMmfKIJBEOHkzgcpTeM6?= =?us-ascii?Q?LYKCveby7OjT+SlaFAPSNDeT8yC9B1EF2w2aXJgy3xY5k4dUHYcAjnQqRW2q?= =?us-ascii?Q?2AY+0MjJ07GsDVOFESlJLeUmKAkXF2Bko453/Z+jpXW2d+pHivoymbOGq22T?= =?us-ascii?Q?eP9SNz5hlv/uXDIzGfZD32HuR+ZXrV4Tgj6Wu6HEaFmQw9Ls5EfmE0yaPFOn?= =?us-ascii?Q?GqPmQNCjEr/B1D+3reMtBykHA2HniCexvj1k4+RS/C/0fwzirJ1EofS7G4ql?= =?us-ascii?Q?usPo8LPC4+gJnBnRbOP9cDOXIJV7YO+h/c7rtestecI+/AZWf1ddmlflkXw5?= =?us-ascii?Q?EMcUOG0Uh666yziUKI=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR02MB2724; 6:4B3RA8uuvwn2WxZgyj46MfDjOTuWv5FdOgqXxd11DF?= =?us-ascii?Q?cB0WfhnRGRAAjdXnIUbIS9cayFk1l+kIoWDftZtkecVa/biOmSTi6eSfbHNF?= =?us-ascii?Q?cFIGClL8bgrBb45dQfB7zSeaW8ElzfNG2XUXb6ALutv48ZnDzPr5qsn3dNzT?= =?us-ascii?Q?Fci51ww2w6hbJgtZIQekrCIQjdIqSTfLOj416zYuLTS9vS22YR28vwsICp/X?= =?us-ascii?Q?z8qQ0ZgmQfHIvH7SCsFmuMcMskgRYL2NCjiSHs64ULjwnlFmBPwtKbV/h+bQ?= =?us-ascii?Q?/HVdZ2CuXQvhYOzfG6gySQsaUCxuICoGUq2/DhdXDbo++BPtCsg6VTN0NprF?= =?us-ascii?Q?/4H0mHE5m2qDS03MHjnWxnsPw6fsRQXOxCye9Kl9iuCKStyGAkohJfZq1skS?= =?us-ascii?Q?y/8FxVKlTmdlWSm8nmfArnrbrjbEZXT8nt0Nbc9CyK93gHyMUUJOkM8x1kV0?= =?us-ascii?Q?g1AqhC0MeCPbdxDgVMH0J91PS1iRe4qnJQNg12JnwVKlD+WiJ7g2yH4eJb/6?= =?us-ascii?Q?6cdnMz3VCrFFYojDN4FejAX+Igxyu9t7sXy4r855s6F4BTrVYFbiRzDrsQxx?= =?us-ascii?Q?/HGnqoBN060ILEaAUbFYhB3wGIWNZnB9gtVKzgsmDVzw7c2D0g3OuG1v+3zs?= =?us-ascii?Q?h5ogPaCte0gTgPO4TZbs5DO/2khDABtXyTkSvhh5rggCwhC6fvuTReZifZ33?= =?us-ascii?Q?TXc3lVJjHCcpz2zEK9BQYvJGIDJwvVFFcd4dH/4q4m8s34d1fdCGqmXyzQ0S?= =?us-ascii?Q?IdL0fxy/crKocCmR1tMmOIA0Ulw81IcrHklhqX+70yok9B8hAwaVY6yLUG0u?= =?us-ascii?Q?WHt4vm2dniemkck/y2KNHTPwIt/Y3CsTD5v79TW6VCfFTv0Sdx1plCGWL1yU?= =?us-ascii?Q?WONOO+QPh+gWRgq38+QB6GVg9ULqM6bfKir/epoR4TEVRLnMaBz7fNbh4h8E?= =?us-ascii?Q?stvVZqDrxEa6IG7X4R1vGUPsQgJ+ErIE6Xap80AlnNSackcJiuAchdZqtkVt?= =?us-ascii?Q?goBwF1w4Ik0hjASmFDwIVI?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2724; 5:2ezb6gKjSxr829TE0UiVzZsbhcSiHhl499BHKedNfb5QUw67yYtdqh/iEQSUz7wr67JOe2t2tqfYUMdFkUTVRrg59OLFAx8t1UfPGuZaRRa7mK5jDHun86B8UzeGxU0zNjdqeH3ycGx3abjZUBb26TKFaaWU2Ute7Bro8o4F0SOUaGhXfZAPG8NLkO7Tl1jdhPK/142jc24GT2Em8YRWMVetgBp1/DdDgyoCd/Fn4wGwuat9ADvCd9yL8ZZS6cXLKFsCjqtoXGtGYYq9Uz4hSxngkm0blDJPyMHXcLRtek5PMTni1BT+j9T6EYlhYTSunq8qTy+LOZztvZ/CjT9MHVdDdQIkdyMhbExgAkw4vEO+WC7G8bjxP4KfpIZ8R5p6DMnawEL3/E2UWtGMhBNs9QrPkuqC7XAIdW/RTUtjNIXlUk+FGUaZOO6ITwuZU9ckCmMnLBtK2hTHYAHz/AdbeIV4N//sQtPixS/X5Oem12dHnprge/MsFu92MtuGOc6+; 24:5fdfulJ+Fw+AA124H7Zzc5zugfLFxHHloc3SgayEMG6RqTMRjfzaxUlWnyQ6wZJ3l2Emv9FS5YfQCAHqyAjvu16I/v+z9v9O1pq77LQeiMo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR02MB2724; 7:f3ajavjCqKHMQUoUzs6xWnSfVrx72IMoolr5pu13H/x7imQO+scP4DtIYteXS6mehOrhj6ddKFcjXxHoWjBBoBC4JWDqSpnGQsHM172PG0M1J/xR4yr2Vt/cHRveqpFOKJWlnvUCKaE6ONO73ExBIXxLGwkP6h+jRR7qTnlKIwI+49ObCenTNjJ5ybQCe5KiKINWRyCgbCOMBcV3XywoR72ZwNZFHUBLUu5Fr5sk4ySWBRhWs/T3okSMbRNzKrG5b6t+9FlgN+3teExxYXZ9hcS8epmp4kQm1a6g0PwPmVl5tYjN4hIsu6ZDACVsMzTxTQIDGZ/uFGSArL7FNHaikUXNPSZud+TQBzMDO/hvy6hQcgfedyTbveo+eL0UruMVQXcDVZsElTVtKYcnLNpGWkQPtwo+p5AxAaDKwY5l9XRX9Bpyp7TCc3uLfukfw5oQweMXuQgVI9p0lwf16grI0bvrnTA0bnQBr72UL77eRSzqjb5hX5yQS9gnViUDgag0IvAC/nTZOQ9Kzr4i2EDPccrUDkKfZvK5HEp7Lj9fN63gu6qn+mvazbn2Oy2QbXq0+TQj1mrzIv2OkicmoaV9xYM3ifFEigvup/1NV4v1IeuunowliHls6+DJhHXqKRJguB4JZYGareDlm0m3EwsNyiQF/jtEncTijn1d+8RDw6nxJTMuHw1/Q7LUZBEVWmVTgLFS0dmRI+eB/iCjjs0HIvrdg2VQB3Dqi0+sQ4Ara2pAfHinTqK+O9JDr7EaJoahYxf473t6adusIJSk+4zCFq9EgXjlqHSsWB1BHJNul3I= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2017 12:10:44.7837 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2724 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.38.87 Subject: [Qemu-devel] [PATCH v3 3/8] Convert error_report() to warn_report() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cornelia Huck , Stefan Hajnoczi , "Michael S. Tsirkin" , Jeff Cody , Alexander Graf , Gerd Hoffmann , Eduardo Habkost , Rob Herring , Josh Durgin , armbru@redhat.com, Christian Borntraeger , Marcel Apfelbaum , David Gibson , Jason Wang , philippe@mathieu-daude.net, Peter Lieven , Greg Kurz , alistair.francis@xilinx.com, Peter Chubb , Ronnie Sahlberg , Igor Mammedov , alistair23@gmail.com, Richard Henderson , Kevin Wolf , Peter Crosthwaite , Marcelo Tosatti , "Richard W.M. Jones" , Max Reitz , "Aneesh Kumar K.V" , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Convert all uses of error_report("warning:"... to use warn_report() instead. This helps standardise on a single method of printing warnings to the user. All of the warnings where changed using these two commands: find ./* -type f -exec sed -i \ 's|error_report(".*warning[,:] |warn_report("|Ig' {} + Then the white space changes where manually fixed afterwards. The test-qdev-global-props test case was manually updated to ensure that this patch passes make check (as the test cases are case sensitive). Signed-off-by: Alistair Francis Suggested-by: Thomas Huth Cc: Jeff Cody Cc: Kevin Wolf Cc: Max Reitz Cc: Ronnie Sahlberg Cc: Paolo Bonzini Cc: Peter Lieven Cc: Josh Durgin Cc: "Richard W.M. Jones" Cc: Markus Armbruster Cc: Peter Crosthwaite Cc: Richard Henderson Cc: "Aneesh Kumar K.V" Cc: Greg Kurz Cc: Rob Herring Cc: Peter Maydell Cc: Peter Chubb Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: David Gibson Cc: Alexander Graf Cc: Gerd Hoffmann Cc: Jason Wang Cc: Marcelo Tosatti Cc: Christian Borntraeger Cc: Cornelia Huck Cc: Stefan Hajnoczi Acked-by: David Gibson Acked-by: Greg Kurz Acked-by: Cornelia Huck Reviewed-by: Stefan Hajnoczi Reviewed by: Peter Chubb Acked-by: Max Reitz Acked-by: Marcel Apfelbaum --- V3: - Regenerate patch to ensure no manual edits where made - Tighten regex matches V2: - Fix quotation issues - Update commit message - Include full command Just a note: We will need to do a similar thing for fprintf. There are patches on the list at the moment that conflict with this series (by adding error_report() calls that shsould be warning), so I think I'm giong to have to do a follow up series converting more cases. I'll cover the fprintf cases when I do that. There are some manual cases as well that don't say warning or info, but really should. They will have to be converted as well. block/backup.c | 10 +++++----- block/gluster.c | 4 ++-- block/iscsi.c | 6 +++--- block/nfs.c | 12 ++++++------ block/rbd.c | 6 +++--- block/ssh.c | 4 ++-- blockdev.c | 2 +- cpus.c | 2 +- hw/9pfs/9p.c | 2 +- hw/arm/highbank.c | 6 +++--- hw/arm/imx25_pdk.c | 6 +++--- hw/arm/kzm.c | 6 +++--- hw/core/machine.c | 10 +++++----- hw/core/qdev-properties.c | 8 ++++---- hw/i386/acpi-build.c | 10 +++++----- hw/i386/kvm/pci-assign.c | 6 +++--- hw/i386/pc.c | 10 +++++----- hw/i386/pc_piix.c | 8 ++++---- hw/i386/pc_q35.c | 6 +++--- hw/misc/aspeed_sdmc.c | 8 ++++---- hw/nvram/fw_cfg.c | 2 +- hw/pci-host/piix.c | 2 +- hw/ppc/pnv.c | 6 +++--- hw/ppc/spapr.c | 4 ++-- hw/ppc/spapr_iommu.c | 2 +- hw/scsi/scsi-bus.c | 6 +++--- hw/usb/dev-smartcard-reader.c | 4 ++-- hw/usb/redirect.c | 2 +- net/tap-linux.c | 2 +- target/i386/cpu.c | 8 ++++---- target/i386/kvm.c | 4 ++-- target/s390x/cpu_models.c | 2 +- target/s390x/kvm.c | 2 +- tests/test-qdev-global-props.c | 6 +++--- trace/control.c | 4 ++-- vl.c | 20 ++++++++++---------- 36 files changed, 104 insertions(+), 104 deletions(-) diff --git a/block/backup.c b/block/backup.c index b69184eac5..44cc2b22ab 100644 --- a/block/backup.c +++ b/block/backup.c @@ -639,11 +639,11 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs, ret = bdrv_get_info(target, &bdi); if (ret == -ENOTSUP && !target->backing) { /* Cluster size is not defined */ - error_report("WARNING: The target block device doesn't provide " - "information about the block size and it doesn't have a " - "backing file. The default block size of %u bytes is " - "used. If the actual block size of the target exceeds " - "this default, the backup may be unusable", + warn_report("The target block device doesn't provide " + "information about the block size and it doesn't have a " + "backing file. The default block size of %u bytes is " + "used. If the actual block size of the target exceeds " + "this default, the backup may be unusable", BACKUP_CLUSTER_SIZE_DEFAULT); job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT; } else if (ret < 0 && !target->backing) { diff --git a/block/gluster.c b/block/gluster.c index addceed6eb..ba88fe116e 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -345,8 +345,8 @@ static int qemu_gluster_parse_uri(BlockdevOptionsGluster *gconf, is_unix = true; } else if (!strcmp(uri->scheme, "gluster+rdma")) { gsconf->type = SOCKET_ADDRESS_TYPE_INET; - error_report("Warning: rdma feature is not supported, falling " - "back to tcp"); + warn_report("rdma feature is not supported, falling " + "back to tcp"); } else { ret = -EINVAL; goto out; diff --git a/block/iscsi.c b/block/iscsi.c index 54067e2620..3aa438a0b7 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1761,9 +1761,9 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags, * filename encoded options */ filename = qdict_get_try_str(options, "filename"); if (filename) { - error_report("Warning: 'filename' option specified. " - "This is an unsupported option, and may be deprecated " - "in the future"); + warn_report("'filename' option specified. " + "This is an unsupported option, and may be deprecated " + "in the future"); iscsi_parse_filename(filename, options, &local_err); if (local_err) { ret = -EINVAL; diff --git a/block/nfs.c b/block/nfs.c index c3c5de0113..43929c6f23 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -558,8 +558,8 @@ static int64_t nfs_client_open(NFSClient *client, QDict *options, } client->readahead = qemu_opt_get_number(opts, "readahead-size", 0); if (client->readahead > QEMU_NFS_MAX_READAHEAD_SIZE) { - error_report("NFS Warning: Truncating NFS readahead " - "size to %d", QEMU_NFS_MAX_READAHEAD_SIZE); + warn_report("Truncating NFS readahead " + "size to %d", QEMU_NFS_MAX_READAHEAD_SIZE); client->readahead = QEMU_NFS_MAX_READAHEAD_SIZE; } nfs_set_readahead(client->context, client->readahead); @@ -579,8 +579,8 @@ static int64_t nfs_client_open(NFSClient *client, QDict *options, } client->pagecache = qemu_opt_get_number(opts, "page-cache-size", 0); if (client->pagecache > QEMU_NFS_MAX_PAGECACHE_SIZE) { - error_report("NFS Warning: Truncating NFS pagecache " - "size to %d pages", QEMU_NFS_MAX_PAGECACHE_SIZE); + warn_report("Truncating NFS pagecache " + "size to %d pages", QEMU_NFS_MAX_PAGECACHE_SIZE); client->pagecache = QEMU_NFS_MAX_PAGECACHE_SIZE; } nfs_set_pagecache(client->context, client->pagecache); @@ -595,8 +595,8 @@ static int64_t nfs_client_open(NFSClient *client, QDict *options, /* limit the maximum debug level to avoid potential flooding * of our log files. */ if (client->debug > QEMU_NFS_MAX_DEBUG_LEVEL) { - error_report("NFS Warning: Limiting NFS debug level " - "to %d", QEMU_NFS_MAX_DEBUG_LEVEL); + warn_report("Limiting NFS debug level " + "to %d", QEMU_NFS_MAX_DEBUG_LEVEL); client->debug = QEMU_NFS_MAX_DEBUG_LEVEL; } nfs_set_debug(client->context, client->debug); diff --git a/block/rbd.c b/block/rbd.c index 9da02cdceb..d461f7dc87 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -555,9 +555,9 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict *options, int flags, * filename encoded options */ filename = qdict_get_try_str(options, "filename"); if (filename) { - error_report("Warning: 'filename' option specified. " - "This is an unsupported option, and may be deprecated " - "in the future"); + warn_report("'filename' option specified. " + "This is an unsupported option, and may be deprecated " + "in the future"); qemu_rbd_parse_filename(filename, options, &local_err); if (local_err) { r = -EINVAL; diff --git a/block/ssh.c b/block/ssh.c index 52964416da..07a57eb466 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -1114,8 +1114,8 @@ static coroutine_fn int ssh_co_writev(BlockDriverState *bs, static void unsafe_flush_warning(BDRVSSHState *s, const char *what) { if (!s->unsafe_flush_warning) { - error_report("warning: ssh server %s does not support fsync", - s->inet->host); + warn_report("ssh server %s does not support fsync", + s->inet->host); if (what) { error_report("to support fsync, you need %s", what); } diff --git a/blockdev.c b/blockdev.c index e2016b6f37..a521c85956 100644 --- a/blockdev.c +++ b/blockdev.c @@ -914,7 +914,7 @@ DriveInfo *drive_new(QemuOpts *all_opts, BlockInterfaceType block_default_type) copy_on_read = qemu_opt_get_bool(legacy_opts, "copy-on-read", false); if (read_only && copy_on_read) { - error_report("warning: disabling copy-on-read on read-only drive"); + warn_report("disabling copy-on-read on read-only drive"); copy_on_read = false; } diff --git a/cpus.c b/cpus.c index 14bb8d552e..9bed61eefc 100644 --- a/cpus.c +++ b/cpus.c @@ -557,7 +557,7 @@ void qemu_start_warp_timer(void) if (deadline < 0) { static bool notified; if (!icount_sleep && !notified) { - error_report("WARNING: icount sleep disabled and no active timers"); + warn_report("icount sleep disabled and no active timers"); notified = true; } return; diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 6c92bad5b3..333dbb6f8e 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -2376,7 +2376,7 @@ static void coroutine_fn v9fs_flush(void *opaque) trace_v9fs_flush(pdu->tag, pdu->id, tag); if (pdu->tag == tag) { - error_report("Warning: the guest sent a self-referencing 9P flush request"); + warn_report("the guest sent a self-referencing 9P flush request"); } else { QLIST_FOREACH(cancel_pdu, &s->active_list, next) { if (cancel_pdu->tag == tag) { diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index d209b97dee..750c463e2a 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -383,9 +383,9 @@ static void calxeda_init(MachineState *machine, enum cxmachines machine_id) highbank_binfo.write_board_setup = hb_write_board_setup; highbank_binfo.secure_board_setup = true; } else { - error_report("WARNING: cannot load built-in Monitor support " - "if KVM is enabled. Some guests (such as Linux) " - "may not boot."); + warn_report("cannot load built-in Monitor support " + "if KVM is enabled. Some guests (such as Linux) " + "may not boot."); } arm_load_kernel(ARM_CPU(first_cpu), &highbank_binfo); diff --git a/hw/arm/imx25_pdk.c b/hw/arm/imx25_pdk.c index 44e741fde3..7d42c74001 100644 --- a/hw/arm/imx25_pdk.c +++ b/hw/arm/imx25_pdk.c @@ -80,9 +80,9 @@ static void imx25_pdk_init(MachineState *machine) /* We need to initialize our memory */ if (machine->ram_size > (FSL_IMX25_SDRAM0_SIZE + FSL_IMX25_SDRAM1_SIZE)) { - error_report("WARNING: RAM size " RAM_ADDR_FMT " above max supported, " - "reduced to %x", machine->ram_size, - FSL_IMX25_SDRAM0_SIZE + FSL_IMX25_SDRAM1_SIZE); + warn_report("RAM size " RAM_ADDR_FMT " above max supported, " + "reduced to %x", machine->ram_size, + FSL_IMX25_SDRAM0_SIZE + FSL_IMX25_SDRAM1_SIZE); machine->ram_size = FSL_IMX25_SDRAM0_SIZE + FSL_IMX25_SDRAM1_SIZE; } diff --git a/hw/arm/kzm.c b/hw/arm/kzm.c index 2c96ee33b6..3ed6577a55 100644 --- a/hw/arm/kzm.c +++ b/hw/arm/kzm.c @@ -79,9 +79,9 @@ static void kzm_init(MachineState *machine) /* Check the amount of memory is compatible with the SOC */ if (machine->ram_size > (FSL_IMX31_SDRAM0_SIZE + FSL_IMX31_SDRAM1_SIZE)) { - error_report("WARNING: RAM size " RAM_ADDR_FMT " above max supported, " - "reduced to %x", machine->ram_size, - FSL_IMX31_SDRAM0_SIZE + FSL_IMX31_SDRAM1_SIZE); + warn_report("RAM size " RAM_ADDR_FMT " above max supported, " + "reduced to %x", machine->ram_size, + FSL_IMX31_SDRAM0_SIZE + FSL_IMX31_SDRAM1_SIZE); machine->ram_size = FSL_IMX31_SDRAM0_SIZE + FSL_IMX31_SDRAM1_SIZE; } diff --git a/hw/core/machine.c b/hw/core/machine.c index ecb55528e8..dc431fabf5 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -741,11 +741,11 @@ static void machine_numa_finish_init(MachineState *machine) } } if (s->len && !qtest_enabled()) { - error_report("warning: CPU(s) not present in any NUMA nodes: %s", - s->str); - error_report("warning: All CPU(s) up to maxcpus should be described " - "in NUMA config, ability to start up with partial NUMA " - "mappings is obsoleted and will be removed in future"); + warn_report("CPU(s) not present in any NUMA nodes: %s", + s->str); + warn_report("All CPU(s) up to maxcpus should be described " + "in NUMA config, ability to start up with partial NUMA " + "mappings is obsoleted and will be removed in future"); } g_string_free(s, true); } diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index f11d57831b..f5983c83da 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -1132,15 +1132,15 @@ int qdev_prop_check_globals(void) oc = object_class_by_name(prop->driver); oc = object_class_dynamic_cast(oc, TYPE_DEVICE); if (!oc) { - error_report("Warning: global %s.%s has invalid class name", - prop->driver, prop->property); + warn_report("global %s.%s has invalid class name", + prop->driver, prop->property); ret = 1; continue; } dc = DEVICE_CLASS(oc); if (!dc->hotpluggable && !prop->used) { - error_report("Warning: global %s.%s=%s not used", - prop->driver, prop->property, prop->value); + warn_report("global %s.%s=%s not used", + prop->driver, prop->property, prop->value); ret = 1; continue; } diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 5464977424..6b7bade183 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -2766,17 +2766,17 @@ void acpi_build(AcpiBuildTables *tables, MachineState *machine) ACPI_BUILD_ALIGN_SIZE); if (tables_blob->len > legacy_table_size) { /* Should happen only with PCI bridges and -M pc-i440fx-2.0. */ - error_report("Warning: migration may not work."); + warn_report("migration may not work."); } g_array_set_size(tables_blob, legacy_table_size); } else { /* Make sure we have a buffer in case we need to resize the tables. */ if (tables_blob->len > ACPI_BUILD_TABLE_SIZE / 2) { /* As of QEMU 2.1, this fires with 160 VCPUs and 255 memory slots. */ - error_report("Warning: ACPI tables are larger than 64k."); - error_report("Warning: migration may not work."); - error_report("Warning: please remove CPUs, NUMA nodes, " - "memory slots or PCI bridges."); + warn_report("ACPI tables are larger than 64k."); + warn_report("migration may not work."); + warn_report("please remove CPUs, NUMA nodes, " + "memory slots or PCI bridges."); } acpi_align_size(tables_blob, ACPI_BUILD_TABLE_SIZE); } diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c index 9f2615cbe0..33e20cb3e8 100644 --- a/hw/i386/kvm/pci-assign.c +++ b/hw/i386/kvm/pci-assign.c @@ -1353,9 +1353,9 @@ static int assigned_device_pci_cap_init(PCIDevice *pci_dev, Error **errp) PCI_CAP_ID_EXP); return -EINVAL; } else if (size != 0x3c) { - error_report("WARNING, %s: PCIe cap-id 0x%x has " - "non-standard size 0x%x; std size should be 0x3c", - __func__, PCI_CAP_ID_EXP, size); + warn_report("%s: PCIe cap-id 0x%x has " + "non-standard size 0x%x; std size should be 0x3c", + __func__, PCI_CAP_ID_EXP, size); } } else if (version == 0) { uint16_t vid, did; diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 224fe58fe7..465e91cc5b 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -381,8 +381,8 @@ ISADevice *pc_find_fdc0(void) } if (state.multiple) { - error_report("warning: multiple floppy disk controllers with " - "iobase=0x3f0 have been found"); + warn_report("multiple floppy disk controllers with " + "iobase=0x3f0 have been found"); error_printf("the one being picked for CMOS setup might not reflect " "your intent\n"); } @@ -2087,9 +2087,9 @@ static void pc_machine_set_max_ram_below_4g(Object *obj, Visitor *v, } if (value < (1ULL << 20)) { - error_report("Warning: small max_ram_below_4g(%"PRIu64 - ") less than 1M. BIOS may not work..", - value); + warn_report("small max_ram_below_4g(%"PRIu64 + ") less than 1M. BIOS may not work..", + value); } pcms->max_ram_below_4g = value; diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 22dbef64c6..11b4336a42 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -131,10 +131,10 @@ static void pc_init1(MachineState *machine, lowmem = 0xc0000000; } if (lowmem & ((1ULL << 30) - 1)) { - error_report("Warning: Large machine and max_ram_below_4g " - "(%" PRIu64 ") not a multiple of 1G; " - "possible bad performance.", - pcms->max_ram_below_4g); + warn_report("Large machine and max_ram_below_4g " + "(%" PRIu64 ") not a multiple of 1G; " + "possible bad performance.", + pcms->max_ram_below_4g); } } } diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 8f696b7cb6..1653a47f0a 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -101,9 +101,9 @@ static void pc_q35_init(MachineState *machine) lowmem = pcms->max_ram_below_4g; if (machine->ram_size - lowmem > lowmem && lowmem & ((1ULL << 30) - 1)) { - error_report("Warning: Large machine and max_ram_below_4g(%"PRIu64 - ") not a multiple of 1G; possible bad performance.", - pcms->max_ram_below_4g); + warn_report("Large machine and max_ram_below_4g(%"PRIu64 + ") not a multiple of 1G; possible bad performance.", + pcms->max_ram_below_4g); } } diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c index 5f3ac0b6f6..633fa4510e 100644 --- a/hw/misc/aspeed_sdmc.c +++ b/hw/misc/aspeed_sdmc.c @@ -157,8 +157,8 @@ static int ast2400_rambits(AspeedSDMCState *s) } /* use a common default */ - error_report("warning: Invalid RAM size 0x%" PRIx64 - ". Using default 256M", s->ram_size); + warn_report("Invalid RAM size 0x%" PRIx64 + ". Using default 256M", s->ram_size); s->ram_size = 256 << 20; return ASPEED_SDMC_DRAM_256MB; } @@ -179,8 +179,8 @@ static int ast2500_rambits(AspeedSDMCState *s) } /* use a common default */ - error_report("warning: Invalid RAM size 0x%" PRIx64 - ". Using default 512M", s->ram_size); + warn_report("Invalid RAM size 0x%" PRIx64 + ". Using default 512M", s->ram_size); s->ram_size = 512 << 20; return ASPEED_SDMC_AST2500_512MB; } diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 99bdbc2233..e881e3b812 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -781,7 +781,7 @@ static int get_fw_cfg_order(FWCfgState *s, const char *name) } /* Stick unknown stuff at the end. */ - error_report("warning: Unknown firmware file in legacy mode: %s", name); + warn_report("Unknown firmware file in legacy mode: %s", name); return FW_CFG_ORDER_OVERRIDE_LAST; } diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index a2c1033dbe..072a04e318 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-host/piix.c @@ -307,7 +307,7 @@ static void i440fx_realize(PCIDevice *dev, Error **errp) dev->config[I440FX_SMRAM] = 0x02; if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) { - error_report("warning: i440fx doesn't support emulated iommu"); + warn_report("i440fx doesn't support emulated iommu"); } } diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index a4cd733cba..47221158d4 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -160,13 +160,13 @@ static void powernv_create_core_node(PnvChip *chip, PnvCore *pc, void *fdt) _FDT((fdt_setprop_cell(fdt, offset, "d-cache-size", pcc->l1_dcache_size))); } else { - error_report("Warning: Unknown L1 dcache size for cpu"); + warn_report("Unknown L1 dcache size for cpu"); } if (pcc->l1_icache_size) { _FDT((fdt_setprop_cell(fdt, offset, "i-cache-size", pcc->l1_icache_size))); } else { - error_report("Warning: Unknown L1 icache size for cpu"); + warn_report("Unknown L1 icache size for cpu"); } _FDT((fdt_setprop_cell(fdt, offset, "timebase-frequency", tbfreq))); @@ -556,7 +556,7 @@ static void ppc_powernv_init(MachineState *machine) /* allocate RAM */ if (machine->ram_size < (1 * G_BYTE)) { - error_report("Warning: skiboot may not work with < 1GB of RAM"); + warn_report("skiboot may not work with < 1GB of RAM"); } ram = g_new(MemoryRegion, 1); diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 0ee9fac50b..fdd55d4820 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -534,13 +534,13 @@ static void spapr_populate_cpu_dt(CPUState *cs, void *fdt, int offset, _FDT((fdt_setprop_cell(fdt, offset, "d-cache-size", pcc->l1_dcache_size))); } else { - error_report("Warning: Unknown L1 dcache size for cpu"); + warn_report("Unknown L1 dcache size for cpu"); } if (pcc->l1_icache_size) { _FDT((fdt_setprop_cell(fdt, offset, "i-cache-size", pcc->l1_icache_size))); } else { - error_report("Warning: Unknown L1 icache size for cpu"); + warn_report("Unknown L1 icache size for cpu"); } _FDT((fdt_setprop_cell(fdt, offset, "timebase-frequency", tbfreq))); diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c index 8656a54a3e..583afc1a46 100644 --- a/hw/ppc/spapr_iommu.c +++ b/hw/ppc/spapr_iommu.c @@ -334,7 +334,7 @@ void spapr_tce_table_enable(sPAPRTCETable *tcet, uint32_t nb_table) { if (tcet->nb_table) { - error_report("Warning: trying to enable already enabled TCE table"); + warn_report("trying to enable already enabled TCE table"); return; } diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index f5574469c8..23c51de66a 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -282,9 +282,9 @@ void scsi_bus_legacy_handle_cmdline(SCSIBus *bus, bool deprecated) continue; /* claimed */ } if (!dinfo->is_default) { - error_report("warning: bus=%d,unit=%d is deprecated with this" - " machine type", - bus->busnr, unit); + warn_report("bus=%d,unit=%d is deprecated with this" + " machine type", + bus->busnr, unit); } } scsi_bus_legacy_add_drive(bus, blk_by_legacy_dinfo(dinfo), diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 49cb1829b5..79cd2758a5 100644 --- a/hw/usb/dev-smartcard-reader.c +++ b/hw/usb/dev-smartcard-reader.c @@ -1314,12 +1314,12 @@ static int ccid_card_init(DeviceState *qdev) int ret = 0; if (card->slot != 0) { - error_report("Warning: usb-ccid supports one slot, can't add %d", + warn_report("usb-ccid supports one slot, can't add %d", card->slot); return -1; } if (s->card != NULL) { - error_report("Warning: usb-ccid card already full, not adding"); + warn_report("usb-ccid card already full, not adding"); return -1; } ret = ccid_card_initfn(card); diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index aa22d69216..5b65965cc2 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -193,7 +193,7 @@ static void usbredir_handle_status(USBRedirDevice *dev, USBPacket *p, #define WARNING(...) \ do { \ if (dev->debug >= usbredirparser_warning) { \ - error_report("usb-redir warning: " __VA_ARGS__); \ + warn_report("" __VA_ARGS__); \ } \ } while (0) #define INFO(...) \ diff --git a/net/tap-linux.c b/net/tap-linux.c index a503fa9c6e..535b1ddb61 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -55,7 +55,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr, ifr.ifr_flags = IFF_TAP | IFF_NO_PI; if (ioctl(fd, TUNGETFEATURES, &features) == -1) { - error_report("warning: TUNGETFEATURES failed: %s", strerror(errno)); + warn_report("TUNGETFEATURES failed: %s", strerror(errno)); features = 0; } diff --git a/target/i386/cpu.c b/target/i386/cpu.c index c57177278b..c078c8e7f1 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -2060,13 +2060,13 @@ static void x86_cpu_parse_featurestr(const char *typename, char *features, name = featurestr; if (g_list_find_custom(plus_features, name, compare_string)) { - error_report("warning: Ambiguous CPU model string. " + warn_report("Ambiguous CPU model string. " "Don't mix both \"+%s\" and \"%s=%s\"", name, name, val); ambiguous = true; } if (g_list_find_custom(minus_features, name, compare_string)) { - error_report("warning: Ambiguous CPU model string. " + warn_report("Ambiguous CPU model string. " "Don't mix both \"-%s\" and \"%s=%s\"", name, name, val); ambiguous = true; @@ -2096,7 +2096,7 @@ static void x86_cpu_parse_featurestr(const char *typename, char *features, } if (ambiguous) { - error_report("warning: Compatibility of ambiguous CPU model " + warn_report("Compatibility of ambiguous CPU model " "strings won't be kept on future QEMU versions"); } } @@ -3547,7 +3547,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) */ if (cpu->phys_bits != host_phys_bits && cpu->phys_bits != 0 && !warned) { - error_report("Warning: Host physical bits (%u)" + warn_report("Host physical bits (%u)" " does not match phys-bits property (%u)", host_phys_bits, cpu->phys_bits); warned = true; diff --git a/target/i386/kvm.c b/target/i386/kvm.c index f84a49d366..2ea1d8c728 100644 --- a/target/i386/kvm.c +++ b/target/i386/kvm.c @@ -600,7 +600,7 @@ static int kvm_arch_set_tsc_khz(CPUState *cs) kvm_vcpu_ioctl(cs, KVM_GET_TSC_KHZ) : -ENOTSUP; if (cur_freq <= 0 || cur_freq != env->tsc_khz) { - error_report("warning: TSC frequency mismatch between " + warn_report("TSC frequency mismatch between " "VM (%" PRId64 " kHz) and host (%d kHz), " "and TSC scaling unavailable", env->tsc_khz, cur_freq); @@ -919,7 +919,7 @@ int kvm_arch_init_vcpu(CPUState *cs) error_report("kvm: LMCE not supported"); return -ENOTSUP; } - error_report("warning: Unsupported MCG_CAP bits: 0x%" PRIx64, + warn_report("Unsupported MCG_CAP bits: 0x%" PRIx64, unsupported_caps); } diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 7cb55dc7e3..8db2dfd6d4 100644 --- a/target/s390x/cpu_models.c +++ b/target/s390x/cpu_models.c @@ -677,7 +677,7 @@ static void check_consistency(const S390CPUModel *model) for (i = 0; i < ARRAY_SIZE(dep); i++) { if (test_bit(dep[i][0], model->features) && !test_bit(dep[i][1], model->features)) { - error_report("Warning: \'%s\' requires \'%s\'.", + warn_report("\'%s\' requires \'%s\'.", s390_feat_def(dep[i][0])->name, s390_feat_def(dep[i][1])->name); } diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index a3d00196f4..8e956ae39c 100644 --- a/target/s390x/kvm.c +++ b/target/s390x/kvm.c @@ -2675,7 +2675,7 @@ void kvm_s390_apply_cpu_model(const S390CPUModel *model, Error **errp) /* enable CMM via CMMA - disable on hugetlbfs */ if (test_bit(S390_FEAT_CMM, model->features)) { if (mem_path) { - error_report("Warning: CMM will not be enabled because it is not " + warn_report("CMM will not be enabled because it is not " "compatible to hugetlbfs."); } else { kvm_s390_enable_cmma(); diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-props.c index 48e5b7315f..b25fe892ed 100644 --- a/tests/test-qdev-global-props.c +++ b/tests/test-qdev-global-props.c @@ -232,10 +232,10 @@ static void test_dynamic_globalprop(void) g_test_trap_assert_passed(); g_test_trap_assert_stderr_unmatched("*prop1*"); g_test_trap_assert_stderr_unmatched("*prop2*"); - g_test_trap_assert_stderr("*Warning: global dynamic-prop-type-bad.prop3 has invalid class name\n*"); + g_test_trap_assert_stderr("*warning: global dynamic-prop-type-bad.prop3 has invalid class name\n*"); g_test_trap_assert_stderr_unmatched("*prop4*"); - g_test_trap_assert_stderr("*Warning: global nohotplug-type.prop5=105 not used\n*"); - g_test_trap_assert_stderr("*Warning: global nondevice-type.prop6 has invalid class name\n*"); + g_test_trap_assert_stderr("*warning: global nohotplug-type.prop5=105 not used\n*"); + g_test_trap_assert_stderr("*warning: global nondevice-type.prop6 has invalid class name\n*"); g_test_trap_assert_stdout(""); } diff --git a/trace/control.c b/trace/control.c index 9b157b0ca7..bda1000554 100644 --- a/trace/control.c +++ b/trace/control.c @@ -171,7 +171,7 @@ static void do_trace_enable_events(const char *line_buf) while ((ev = trace_event_iter_next(&iter)) != NULL) { if (!trace_event_get_state_static(ev)) { if (!is_pattern) { - error_report("WARNING: trace event '%s' is not traceable", + warn_report("trace event '%s' is not traceable", line_ptr); return; } @@ -186,7 +186,7 @@ static void do_trace_enable_events(const char *line_buf) } if (!is_pattern) { - error_report("WARNING: trace event '%s' does not exist", + warn_report("trace event '%s' does not exist", line_ptr); } } diff --git a/vl.c b/vl.c index d17c863409..d5342fe816 100644 --- a/vl.c +++ b/vl.c @@ -952,8 +952,8 @@ static void bt_vhci_add(int vlan_id) struct bt_scatternet_s *vlan = qemu_find_bt_vlan(vlan_id); if (!vlan->slave) - error_report("warning: adding a VHCI to an empty scatternet %i", - vlan_id); + warn_report("adding a VHCI to an empty scatternet %i", + vlan_id); bt_vhci_init(bt_new_hci(vlan)); } @@ -979,8 +979,8 @@ static struct bt_device_s *bt_device_add(const char *opt) vlan = qemu_find_bt_vlan(vlan_id); if (!vlan->slave) - error_report("warning: adding a slave device to an empty scatternet %i", - vlan_id); + warn_report("adding a slave device to an empty scatternet %i", + vlan_id); if (!strcmp(devname, "keyboard")) return bt_keyboard_init(vlan); @@ -2302,8 +2302,8 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, Error **errp) return -1; } if (strncmp(name, "opt/", 4) != 0) { - error_report("warning: externally provided fw_cfg item names " - "should be prefixed with \"opt/\""); + warn_report("externally provided fw_cfg item names " + "should be prefixed with \"opt/\""); } if (nonempty_str(str)) { size = strlen(str); /* NUL terminator NOT included in fw_cfg blob */ @@ -3760,7 +3760,7 @@ int main(int argc, char **argv, char **envp) qemu_opts_parse_noisily(olist, "accel=tcg", false); break; case QEMU_OPTION_no_kvm_pit: { - error_report("warning: ignoring deprecated option"); + warn_report("ignoring deprecated option"); break; } case QEMU_OPTION_no_kvm_pit_reinjection: { @@ -3770,8 +3770,8 @@ int main(int argc, char **argv, char **envp) .value = "discard", }; - error_report("warning: deprecated, replaced by " - "-global kvm-pit.lost_tick_policy=discard"); + warn_report("deprecated, replaced by " + "-global kvm-pit.lost_tick_policy=discard"); qdev_prop_register_global(&kvm_pit_lost_tick_policy); break; } @@ -3896,7 +3896,7 @@ int main(int argc, char **argv, char **envp) } break; case QEMU_OPTION_tdf: - error_report("warning: ignoring deprecated option"); + warn_report("ignoring deprecated option"); break; case QEMU_OPTION_name: opts = qemu_opts_parse_noisily(qemu_find_opts("name"),