diff mbox series

[v3,07/24] migration: Document the BQL behavior of load SaveVMHandlers

Message ID e1949839932efaa531e2fe63ac13324e5787439c.1731773021.git.maciej.szmigiero@oracle.com (mailing list archive)
State New
Headers show
Series Multifd | expand

Commit Message

Maciej S. Szmigiero Nov. 17, 2024, 7:20 p.m. UTC 
From: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>

Some of these SaveVMHandlers were missing the BQL behavior annotation,
making people wonder what it exactly is.

Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
---
 include/migration/register.h | 9 +++++++++
 1 file changed, 9 insertions(+)
diff mbox series

Patch

diff --git a/include/migration/register.h b/include/migration/register.h
index 39991f3cc5d0..761e4e4d8bcb 100644
--- a/include/migration/register.h
+++ b/include/migration/register.h
@@ -212,6 +212,8 @@  typedef struct SaveVMHandlers {
     void (*state_pending_exact)(void *opaque, uint64_t *must_precopy,
                                 uint64_t *can_postcopy);
 
+    /* This runs inside the BQL. */
+
     /**
      * @load_state
      *
@@ -246,6 +248,8 @@  typedef struct SaveVMHandlers {
     int (*load_state_buffer)(void *opaque, char *buf, size_t len,
                              Error **errp);
 
+    /* The following handlers run inside the BQL. */
+
     /**
      * @load_setup
      *
@@ -272,6 +276,9 @@  typedef struct SaveVMHandlers {
      */
     int (*load_cleanup)(void *opaque);
 
+
+    /* This runs outside the BQL. */
+
     /**
      * @resume_prepare
      *
@@ -284,6 +291,8 @@  typedef struct SaveVMHandlers {
      */
     int (*resume_prepare)(MigrationState *s, void *opaque);
 
+    /* The following handlers run inside the BQL. */
+
     /**
      * @switchover_ack_needed
      *