From patchwork Tue Nov 28 22:31:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 10081201 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E2797602DC for ; Tue, 28 Nov 2017 22:36:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D6EB9296D0 for ; Tue, 28 Nov 2017 22:36:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CBD8A29712; Tue, 28 Nov 2017 22:36:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 66ACE296D0 for ; Tue, 28 Nov 2017 22:36:45 +0000 (UTC) Received: from localhost ([::1]:40361 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJoUe-000266-Jq for patchwork-qemu-devel@patchwork.kernel.org; Tue, 28 Nov 2017 17:36:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJoTc-00025c-M9 for qemu-devel@nongnu.org; Tue, 28 Nov 2017 17:35:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJoTZ-0006W6-IP for qemu-devel@nongnu.org; Tue, 28 Nov 2017 17:35:40 -0500 Received: from mail-cys01nam02on0041.outbound.protection.outlook.com ([104.47.37.41]:58544 helo=NAM02-CY1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eJoTZ-0006Vc-A1 for qemu-devel@nongnu.org; Tue, 28 Nov 2017 17:35:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=r7HXQZtgDTCPIyv2USzPcL5i/4m6Qz4gnb7ZO5agpw8=; b=t8miR+AzlD/JeCH0EoPnTClkDsNeowzjZun6CtIsqoEtp4KLjbSWoK5d+x7rAXkUTHAM3eFCsBb5UhEpK3B6zs8oCMgotceKE83+ZZXD7qpcU7OZZzB/tJsFm1G3oR5TsjtxQ432S/Fb41BJryEQM/cr+nXAWyBGyXA05D+PwwE= Received: from BLUPR0201CA0036.namprd02.prod.outlook.com (10.163.116.46) by MWHPR02MB3391.namprd02.prod.outlook.com (10.164.192.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Tue, 28 Nov 2017 22:35:34 +0000 Received: from CY1NAM02FT043.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::202) by BLUPR0201CA0036.outlook.office365.com (2a01:111:e400:52e7::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.282.5 via Frontend Transport; Tue, 28 Nov 2017 22:35:34 +0000 Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT043.mail.protection.outlook.com (10.152.74.182) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.239.4 via Frontend Transport; Tue, 28 Nov 2017 22:35:32 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:55323 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1eJoTT-0005r2-8y; Tue, 28 Nov 2017 14:35:31 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1eJoTT-0003KU-4T; Tue, 28 Nov 2017 14:35:31 -0800 Received: from xsj-pvapsmtp01 (smtp2.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id vASMZKM6021776; Tue, 28 Nov 2017 14:35:20 -0800 Received: from [172.19.2.220] (helo=xsjalistai50.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1eJoTI-0003C1-8X; Tue, 28 Nov 2017 14:35:20 -0800 From: Alistair Francis To: , , Date: Tue, 28 Nov 2017 14:31:14 -0800 Message-ID: X-Mailer: git-send-email 2.14.1 In-Reply-To: References: X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.1.0.1062-23496.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(346002)(376002)(2980300002)(438002)(189002)(199003)(76176999)(16586007)(54906003)(305945005)(50986999)(478600001)(316002)(36756003)(356003)(9786002)(106002)(4326008)(7696005)(39060400002)(36386004)(50466002)(48376002)(51416003)(8676002)(77096006)(50226002)(8936002)(81156014)(81166006)(110136005)(2201001)(33646002)(106466001)(118296001)(5660300001)(63266004)(189998001)(2906002)(6666003)(2950100002)(47776003)(107986001)(5001870100001)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR02MB3391; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT043; 1:M5Q8MWWZGV86+hx8PAzNaaDoTmNIlkfe4DjfPo4lB9YRMRBMwe8YF2g71fQA3AmVJj6wdAFA5Y2jspnVenzsLgUyYJFqVQDzkNuH5RE2rymRdXIdE7BrIgpLW2pscUqZ MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 294fcb5d-e1c3-437a-7f9c-08d536b05681 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4608076)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603260); SRVR:MWHPR02MB3391; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3391; 3:fCztBL3bTKAcnbhZis9583M/x6jc4uyrBRj3tEeH4M3V3tG+fpn/2qyQq5HQ9YVh/cK5XV/m1gd7hqdLpIlDFd2eCVchxdKHKPRsTdcbyWPyKTRgn3rI4yrhvTXWbbMDn9Q1XHy3CGiN9RGYsUl/1FQ9TzoT/rEU/NEOUd9kRoy+xwEuwe/E6e2p+Gqw7IAHtwHRFrgPmi4ni7qbuRjq05ZPbhjW8h1xW9dXGX3asO1R6KhF+29xrSKpgf/tc1hnVnbzOXolWSix+z7qXf2T8rczkz5IIHZ3ERxlYu3/3CrPw+tSkAtivo5wU9AaE+CGjrsBo9rqA46S2Y2J//iycedLrTyvKSmT7WM6nb84nuQ=; 25:g0vQLPlGmzZ7uRP368f9dpvhpoWtcyfNui+K5yqJxvpI9ol29muPqG9ZUS1mJzpZFdQYq6DKQPQfB2nfS47TuAJnHAXLSeBc2RfI5sTByjrveAbJlXdHU0Xcg9tnTUL27WB9S3Hl0nJ/lNmBTA0N0uAn+wMGmnzT2qEEL7fK2MZV/ZrkoYN6jC0WuGAL/of6/aR5bEjFoP/vP4zua/VWb5k+b0sIrRc6br3YngIBAhe9OW4fNdUUJZ6hmFumGwfkntD52TryISrZvyHqNP+X2hrhV+pYOKj9omvC1fXke2YbiSd0cEbYHm7f8VAPC1UCZH8VJKi6yFTvaGRk2DHyGQ== X-MS-TrafficTypeDiagnostic: MWHPR02MB3391: X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3391; 31:GQ/guQypsNTye1fGBSirzd+QgqVNpiInt1Ajn9msfgA7MZ885PDSHjFcf/iLk+s/dKDYsoirQ2wU1ROpVmPAf6aJS2nKSl6/kOErWjtnQUAmOvYoyfxgxt+std1WsStzqpiQ9gcfTE2gRpN7i9mraZewPS4p0Pj742bPdVO49LaHJHgqHxn6Q66/vN37Yb8oNtBPHWKuyoi0UWd5shDL9JcWJCFTePAVPaXtOokQLlA=; 20:p3XznXrd0e+64WfmXD6YDgx1Un3biBlWfG4AqzxA0XAChVgu1c9f/ERLjIoP0vRhy0GQacwL8Qx/yf/6Sj6wF1cnS0SUATn5Oso8OCWpaPmvZ7gm1vnUCC3lVGI2Jtfkyhb5X0a676WsBdLyjkjxfnnYJAefysi4fXN9r+KrZ2DV4fzI3/BkXhonQzYv3hQ27lYvuFZJx6g5WR9OnanH4OGjSq5NvCCxwrLmrCw+/gMJJrm2vg9iYFIZfQEdRoiiZPDf7UoMBIopzex/b/h2Da5pn9OHWmCt9FHH1ZyKGe3UERFS7OuWRFASQXqKvktIDgXDPl2kWKw5dOyoxu13/HX8InP6zVylGPebGYkI3bCpQ6MSogr76tOij2hToHkrOrtLpb0aFCBErw5Bx+W0GpSE72Z2CKx+PdjjMolTY1ii8DTkdCv2BZkxoqHxtlPgxGa00bkfd224MJq+p32tUrLj3/KQ6OJFozpCsAy57DBjk9FL41ckudHwjFmoaqad X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(8121501046)(5005006)(93006095)(93004095)(3231022)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123558100)(20161123555025)(6072148)(201708071742011); SRVR:MWHPR02MB3391; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:MWHPR02MB3391; X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3391; 4:hGy9iBfMqfQsX/BLETM//69jAZY78zEozSycCqqlOXa9WJh9Mc0LxHHILuAyQeIPqTCrJeUJzE7ONs3mQszOMMVKZ5ERhch2oZXZOmhEHva7ARMYFWc3gNxGfvtFOHkfV4UIdJJLvREIfOE4mdYVNbIqoqneYbESsW7YG2NZDkaFJb5TT4NZp/Tlcq4xSG7WwaTfjLjBhsm/zoer0gr+qLL6FA7gpj8/g+9GfZMJlriju1pEmOH5JMoluxivsm2CQZPT0j0H2Qm6YPzocPa41T6hz9xtVX78vRxLCkSIOxy8VBHs5VKX1A8GRbCFaaGf X-Forefront-PRVS: 0505147DDB X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR02MB3391; 23:BYvflrqJYaFxosr+4OOqzA/gDolC5Aw9M49TupSad?= =?us-ascii?Q?98+Za4D6NtZrp6HRDEynjJoCzhzyCMhNztU7X5vq5bcxFHkUVoWAAaYcFKVk?= =?us-ascii?Q?1/C4YeH3dFeu5QNz9DCU05Z3U9VCOGf55E0lSlWZZjwOK8C16P8crsY77mA7?= =?us-ascii?Q?xnplcxKlDThFUiDYlwANQzXzY3C5LJS4c+PwNoiefu3Yoc28PZ3sUybB7zTj?= =?us-ascii?Q?cQIdh9zQ6SlIKKx8gys0t9I3U25ayc+ensc7zKw2PhIiP7bdJYljWR7xfu+y?= =?us-ascii?Q?T1itn9LB3oc6P/NUyUrrqIiwwmr2sP2PyGdS7MbLVGKqv9B+1M9E5JLgxErP?= =?us-ascii?Q?OOGaZ1U1IGmFNDWkn52wyuuNLvGXs3aO575vu2eOK8SVro7sEW+XTH+fBoox?= =?us-ascii?Q?vg9+j5Ijh1mggrBCInTHmT+P6UhO+hpc1XipxnHluXKoOkul8EgiFOa0907j?= =?us-ascii?Q?xdZsvPWAw+XxFL/w+kzB0F6cV7m4OANkV1YNDFWCg7wxJz61p1sasMbGMgXH?= =?us-ascii?Q?W5jHiMDi0yK/May9oQ/s/3Y8JNwBZdWPC9YoRClK/A2+MP//72RFfluOKoco?= =?us-ascii?Q?KzAmG0cRFNHWn84hjOBSWyk3au6+r/VCVd1VmIRhx5qvPhMXxEGw3QU5dLwK?= =?us-ascii?Q?WiQjCgiVtma6SRN++hzNI9+WXgsg5KFpVSgpQ3u9pbgNHsoJRqIrh6ZEWeBS?= =?us-ascii?Q?MWDnZ7mfGLc27LWv/zbROd2serLEIiNxQAerx7Ux22vnDRNv4a3syDtwI986?= =?us-ascii?Q?BY7ar8cfPxomMWiMjiVfvk/bBMCIZ0GJhrYRCUAxvdU9igsOfaxd+66M4h9d?= =?us-ascii?Q?Kx/0YvfMpO9AprxsMGQ2OJSt2kftYhjshJWtDUo9RVf8rhAflChH5x7/Rm4K?= =?us-ascii?Q?L1Yx2rgzTwPJ+bAdz2fisiyV/QT7QZnxIF2OibQW3nN6b/OHmf6q2QSVHcu5?= =?us-ascii?Q?egCnQcnlVnNo1ygSVlb52soTX4OqyVpQ5hHT6kw4sd9QUnARFAbqfhlbJdFm?= =?us-ascii?Q?zD3g4weCtU2UTactEaTM7duom6BdcRn6+DZR935ViguEoJAcliltaDplKPc8?= =?us-ascii?Q?TkFBR/IeZTsVeTudocZr2lJybAwxRp0nF9+/LhilUpjooMoSOOh5YwOOtS1C?= =?us-ascii?Q?peADgaocxg=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR02MB3391; 6:buLRxFYx4uVwO0V2czaEGl0zymta2KP3GZ+N8/Zw60ulxY1berOzYjkmXPdwSmqZmirU0oOIc//K47CWJ2X24v/6iUcPkeA0/PaUrcu4dGXnTt898J/1x0cd/Q2FjqnW45um/Dva/XlXWTbGPPd1TYuBReM1bNPwy3l6MTDB+hmAoZYAXPtqQt11M+v6Won9kBFZlUIGsod2FKLfYkOWLxH1bjD/Kuj3w/nBkZvVZZe37EMFnAkUbs8F2srfbuREh8shzboCmUS0AHK0llAlwGVRGiBSwDV0VrV0Eua7E64abF7Ms9te+hLdkv0+6fEQ6LK5wb8i4+KkbBmmFTyEgyBp7mbbTHhKiPhTOItu1Sw=; 5:psqQyei6oNZdR3yCeretdkRzSbtVvwcNPHlvR4vpzT2fPotdvdyqePGJ3yUFStjpITAB+uDfTfrHYGn3B0s0PPi9Omh6tNOvbGwkR9EEdof5oK2B3vuvfOLYTJhGPyu6bXEyRa+E+5h+lPxhfN474Az5KyydYcDeiLMJ4n5XBHU=; 24:RG6zL1iDRZj5386d76YH2YmsyEZvG2cXDrOf8+mWEmEfIoz6lHduR3F5Jh8nfwdjKTc6SWd+MBv6zScfAg4aBp30SfR10X9aXMTwziFkbKQ=; 7:sLmJy/NH6crtliNDc6bkl6S08Jb6HTDQ8ggZ5mstHL4MY3/1NKd6dWIc3yF6iItr0oB+vf9oLcTrJaPZW7VajWDrTfMzrZelH7Y9kybjZqQnEjLHeU/B9BA7PrLLAWPDgsv3ij3XZpefyWk2KkohjarsUU1owqzs0EB9jD5AV5Ze1oNzwPEtbMV9KwNkO84NUpuP190Ri61RW6iWaSy0S2mxQZw++1L7OFpL6S19Lf8cPnDmVDSwGs2ux0QOBbW/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2017 22:35:32.4389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 294fcb5d-e1c3-437a-7f9c-08d536b05681 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3391 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.37.41 Subject: [Qemu-devel] [PATCH-2.12 v1 3/3] xilinx_spips: Use memset instead of a for loop to zero registers X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, alistair.francis@xilinx.com Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP Use memset() instead of a for loop to zero all of the registers. Signed-off-by: Alistair Francis Reviewed-by: KONRAD Frederic Reviewed-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 1a37f9c7f5..82436e2f69 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -330,10 +330,7 @@ static void xilinx_spips_reset(DeviceState *d) { XilinxSPIPS *s = XILINX_SPIPS(d); - int i; - for (i = 0; i < XLNX_SPIPS_R_MAX; i++) { - s->regs[i] = 0; - } + memset(s->regs, 0, sizeof(s->regs)); fifo8_reset(&s->rx_fifo); fifo8_reset(&s->rx_fifo); @@ -358,13 +355,11 @@ static void xilinx_spips_reset(DeviceState *d) static void xlnx_zynqmp_qspips_reset(DeviceState *d) { XlnxZynqMPQSPIPS *s = XLNX_ZYNQMP_QSPIPS(d); - int i; xilinx_spips_reset(d); - for (i = 0; i < XLNX_ZYNQMP_SPIPS_R_MAX; i++) { - s->regs[i] = 0; - } + memset(s->regs, 0, sizeof(s->regs)); + fifo8_reset(&s->rx_fifo_g); fifo8_reset(&s->rx_fifo_g); fifo32_reset(&s->fifo_g);