| Message ID | ef587f7f38ad5714d5c8eeb05448d19a6130799e.1721648163.git.manos.pitsidianakis@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Rust support, implement ARM PL011 | expand |
On 7/22/24 21:43, Manos Pitsidianakis wrote: > Add job that builds with rust support enabled on debian. > > Signed-off-by: Manos Pitsidianakis<manos.pitsidianakis@linaro.org> > --- > .gitlab-ci.d/buildtest.yml | 11 +++++++++++ > 1 file changed, 11 insertions(+) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On Mon, Jul 22, 2024 at 02:43:33PM +0300, Manos Pitsidianakis wrote: > Add job that builds with rust support enabled on debian. > > Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> > --- > .gitlab-ci.d/buildtest.yml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml > index e3a0758bd9..e025e2cbf6 100644 > --- a/.gitlab-ci.d/buildtest.yml > +++ b/.gitlab-ci.d/buildtest.yml > @@ -107,6 +107,17 @@ crash-test-debian: > - make NINJA=":" check-venv > - pyvenv/bin/python3 scripts/device-crash-test -q --tcg-only ./qemu-system-i386 > > +build-system-rust-debian: > + extends: > + - .native_build_job_template > + - .native_build_artifact_template > + needs: > + job: amd64-debian-container > + variables: > + IMAGE: debian > + CONFIGURE_ARGS: --enable-rust > + TARGETS: aarch64-softmmu > + Do we actually want to do this ? With the updated lcitool containers, any of the existing build-system-XXXX jobs ought to be able to detect availability of rust and build with it. Re-using existing jobs means we burn less CI time. With regards, Daniel
On Tue, 23 Jul 2024 11:39, "Daniel P. Berrangé" <berrange@redhat.com> wrote: >On Mon, Jul 22, 2024 at 02:43:33PM +0300, Manos Pitsidianakis wrote: >> Add job that builds with rust support enabled on debian. >> >> Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> >> --- >> .gitlab-ci.d/buildtest.yml | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml >> index e3a0758bd9..e025e2cbf6 100644 >> --- a/.gitlab-ci.d/buildtest.yml >> +++ b/.gitlab-ci.d/buildtest.yml >> @@ -107,6 +107,17 @@ crash-test-debian: >> - make NINJA=":" check-venv >> - pyvenv/bin/python3 scripts/device-crash-test -q --tcg-only ./qemu-system-i386 >> >> +build-system-rust-debian: >> + extends: >> + - .native_build_job_template >> + - .native_build_artifact_template >> + needs: >> + job: amd64-debian-container >> + variables: >> + IMAGE: debian >> + CONFIGURE_ARGS: --enable-rust >> + TARGETS: aarch64-softmmu >> + > >Do we actually want to do this ? With the updated lcitool containers, >any of the existing build-system-XXXX jobs ought to be able to detect >availability of rust and build with it. Re-using existing jobs means >we burn less CI time. > >With regards, >Daniel Hello Daniel, I think we do, as long as a rust toolchain is not required to build QEMU by default. The other jobs could detect availability of Rust but we don't have a way to check if it works and not fallback to compiling without Rust. Could we force enable Rust in one of the existing jobs? Manos
On Tue, Jul 23, 2024 at 01:06:20PM +0300, Manos Pitsidianakis wrote: > On Tue, 23 Jul 2024 11:39, "Daniel P. Berrangé" <berrange@redhat.com> wrote: > > On Mon, Jul 22, 2024 at 02:43:33PM +0300, Manos Pitsidianakis wrote: > > > Add job that builds with rust support enabled on debian. > > > > > > Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> > > > --- > > > .gitlab-ci.d/buildtest.yml | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml > > > index e3a0758bd9..e025e2cbf6 100644 > > > --- a/.gitlab-ci.d/buildtest.yml > > > +++ b/.gitlab-ci.d/buildtest.yml > > > @@ -107,6 +107,17 @@ crash-test-debian: > > > - make NINJA=":" check-venv > > > - pyvenv/bin/python3 scripts/device-crash-test -q --tcg-only ./qemu-system-i386 > > > +build-system-rust-debian: > > > + extends: > > > + - .native_build_job_template > > > + - .native_build_artifact_template > > > + needs: > > > + job: amd64-debian-container > > > + variables: > > > + IMAGE: debian > > > + CONFIGURE_ARGS: --enable-rust > > > + TARGETS: aarch64-softmmu > > > + > > > > Do we actually want to do this ? With the updated lcitool containers, > > any of the existing build-system-XXXX jobs ought to be able to detect > > availability of rust and build with it. Re-using existing jobs means > > we burn less CI time. > > > > With regards, > > Daniel > > Hello Daniel, > > I think we do, as long as a rust toolchain is not required to build QEMU by > default. The other jobs could detect availability of Rust but we don't have > a way to check if it works and not fallback to compiling without Rust. > > Could we force enable Rust in one of the existing jobs? Yes, pick any existing job where it works. With regards, Daniel
On Tue, 23 Jul 2024 13:11, "Daniel P. Berrangé" <berrange@redhat.com> wrote: >On Tue, Jul 23, 2024 at 01:06:20PM +0300, Manos Pitsidianakis wrote: >> On Tue, 23 Jul 2024 11:39, "Daniel P. Berrangé" <berrange@redhat.com> wrote: >> > On Mon, Jul 22, 2024 at 02:43:33PM +0300, Manos Pitsidianakis wrote: >> > > Add job that builds with rust support enabled on debian. >> > > >> > > Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> >> > > --- >> > > .gitlab-ci.d/buildtest.yml | 11 +++++++++++ >> > > 1 file changed, 11 insertions(+) >> > > >> > > diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml >> > > index e3a0758bd9..e025e2cbf6 100644 >> > > --- a/.gitlab-ci.d/buildtest.yml >> > > +++ b/.gitlab-ci.d/buildtest.yml >> > > @@ -107,6 +107,17 @@ crash-test-debian: >> > > - make NINJA=":" check-venv >> > > - pyvenv/bin/python3 scripts/device-crash-test -q --tcg-only ./qemu-system-i386 >> > > +build-system-rust-debian: >> > > + extends: >> > > + - .native_build_job_template >> > > + - .native_build_artifact_template >> > > + needs: >> > > + job: amd64-debian-container >> > > + variables: >> > > + IMAGE: debian >> > > + CONFIGURE_ARGS: --enable-rust >> > > + TARGETS: aarch64-softmmu >> > > + >> > >> > Do we actually want to do this ? With the updated lcitool containers, >> > any of the existing build-system-XXXX jobs ought to be able to detect >> > availability of rust and build with it. Re-using existing jobs means >> > we burn less CI time. >> > >> > With regards, >> > Daniel >> >> Hello Daniel, >> >> I think we do, as long as a rust toolchain is not required to build QEMU by >> default. The other jobs could detect availability of Rust but we don't have >> a way to check if it works and not fallback to compiling without Rust. >> >> Could we force enable Rust in one of the existing jobs? > >Yes, pick any existing job where it works. > >With regards, >Daniel OK sounds good, will make the change! Manos
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index e3a0758bd9..e025e2cbf6 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -107,6 +107,17 @@ crash-test-debian: - make NINJA=":" check-venv - pyvenv/bin/python3 scripts/device-crash-test -q --tcg-only ./qemu-system-i386 +build-system-rust-debian: + extends: + - .native_build_job_template + - .native_build_artifact_template + needs: + job: amd64-debian-container + variables: + IMAGE: debian + CONFIGURE_ARGS: --enable-rust + TARGETS: aarch64-softmmu + build-system-fedora: extends: - .native_build_job_template
Add job that builds with rust support enabled on debian. Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> --- .gitlab-ci.d/buildtest.yml | 11 +++++++++++ 1 file changed, 11 insertions(+)