From patchwork Fri Jun 30 19:45:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Blake X-Patchwork-Id: 9820295 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 18F3E60224 for ; Fri, 30 Jun 2017 19:46:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0A6E528372 for ; Fri, 30 Jun 2017 19:46:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F0DED2842B; Fri, 30 Jun 2017 19:46:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 68B9128372 for ; Fri, 30 Jun 2017 19:46:31 +0000 (UTC) Received: from localhost ([::1]:45754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dR1s6-0001cA-D8 for patchwork-qemu-devel@patchwork.kernel.org; Fri, 30 Jun 2017 15:46:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dR1rV-0001bE-Te for qemu-devel@nongnu.org; Fri, 30 Jun 2017 15:45:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dR1rV-0005QO-3R for qemu-devel@nongnu.org; Fri, 30 Jun 2017 15:45:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57348) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dR1rQ-0005NW-Iy; Fri, 30 Jun 2017 15:45:48 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A0AFC6AAEB; Fri, 30 Jun 2017 19:45:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A0AFC6AAEB Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=eblake@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A0AFC6AAEB Received: from [10.10.123.78] (ovpn-123-78.rdu2.redhat.com [10.10.123.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC7E4413A; Fri, 30 Jun 2017 19:45:46 +0000 (UTC) To: Max Reitz , qemu-block@nongnu.org References: <20170621133023.27627-1-mreitz@redhat.com> <20170621133023.27627-2-mreitz@redhat.com> <748b90f3-8f89-59ea-4a65-69e938747c0b@redhat.com> <6179c9e2-5486-0ff6-927d-da144c178e93@redhat.com> <7fa30bfe-d1b4-0aeb-b90e-ae91f9467749@redhat.com> From: Eric Blake Openpgp: url=http://people.redhat.com/eblake/eblake.gpg Organization: Red Hat, Inc. Message-ID: Date: Fri, 30 Jun 2017 14:45:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <7fa30bfe-d1b4-0aeb-b90e-ae91f9467749@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 30 Jun 2017 19:45:47 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Qemu-devel] [PATCH v4 1/2] iotests: Use absolute paths for executables X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 06/30/2017 02:41 PM, Eric Blake wrote: > +++ 068.out.bad 2017-06-30 14:35:28.720241398 -0500 > @@ -1,4 +1,5 @@ > QA output created by 068 > +realpath: '': No such file or directory > > The culprit? $QEMU_VXHS_PROG is empty for me, which means `set_prog_path > qnio_server` found nothing to use. You'll have to add in a safety valve > that only calls 'type' if operating on a non-empty path in the first place. I'm using this locally, in the meantime: { Is qnio_server easily available for Fedora? diff --git i/tests/qemu-iotests/common.config w/tests/qemu-iotests/common.config index c1dc425..6f97331 100644 --- i/tests/qemu-iotests/common.config +++ w/tests/qemu-iotests/common.config @@ -107,7 +107,9 @@ export QEMU_PROG=$(realpath -- "$(type -p "$QEMU_PROG")") export QEMU_IMG_PROG=$(realpath -- "$(type -p "$QEMU_IMG_PROG")") export QEMU_IO_PROG=$(realpath -- "$(type -p "$QEMU_IO_PROG")") export QEMU_NBD_PROG=$(realpath -- "$(type -p "$QEMU_NBD_PROG")") -export QEMU_VXHS_PROG=$(realpath -- "$(type -p "$QEMU_VXHS_PROG")") +if [ -n "$QEMU_VXHS_PROG" ]; then + export QEMU_VXHS_PROG=$(realpath -- "$(type -p "$QEMU_VXHS_PROG")") +fi _qemu_wrapper()