From patchwork Wed Jun 22 12:25:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alberto Garcia X-Patchwork-Id: 9192719 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 73DB860756 for ; Wed, 22 Jun 2016 12:54:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 64037283E9 for ; Wed, 22 Jun 2016 12:54:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 55BD328402; Wed, 22 Jun 2016 12:54:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C647F283E9 for ; Wed, 22 Jun 2016 12:54:48 +0000 (UTC) Received: from localhost ([::1]:58044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFhg7-0007AH-R2 for patchwork-qemu-devel@patchwork.kernel.org; Wed, 22 Jun 2016 08:54:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFhEQ-0003k3-2B for qemu-devel@nongnu.org; Wed, 22 Jun 2016 08:26:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFhEH-00024t-D5 for qemu-devel@nongnu.org; Wed, 22 Jun 2016 08:26:09 -0400 Received: from smtp3.mundo-r.com ([212.51.32.191]:50697 helo=smtp4.mundo-r.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFhEH-00023j-0p; Wed, 22 Jun 2016 08:26:01 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2CkAgCmgmpX/5tjdVtUCh0BgyCBU40qmC4BAQEBAQEFAYEPAZExgg+BeoYXAoEsOBQBAQEBAQEBZSeETQIEJ1IQPxI8GxmINAHDCgEBCCeFX4JHhmZ0hQ8FjXhwihWOLYlGhV2PfB42gggcgU9riS0EgUABAQE X-IPAS-Result: A2CkAgCmgmpX/5tjdVtUCh0BgyCBU40qmC4BAQEBAQEFAYEPAZExgg+BeoYXAoEsOBQBAQEBAQEBZSeETQIEJ1IQPxI8GxmINAHDCgEBCCeFX4JHhmZ0hQ8FjXhwihWOLYlGhV2PfB42gggcgU9riS0EgUABAQE X-IronPort-AV: E=Sophos;i="5.26,509,1459807200"; d="scan'208";a="76201875" Received: from fanzine.igalia.com ([91.117.99.155]) by smtp4.mundo-r.com with ESMTP; 22 Jun 2016 14:25:58 +0200 Received: from [194.100.51.2] (helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim) id 1bFhEE-0004kU-Bp; Wed, 22 Jun 2016 14:25:58 +0200 Received: from berto by perseus.local with local (Exim 4.87) (envelope-from ) id 1bFhDo-0007Fl-Jv; Wed, 22 Jun 2016 15:25:32 +0300 From: Alberto Garcia To: qemu-devel@nongnu.org Date: Wed, 22 Jun 2016 15:25:09 +0300 Message-Id: X-Mailer: git-send-email 2.8.1 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 212.51.32.191 Subject: [Qemu-devel] [PATCH v2 12/15] blockjob: Add 'id' parameter to 'block-job-pause' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Jeff Cody , Max Reitz Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP This patch allows the 'block-job-pause' command to identify the job by either its ID or its device name. The latter becomes now optional since the ID alone is enough to identify the job. The HMP 'block_job_pause' command remains unchanged. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- blockdev.c | 7 +++++-- hmp.c | 2 +- qapi/block-core.json | 9 +++++++-- qmp-commands.hx | 2 +- 4 files changed, 14 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index 3a0b22a..348eaef 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3805,10 +3805,13 @@ out: aio_context_release(aio_context); } -void qmp_block_job_pause(const char *device, Error **errp) +void qmp_block_job_pause(bool has_id, const char *id, + bool has_device, const char *device, Error **errp) { AioContext *aio_context; - BlockJob *job = find_block_job(NULL, device, &aio_context, errp); + BlockJob *job = find_block_job(has_id ? id : NULL, + has_device ? device : NULL, + &aio_context, errp); if (!job || job->user_paused) { return; diff --git a/hmp.c b/hmp.c index ed5a125..1f04129 100644 --- a/hmp.c +++ b/hmp.c @@ -1519,7 +1519,7 @@ void hmp_block_job_pause(Monitor *mon, const QDict *qdict) Error *error = NULL; const char *device = qdict_get_str(qdict, "device"); - qmp_block_job_pause(device, &error); + qmp_block_job_pause(false, NULL, true, device, &error); hmp_handle_error(mon, &error); } diff --git a/qapi/block-core.json b/qapi/block-core.json index 38dd3f2..0eaf531 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1537,14 +1537,19 @@ # the operation is actually paused. Cancelling a paused job automatically # resumes it. # -# @device: the device name +# The job must be identified with the @id or @device parameters, but +# only one of them must be set. +# +# @id: #optional the job identifier. (Since 2.7) +# +# @device: #optional the device name # # Returns: Nothing on success # If no background operation is active on this device, DeviceNotActive # # Since: 1.3 ## -{ 'command': 'block-job-pause', 'data': { 'device': 'str' } } +{ 'command': 'block-job-pause', 'data': { '*id': 'str', '*device': 'str' } } ## # @block-job-resume: diff --git a/qmp-commands.hx b/qmp-commands.hx index c7d207a..bd7f749 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -1322,7 +1322,7 @@ EQMP }, { .name = "block-job-pause", - .args_type = "device:B", + .args_type = "id:s?,device:B?", .mhandler.cmd_new = qmp_marshal_block_job_pause, }, {