diff mbox

qemu-web: use https:// to access some external assets

Message ID fe7e4ab1254ac9eb1c6480f1920ed8d2548b4f6c.1501765516.git.jcody@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jeff Cody Aug. 3, 2017, 1:07 p.m. UTC
Now that we are using SSL, most (all?) web browsers will by default
block loading mixed content.  There are two assets that need to be
changed (Google fonts, and jquery).

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 _includes/assets.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Paolo Bonzini Aug. 3, 2017, 1:08 p.m. UTC | #1
On 03/08/2017 15:07, Jeff Cody wrote:
> Now that we are using SSL, most (all?) web browsers will by default
> block loading mixed content.  There are two assets that need to be
> changed (Google fonts, and jquery).
> 
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  _includes/assets.html | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/_includes/assets.html b/_includes/assets.html
> index 3a526a4..826a50f 100644
> --- a/_includes/assets.html
> +++ b/_includes/assets.html
> @@ -2,7 +2,7 @@
>  	<meta name="description" content="" />
>  	<meta name="keywords" content="" />
>  	<meta name="viewport" content="width=device-width">
> -	<link href='http://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
> +	<link href='https://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
>  
>  	<link rel="apple-touch-icon" sizes="180x180" href="/assets/favicons/apple-touch-icon.png">
>  	<link rel="icon" type="image/png" sizes="32x32" href="/assets/favicons/favicon-32x32.png">
> @@ -19,7 +19,7 @@
>  	<link rel="stylesheet" href="/assets/css/style-mobile.css" media="(max-width:699px)"/>
>  	<link rel="stylesheet" href="/assets/css/style-desktop.css" media="(min-width:700px)" />
>  	<link rel="alternate" title="QEMU Blog (Atom feed)" href="/feed.xml" type="application/atom+xml" />
> -	<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
> +	<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
>  	{% if page.colorbox %}
>  	<script src="/assets/js/jquery.colorbox.js"></script>
>  	<link rel="stylesheet" href="/assets/css/colorbox.css" />
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks,

Paolo
Thomas Huth Aug. 3, 2017, 1:17 p.m. UTC | #2
On 03.08.2017 15:07, Jeff Cody wrote:
> Now that we are using SSL, most (all?) web browsers will by default
> block loading mixed content.  There are two assets that need to be
> changed (Google fonts, and jquery).
> 
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  _includes/assets.html | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/_includes/assets.html b/_includes/assets.html
> index 3a526a4..826a50f 100644
> --- a/_includes/assets.html
> +++ b/_includes/assets.html
> @@ -2,7 +2,7 @@
>  	<meta name="description" content="" />
>  	<meta name="keywords" content="" />
>  	<meta name="viewport" content="width=device-width">
> -	<link href='http://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
> +	<link href='https://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
>  
>  	<link rel="apple-touch-icon" sizes="180x180" href="/assets/favicons/apple-touch-icon.png">
>  	<link rel="icon" type="image/png" sizes="32x32" href="/assets/favicons/favicon-32x32.png">
> @@ -19,7 +19,7 @@
>  	<link rel="stylesheet" href="/assets/css/style-mobile.css" media="(max-width:699px)"/>
>  	<link rel="stylesheet" href="/assets/css/style-desktop.css" media="(min-width:700px)" />
>  	<link rel="alternate" title="QEMU Blog (Atom feed)" href="/feed.xml" type="application/atom+xml" />
> -	<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
> +	<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
>  	{% if page.colorbox %}
>  	<script src="/assets/js/jquery.colorbox.js"></script>
>  	<link rel="stylesheet" href="/assets/css/colorbox.css" />
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>
Jeff Cody Aug. 3, 2017, 1:46 p.m. UTC | #3
On Thu, Aug 03, 2017 at 09:07:43AM -0400, Jeff Cody wrote:
> Now that we are using SSL, most (all?) web browsers will by default
> block loading mixed content.  There are two assets that need to be
> changed (Google fonts, and jquery).
> 
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  _includes/assets.html | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/_includes/assets.html b/_includes/assets.html
> index 3a526a4..826a50f 100644
> --- a/_includes/assets.html
> +++ b/_includes/assets.html
> @@ -2,7 +2,7 @@
>  	<meta name="description" content="" />
>  	<meta name="keywords" content="" />
>  	<meta name="viewport" content="width=device-width">
> -	<link href='http://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
> +	<link href='https://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
>  
>  	<link rel="apple-touch-icon" sizes="180x180" href="/assets/favicons/apple-touch-icon.png">
>  	<link rel="icon" type="image/png" sizes="32x32" href="/assets/favicons/favicon-32x32.png">
> @@ -19,7 +19,7 @@
>  	<link rel="stylesheet" href="/assets/css/style-mobile.css" media="(max-width:699px)"/>
>  	<link rel="stylesheet" href="/assets/css/style-desktop.css" media="(min-width:700px)" />
>  	<link rel="alternate" title="QEMU Blog (Atom feed)" href="/feed.xml" type="application/atom+xml" />
> -	<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
> +	<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
>  	{% if page.colorbox %}
>  	<script src="/assets/js/jquery.colorbox.js"></script>
>  	<link rel="stylesheet" href="/assets/css/colorbox.css" />
> -- 
> 2.9.4
>

Thanks for the reviews.  Pushed to git.qemu.org/srv/git/qemu-web.git, and
now live.
diff mbox

Patch

diff --git a/_includes/assets.html b/_includes/assets.html
index 3a526a4..826a50f 100644
--- a/_includes/assets.html
+++ b/_includes/assets.html
@@ -2,7 +2,7 @@ 
 	<meta name="description" content="" />
 	<meta name="keywords" content="" />
 	<meta name="viewport" content="width=device-width">
-	<link href='http://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
+	<link href='https://fonts.googleapis.com/css?family=Roboto+Mono:300,400%7cRoboto:300,400,500' rel='stylesheet' type='text/css'>
 
 	<link rel="apple-touch-icon" sizes="180x180" href="/assets/favicons/apple-touch-icon.png">
 	<link rel="icon" type="image/png" sizes="32x32" href="/assets/favicons/favicon-32x32.png">
@@ -19,7 +19,7 @@ 
 	<link rel="stylesheet" href="/assets/css/style-mobile.css" media="(max-width:699px)"/>
 	<link rel="stylesheet" href="/assets/css/style-desktop.css" media="(min-width:700px)" />
 	<link rel="alternate" title="QEMU Blog (Atom feed)" href="/feed.xml" type="application/atom+xml" />
-	<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
+	<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
 	{% if page.colorbox %}
 	<script src="/assets/js/jquery.colorbox.js"></script>
 	<link rel="stylesheet" href="/assets/css/colorbox.css" />