From patchwork Sat Nov 6 10:23:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?44G36aOO6L+H5peg55eVPz8=?= <787738581@qq.com> X-Patchwork-Id: 12606325 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25C5EC433F5 for ; Sat, 6 Nov 2021 14:36:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 955B660E8B for ; Sat, 6 Nov 2021 14:36:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 955B660E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=qq.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:53396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjMns-0005Vp-OF for qemu-devel@archiver.kernel.org; Sat, 06 Nov 2021 10:36:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <787738581@qq.com>) id 1mjIzZ-0005qQ-BQ for qemu-devel@nongnu.org; Sat, 06 Nov 2021 06:32:10 -0400 Received: from out203-205-221-191.mail.qq.com ([203.205.221.191]:46903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <787738581@qq.com>) id 1mjIzP-0004hv-8p for qemu-devel@nongnu.org; Sat, 06 Nov 2021 06:32:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1636194715; bh=/sq3YdcYfaIk52TD/Idw4Vk+WvxGAOf3QOHj+kJr4BU=; h=From:To:Cc:Subject:Date; b=I13rZRrZMBpv/dUWZQ0Z9uwkUx+x3EexO/mTFAUBiSVca17LFzlFk0SzHvjFZFpgV L4Duez070xscaVy6621qS0EzkDDSDOujUkwoPF5tG3upJyF6XHFXByNe2K3KAvc+Up nq+aysLSOEbsZy2raMbim3zmSHGq7N3LPcvWgRDI= X-QQ-FEAT: oHWrrGTW1dDxccXvLW0dV1NlNqhOmxED X-QQ-SSF: 00000000000000F000000000000000Z X-QQ-XMAILINFO: NCLUWOcZO7FK2EArZEc2BHJJvB1zlkMM1UwgZJkKzp8CLKlstAROCBtGlvAEkp kzvdyQ2bYCxnGz8Cc/bfbPTFve+Ff44Cvj/AdJ4qvIVpt7qZn17Xxh4jx8FJxbQioVByv0GVqFQRb yYJ2eVywEJL5ZlzZOG1PmyYrHqvBo3gh8eQOfb4TB3y1lY0FN8kfaDd2rEUHnoGorMavjoyk29Etq SNe9uk4gDzVhmC24TPOftMmkT/p9xReU7/4H67CkN0abxxPo7qy2Jj3XG+X2KKVzoRufRDII5Dowa 51v3y9GpiKiPCV8Bnls31GSqwktgbXvUrnAEaKyrlkpvUI2diC6uY0dLE+gT1b3sia2qybvnrSSQ/ +b6K11ZnHwMLWxV628s9NiX4ZyJ+oG2g80SIYvSRmVx/xu1jMJbzpb2eVW9tOe+BuTESjU3ZwnwWI yLmh50H36BoPUsyJHdzSruGx595l3dyQrJtSrvkXrx8uq7auWP5rExH5QGpJAlsKHX8w0P/Vvk3Ci +80iYYF7vTXNhA7WbFRSzaX4uQQnMAVW8O1Bn3w6RERbOqDCviebtF3Qfi3QVbmx6v9oIdPVrvdhg wvVEtHkSDjTLY+WSuJ2zSgdljp1Jq38qDZe0u1Z8lwA3MIf2307Ny0bpB/0zZs3oh8LDDe4zm+BSK HEX0X6BwhSDfsWV72jv4iHrdxX8BQht5HOlSGqthPHqvnsMnS9Xs3AG2Mzt7aKHh3+/wznrKdmg+9 cTyAxWFUQ8hjm/CeT31TN8UQ87IEYjNP92/ji7eYqtbkzSOr8+euM34tXxRSWwV1ApLSSVey1HTVs 1toPU/ztYX8kmI8gJbrQNLAM53zV645seA== X-HAS-ATTACH: no X-QQ-BUSINESS-ORIGIN: 2 X-Originating-IP: 111.206.187.191 X-QQ-STYLE: X-QQ-mid: webmail333t1636194218t9024391 From: " =?gb18030?b?pNe357n9zt662z8/?= " <787738581@qq.com> To: " =?gb18030?q?marcandre=2Elureau?= " , " =?gb18030?q?pbonzini?= " Cc: " =?gb18030?q?qemu-devel?= " Subject: Chardev: delete the QemuOpts reserved in vm_config_groups Mime-Version: 1.0 Date: Sat, 6 Nov 2021 18:23:38 +0800 X-Priority: 3 Message-ID: X-QQ-MIME: TCMime 1.0 by Tencent X-Mailer: QQMail 2.x X-QQ-Mailer: QQMail 2.x Received-SPF: pass client-ip=203.205.221.191; envelope-from=787738581@qq.com; helo=out203-205-221-191.mail.qq.com X-Spam_score_int: 43 X-Spam_score: 4.3 X-Spam_bar: ++++ X-Spam_report: (4.3 / 5.0 requ) BAYES_00=-1.9, CHARSET_FARAWAY_HEADER=3.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, HTML_MESSAGE=0.001, NO_FM_NAME_IP_HOSTN=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_TVD_MIME_EPI=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 06 Nov 2021 10:35:18 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" We have found that qemu cannot plug in the previously unplugged device.         start qemu with the following command: ./qemu-system-x86_64 -enable-kvm -m 8192 -smp 16 \    -object memory-backend-file,id=mem,size=8192M,mem-path=/dev/hugepages,share=on \    -numa node,memdev=mem -mem-prealloc \    ...    -chardev socket,id=drive-virtio-disk1,path=/var/run/spdk/vhost_blk_socket-30dcf467-486a-45cf-b754-093bf5cf24d1,reconnect=10 \    -device vhost-user-blk-pci,chardev=drive-virtio-disk1,num-queues=1,bus=pci.0,addr=0x5,id=virtio-disk1 \    ... (qemu) info chardev serial0: filename=pty:/dev/pts/0 drive-virtio-disk1: filename=unix: charmonitor: filename=unix:/usr/local/var/lib/libvirt/qemu/domain-55-e59039db-d576-40db-a/monitor.sock,server (qemu) device_del virtio-disk1 (qemu) chardev-remove drive-virtio-disk1 (qemu) info chardev serial0: filename=pty:/dev/pts/0 charmonitor: filename=unix:/usr/local/var/lib/libvirt/qemu/domain-55-e59039db-d576-40db-a/monitor.sock,server (qemu) chardev-add socket,id=drive-virtio-disk1,path=/var/run/spdk/vhost_blk_socket-30dcf467-486a-45cf-b754-093bf5cf24d1,reconnect=10 device failed: Duplicate ID 'drive-virtio-disk1' for chardev Error: Parsing chardev args failed The root cause of this issue is that the QemuOpts is still reserved in vm_config_groups list, so qemu_opts_create will fail with the error above. So the QemuOpts should be removed when invoking qmp_chardev_remove. Signed-off-by: Zhoujian Yu Reviewed-by: Marc-André Lureau