From patchwork Thu Jun 23 14:51:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Mladek X-Patchwork-Id: 12892817 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE5A4C43334 for ; Thu, 23 Jun 2022 14:52:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232117AbiFWOwM (ORCPT ); Thu, 23 Jun 2022 10:52:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232122AbiFWOwD (ORCPT ); Thu, 23 Jun 2022 10:52:03 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3B4247AC5; Thu, 23 Jun 2022 07:52:01 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 5B68621905; Thu, 23 Jun 2022 14:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1655995920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=uxU0hPXq49CJxI7UlQfc46Bp4k9dn5hDN7DK97QCwZ0=; b=mrQ7L/eHh0puHP36lIAwkc678zgDiclhM7sLpfn+Wb6a9F4rT+euTkMglAYJQYQfj/V4PO NbmkU00fMZNF/KLibynhvasRzYZ93gHRDjvjAk9sfsYyFFE06vuB6LjgtQpZhXfD5hPoKg 19MPqnneyJtJQV8Ups3IelngGBILaCE= Received: from alley.suse.cz (unknown [10.100.208.146]) by relay2.suse.de (Postfix) with ESMTP id 0CE9E2C142; Thu, 23 Jun 2022 14:51:58 +0000 (UTC) From: Petr Mladek To: Linus Torvalds , John Ogness , Sergey Senozhatsky Cc: Andy Shevchenko , =?utf-8?q?Ilpo_J=C3=A4rvine?= =?utf-8?q?n?= , Steven Rostedt , "Jason A . Donenfeld" , Marco Elver , David Laight , Rasmus Villemoes , "Paul E . McKenney" , Zhouyi Zhou , dave@stgolabs.net, Josh Triplett , rcu@vger.kernel.org, frederic@kernel.org, =?utf-8?q?Marek_Beh=C3=BAn?= , linux-kernel@vger.kernel.org Subject: [PATCH 0/6] printk: Revert console kthreads for 5.19 Date: Thu, 23 Jun 2022 16:51:51 +0200 Message-Id: <20220623145157.21938-1-pmladek@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org We have had several discussions with the other printk developers and together decided that we would like more time to investigate the implicit expectations [1] of each and every console driver because now we are concerned that there may be more hidden implicit expectations. We much appreciate the chance to have this in 5.19 release candidates because the wider user base helped us to get feedback from user cases and architectures that we were not able to cover. And we see that the patchset needs some more love. We are sorry for the inconvenience and thanks a lot for the feedback and help with debugging and testing. This patchset reverts only the final patches adding the kthreads and per-console. It keeps the refactoring of the console_unlock() code that makes sense on its own. [1] https://lore.kernel.org/all/YrBdjVwBOVgLfHyb@alley/ PS: I am going to prepare a proper pull request. I just wanted to send this in advance just in case anyone wants to comment on it. Petr Mladek (6): Revert "printk: Wait for the global console lock when the system is going down" Revert "printk: Block console kthreads when direct printing will be required" Revert "printk: remove @console_locked" Revert "printk: extend console_lock for per-console locking" Revert "printk: add kthread console printers" Revert "printk: add functions to prefer direct printing" drivers/tty/sysrq.c | 2 - include/linux/console.h | 17 -- include/linux/printk.h | 16 - kernel/hung_task.c | 11 +- kernel/panic.c | 6 - kernel/printk/internal.h | 2 - kernel/printk/printk.c | 593 ++++-------------------------------- kernel/printk/printk_safe.c | 32 -- kernel/rcu/tree_stall.h | 2 - kernel/reboot.c | 16 +- kernel/watchdog.c | 4 - kernel/watchdog_hld.c | 4 - 12 files changed, 65 insertions(+), 640 deletions(-)