diff mbox series

[1/2] srcu: Fix a misspelling in note

Message ID 20221116015244.10539-1-kernelfans@gmail.com (mailing list archive)
State Accepted
Commit e9b8c98187321fd6e04734649d886e0eb290fe37
Headers show
Series [1/2] srcu: Fix a misspelling in note | expand

Commit Message

Pingfan Liu Nov. 16, 2022, 1:52 a.m. UTC
Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: rcu@vger.kernel.org
---
 include/linux/srcutree.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mukesh Ojha Nov. 16, 2022, 12:43 p.m. UTC | #1
Hi,

On 11/16/2022 7:22 AM, Pingfan Liu wrote:
> Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> Cc: "Paul E. McKenney" <paulmck@kernel.org>
> Cc: Frederic Weisbecker <frederic@kernel.org>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> To: rcu@vger.kernel.org

LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>

-Mukesh

> ---
>   include/linux/srcutree.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/srcutree.h b/include/linux/srcutree.h
> index e3014319d1ad..f52820e88018 100644
> --- a/include/linux/srcutree.h
> +++ b/include/linux/srcutree.h
> @@ -48,7 +48,7 @@ struct srcu_data {
>   struct srcu_node {
>   	spinlock_t __private lock;
>   	unsigned long srcu_have_cbs[4];		/* GP seq for children having CBs, but only */
> -						/*  if greater than ->srcu_gq_seq. */
> +						/*  if greater than ->srcu_gp_seq. */
>   	unsigned long srcu_data_have_cbs[4];	/* Which srcu_data structs have CBs for given GP? */
>   	unsigned long srcu_gp_seq_needed_exp;	/* Furthest future exp GP. */
>   	struct srcu_node *srcu_parent;		/* Next up in tree. */
Frederic Weisbecker Nov. 16, 2022, 1:36 p.m. UTC | #2
On Wed, Nov 16, 2022 at 09:52:43AM +0800, Pingfan Liu wrote:
> Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> Cc: "Paul E. McKenney" <paulmck@kernel.org>
> Cc: Frederic Weisbecker <frederic@kernel.org>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> To: rcu@vger.kernel.org
> ---
>  include/linux/srcutree.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/srcutree.h b/include/linux/srcutree.h
> index e3014319d1ad..f52820e88018 100644
> --- a/include/linux/srcutree.h
> +++ b/include/linux/srcutree.h
> @@ -48,7 +48,7 @@ struct srcu_data {
>  struct srcu_node {
>  	spinlock_t __private lock;
>  	unsigned long srcu_have_cbs[4];		/* GP seq for children having CBs, but only */
> -						/*  if greater than ->srcu_gq_seq. */
> +						/*  if greater than ->srcu_gp_seq. */

Sharp eye ;-)

Reviewed-by: Frederic Weisbecker <frederic@kernel.org>


>  	unsigned long srcu_data_have_cbs[4];	/* Which srcu_data structs have CBs for given GP? */
>  	unsigned long srcu_gp_seq_needed_exp;	/* Furthest future exp GP. */
>  	struct srcu_node *srcu_parent;		/* Next up in tree. */
> -- 
> 2.31.1
>
Paul E. McKenney Nov. 16, 2022, 4:48 p.m. UTC | #3
On Wed, Nov 16, 2022 at 02:36:25PM +0100, Frederic Weisbecker wrote:
> On Wed, Nov 16, 2022 at 09:52:43AM +0800, Pingfan Liu wrote:
> > Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
> > Cc: Lai Jiangshan <jiangshanlai@gmail.com>
> > Cc: "Paul E. McKenney" <paulmck@kernel.org>
> > Cc: Frederic Weisbecker <frederic@kernel.org>
> > Cc: Josh Triplett <josh@joshtriplett.org>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> > To: rcu@vger.kernel.org
> > ---
> >  include/linux/srcutree.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/linux/srcutree.h b/include/linux/srcutree.h
> > index e3014319d1ad..f52820e88018 100644
> > --- a/include/linux/srcutree.h
> > +++ b/include/linux/srcutree.h
> > @@ -48,7 +48,7 @@ struct srcu_data {
> >  struct srcu_node {
> >  	spinlock_t __private lock;
> >  	unsigned long srcu_have_cbs[4];		/* GP seq for children having CBs, but only */
> > -						/*  if greater than ->srcu_gq_seq. */
> > +						/*  if greater than ->srcu_gp_seq. */
> 
> Sharp eye ;-)
> 
> Reviewed-by: Frederic Weisbecker <frederic@kernel.org>

Applied with both Reviewed-by tags, thank you all!

							Thanx, Paul

> >  	unsigned long srcu_data_have_cbs[4];	/* Which srcu_data structs have CBs for given GP? */
> >  	unsigned long srcu_gp_seq_needed_exp;	/* Furthest future exp GP. */
> >  	struct srcu_node *srcu_parent;		/* Next up in tree. */
> > -- 
> > 2.31.1
> >
diff mbox series

Patch

diff --git a/include/linux/srcutree.h b/include/linux/srcutree.h
index e3014319d1ad..f52820e88018 100644
--- a/include/linux/srcutree.h
+++ b/include/linux/srcutree.h
@@ -48,7 +48,7 @@  struct srcu_data {
 struct srcu_node {
 	spinlock_t __private lock;
 	unsigned long srcu_have_cbs[4];		/* GP seq for children having CBs, but only */
-						/*  if greater than ->srcu_gq_seq. */
+						/*  if greater than ->srcu_gp_seq. */
 	unsigned long srcu_data_have_cbs[4];	/* Which srcu_data structs have CBs for given GP? */
 	unsigned long srcu_gp_seq_needed_exp;	/* Furthest future exp GP. */
 	struct srcu_node *srcu_parent;		/* Next up in tree. */