| Message ID | 20230113001132.3375334-15-paulmck@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0335ee6682eddce99d92535c05fc5753f4b7841a |
| Headers | show |
| Series | [v2,01/20] arch/x86: Remove "select SRCU" | expand |
On 1/13/2023 1:11 AM, Paul E. McKenney wrote: > Now that the SRCU Kconfig option is unconditionally selected, there is > no longer any point in conditional compilation based on CONFIG_SRCU. > Therefore, remove the #ifdef. > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> > Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl> > Cc: Borislav Petkov <bp@suse.de> > Cc: Alan Stern <stern@rowland.harvard.edu> > Reviewed-by: John Ogness <john.ogness@linutronix.de> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > kernel/notifier.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/kernel/notifier.c b/kernel/notifier.c > index ab75637fd904f..d353e4b5402d7 100644 > --- a/kernel/notifier.c > +++ b/kernel/notifier.c > @@ -456,7 +456,6 @@ int raw_notifier_call_chain(struct raw_notifier_head *nh, > } > EXPORT_SYMBOL_GPL(raw_notifier_call_chain); > > -#ifdef CONFIG_SRCU > /* > * SRCU notifier chain routines. Registration and unregistration > * use a mutex, and call_chain is synchronized by SRCU (no locks). > @@ -573,8 +572,6 @@ void srcu_init_notifier_head(struct srcu_notifier_head *nh) > } > EXPORT_SYMBOL_GPL(srcu_init_notifier_head); > > -#endif /* CONFIG_SRCU */ > - > static ATOMIC_NOTIFIER_HEAD(die_chain); > > int notrace notify_die(enum die_val val, const char *str,
On Fri, Jan 13, 2023 at 12:25:48PM +0100, Wysocki, Rafael J wrote: > > On 1/13/2023 1:11 AM, Paul E. McKenney wrote: > > Now that the SRCU Kconfig option is unconditionally selected, there is > > no longer any point in conditional compilation based on CONFIG_SRCU. > > Therefore, remove the #ifdef. > > > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org> > > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> > > Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl> > > Cc: Borislav Petkov <bp@suse.de> > > Cc: Alan Stern <stern@rowland.harvard.edu> > > Reviewed-by: John Ogness <john.ogness@linutronix.de> > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Thank you! I will apply both of your acks on my next rebase. Thanx, Paul > > --- > > kernel/notifier.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/kernel/notifier.c b/kernel/notifier.c > > index ab75637fd904f..d353e4b5402d7 100644 > > --- a/kernel/notifier.c > > +++ b/kernel/notifier.c > > @@ -456,7 +456,6 @@ int raw_notifier_call_chain(struct raw_notifier_head *nh, > > } > > EXPORT_SYMBOL_GPL(raw_notifier_call_chain); > > -#ifdef CONFIG_SRCU > > /* > > * SRCU notifier chain routines. Registration and unregistration > > * use a mutex, and call_chain is synchronized by SRCU (no locks). > > @@ -573,8 +572,6 @@ void srcu_init_notifier_head(struct srcu_notifier_head *nh) > > } > > EXPORT_SYMBOL_GPL(srcu_init_notifier_head); > > -#endif /* CONFIG_SRCU */ > > - > > static ATOMIC_NOTIFIER_HEAD(die_chain); > > int notrace notify_die(enum die_val val, const char *str,
diff --git a/kernel/notifier.c b/kernel/notifier.c index ab75637fd904f..d353e4b5402d7 100644 --- a/kernel/notifier.c +++ b/kernel/notifier.c @@ -456,7 +456,6 @@ int raw_notifier_call_chain(struct raw_notifier_head *nh, } EXPORT_SYMBOL_GPL(raw_notifier_call_chain); -#ifdef CONFIG_SRCU /* * SRCU notifier chain routines. Registration and unregistration * use a mutex, and call_chain is synchronized by SRCU (no locks). @@ -573,8 +572,6 @@ void srcu_init_notifier_head(struct srcu_notifier_head *nh) } EXPORT_SYMBOL_GPL(srcu_init_notifier_head); -#endif /* CONFIG_SRCU */ - static ATOMIC_NOTIFIER_HEAD(die_chain); int notrace notify_die(enum die_val val, const char *str,