[v3,2/4] kvm: Remove "select SRCU"

Commit Message

Paul E. McKenney March 24, 2023, 8:52 p.m. UTC

Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it.  Therefore, remove the "select SRCU"
Kconfig statements from the various KVM Kconfig files.

Signed-off-by: Paul E. McKenney <[e-mail]>
Cc: Huacai Chen <[e-mail]>
Cc: Aleksandar Markovic <[e-mail]>
Cc: Thomas Bogendoerfer <[e-mail]>
Cc: Michael Ellerman <[e-mail]>
Cc: Christophe Leroy <[e-mail]>
Cc: Sean Christopherson <[e-mail]>
Cc: Paolo Bonzini <[e-mail]>
Cc: Thomas Gleixner <[e-mail]>
Cc: Ingo Molnar <[e-mail]>
Cc: Borislav Petkov <[e-mail]>
Cc: Dave Hansen <[e-mail]>
Cc: "H. Peter Anvin" <[e-mail]>
Cc: <[e-mail]>
Acked-by: Marc Zyngier <[e-mail]> (arm64)
Acked-by: Michael Ellerman <[e-mail]> (powerpc)
Acked-by: Anup Patel <[e-mail]> (riscv)
Acked-by: Heiko Carstens <[e-mail]> (s390)
Reviewed-by: John Ogness <[e-mail]>
---
 arch/arm64/kvm/Kconfig   | 1 -
 arch/mips/kvm/Kconfig    | 1 -
 arch/powerpc/kvm/Kconfig | 1 -
 arch/riscv/kvm/Kconfig   | 1 -
 arch/s390/kvm/Kconfig    | 1 -
 arch/x86/kvm/Kconfig     | 1 -
 6 files changed, 6 deletions(-)

Comments

Sean Christopherson March 28, 2023, 4:56 a.m. UTC | #1

On Fri, Mar 24, 2023, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it.  Therefore, remove the "select SRCU"
> Kconfig statements from the various KVM Kconfig files.
> 
> Signed-off-by: Paul E. McKenney <[e-mail]>
> Cc: Huacai Chen <[e-mail]>
> Cc: Aleksandar Markovic <[e-mail]>
> Cc: Thomas Bogendoerfer <[e-mail]>
> Cc: Michael Ellerman <[e-mail]>
> Cc: Christophe Leroy <[e-mail]>
> Cc: Sean Christopherson <[e-mail]>
> Cc: Paolo Bonzini <[e-mail]>
> Cc: Thomas Gleixner <[e-mail]>
> Cc: Ingo Molnar <[e-mail]>
> Cc: Borislav Petkov <[e-mail]>
> Cc: Dave Hansen <[e-mail]>
> Cc: "H. Peter Anvin" <[e-mail]>
> Cc: <[e-mail]>
> Acked-by: Marc Zyngier <[e-mail]> (arm64)
> Acked-by: Michael Ellerman <[e-mail]> (powerpc)
> Acked-by: Anup Patel <[e-mail]> (riscv)
> Acked-by: Heiko Carstens <[e-mail]> (s390)
> Reviewed-by: John Ogness <[e-mail]>
> ---

As amusing at it would be to see KVM as the lone holdout,

Acked-by: Sean Christopherson <[e-mail]> (x86)


Paul, feel free to take this through your tree if you think that would be the
fastest way to purge the config.  Holler if you want to route it through KVM, I'll
either throw it kvm-x86/generic, or rewatch Beetlejuice and try to summon Paolo
that way. ;-)

Joel Fernandes March 30, 2023, 3:34 p.m. UTC | #2

On Mon, Mar 27, 2023 at 09:56:02PM -0700, Sean Christopherson wrote:
> On Fri, Mar 24, 2023, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it.  Therefore, remove the "select SRCU"
> > Kconfig statements from the various KVM Kconfig files.
> > 
> > Signed-off-by: Paul E. McKenney <[e-mail]>
> > Cc: Huacai Chen <[e-mail]>
> > Cc: Aleksandar Markovic <[e-mail]>
> > Cc: Thomas Bogendoerfer <[e-mail]>
> > Cc: Michael Ellerman <[e-mail]>
> > Cc: Christophe Leroy <[e-mail]>
> > Cc: Sean Christopherson <[e-mail]>
> > Cc: Paolo Bonzini <[e-mail]>
> > Cc: Thomas Gleixner <[e-mail]>
> > Cc: Ingo Molnar <[e-mail]>
> > Cc: Borislav Petkov <[e-mail]>
> > Cc: Dave Hansen <[e-mail]>
> > Cc: "H. Peter Anvin" <[e-mail]>
> > Cc: <[e-mail]>
> > Acked-by: Marc Zyngier <[e-mail]> (arm64)
> > Acked-by: Michael Ellerman <[e-mail]> (powerpc)
> > Acked-by: Anup Patel <[e-mail]> (riscv)
> > Acked-by: Heiko Carstens <[e-mail]> (s390)
> > Reviewed-by: John Ogness <[e-mail]>
> > ---
> 
> As amusing at it would be to see KVM as the lone holdout,
> 
> Acked-by: Sean Christopherson <[e-mail]> (x86)

Applied the Ack, thank you!

thanks,

 - Joel

Patch

diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig
index ca6eadeb7d1a..f531da6b362e 100644
--- a/arch/arm64/kvm/Kconfig
+++ b/arch/arm64/kvm/Kconfig
@@ -29,7 +29,6 @@  menuconfig KVM
 	select KVM_MMIO
 	select KVM_GENERIC_DIRTYLOG_READ_PROTECT
 	select KVM_XFER_TO_GUEST_WORK
-	select SRCU
 	select KVM_VFIO
 	select HAVE_KVM_EVENTFD
 	select HAVE_KVM_IRQFD
diff --git a/arch/mips/kvm/Kconfig b/arch/mips/kvm/Kconfig
index 29e51649203b..a8cdba75f98d 100644
--- a/arch/mips/kvm/Kconfig
+++ b/arch/mips/kvm/Kconfig
@@ -26,7 +26,6 @@  config KVM
 	select HAVE_KVM_VCPU_ASYNC_IOCTL
 	select KVM_MMIO
 	select MMU_NOTIFIER
-	select SRCU
 	select INTERVAL_TREE
 	select KVM_GENERIC_HARDWARE_ENABLING
 	help
diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index a9f57dad6d91..902611954200 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -22,7 +22,6 @@  config KVM
 	select PREEMPT_NOTIFIERS
 	select HAVE_KVM_EVENTFD
 	select HAVE_KVM_VCPU_ASYNC_IOCTL
-	select SRCU
 	select KVM_VFIO
 	select IRQ_BYPASS_MANAGER
 	select HAVE_KVM_IRQ_BYPASS
diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
index d5a658a047a7..5682d8c017b3 100644
--- a/arch/riscv/kvm/Kconfig
+++ b/arch/riscv/kvm/Kconfig
@@ -28,7 +28,6 @@  config KVM
 	select KVM_XFER_TO_GUEST_WORK
 	select HAVE_KVM_VCPU_ASYNC_IOCTL
 	select HAVE_KVM_EVENTFD
-	select SRCU
 	help
 	  Support hosting virtualized guest machines.
 
diff --git a/arch/s390/kvm/Kconfig b/arch/s390/kvm/Kconfig
index 33f4ff909476..45fdf2a9b2e3 100644
--- a/arch/s390/kvm/Kconfig
+++ b/arch/s390/kvm/Kconfig
@@ -31,7 +31,6 @@  config KVM
 	select HAVE_KVM_IRQ_ROUTING
 	select HAVE_KVM_INVALID_WAKEUPS
 	select HAVE_KVM_NO_POLL
-	select SRCU
 	select KVM_VFIO
 	select INTERVAL_TREE
 	select MMU_NOTIFIER
diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index 8e578311ca9d..89ca7f4c1464 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -46,7 +46,6 @@  config KVM
 	select KVM_XFER_TO_GUEST_WORK
 	select KVM_GENERIC_DIRTYLOG_READ_PROTECT
 	select KVM_VFIO
-	select SRCU
 	select INTERVAL_TREE
 	select HAVE_KVM_PM_NOTIFIER if PM
 	select KVM_GENERIC_HARDWARE_ENABLING