| Message ID | 20230729142738.222208-7-joel@joelfernandes.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 37949a3fa71f82018f8ccb502211e6948ac30fe9 |
| Headers | show |
| Series | None | expand |
On Sat, Jul 29, 2023 at 02:27:36PM +0000, Joel Fernandes (Google) wrote: > The return keyword is not needed here. > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> Odd that this is allowed. ;-) I took 1, 2, and 5, thank you! It would still be good to get Frederic's eyes on 3 and 4. Thanx, Paul > --- > kernel/rcu/tree.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index cb1caefa8bd0..7c79480bfaa0 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c > @@ -2713,7 +2713,7 @@ __call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy_in) > */ > void call_rcu_hurry(struct rcu_head *head, rcu_callback_t func) > { > - return __call_rcu_common(head, func, false); > + __call_rcu_common(head, func, false); > } > EXPORT_SYMBOL_GPL(call_rcu_hurry); > #endif > @@ -2764,7 +2764,7 @@ EXPORT_SYMBOL_GPL(call_rcu_hurry); > */ > void call_rcu(struct rcu_head *head, rcu_callback_t func) > { > - return __call_rcu_common(head, func, IS_ENABLED(CONFIG_RCU_LAZY)); > + __call_rcu_common(head, func, IS_ENABLED(CONFIG_RCU_LAZY)); > } > EXPORT_SYMBOL_GPL(call_rcu); > > -- > 2.41.0.487.g6d72f3e995-goog >
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index cb1caefa8bd0..7c79480bfaa0 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -2713,7 +2713,7 @@ __call_rcu_common(struct rcu_head *head, rcu_callback_t func, bool lazy_in) */ void call_rcu_hurry(struct rcu_head *head, rcu_callback_t func) { - return __call_rcu_common(head, func, false); + __call_rcu_common(head, func, false); } EXPORT_SYMBOL_GPL(call_rcu_hurry); #endif @@ -2764,7 +2764,7 @@ EXPORT_SYMBOL_GPL(call_rcu_hurry); */ void call_rcu(struct rcu_head *head, rcu_callback_t func) { - return __call_rcu_common(head, func, IS_ENABLED(CONFIG_RCU_LAZY)); + __call_rcu_common(head, func, IS_ENABLED(CONFIG_RCU_LAZY)); } EXPORT_SYMBOL_GPL(call_rcu);
The return keyword is not needed here. Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> --- kernel/rcu/tree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)