| Message ID | ZrQ97Zz27Tzmr0Zi@tardis (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [GIT,PULL] LOCKDEP changes for v6.12 | expand |
On Wed, Aug 07, 2024 at 08:39:25PM -0700, Boqun Feng wrote: > Hi Peter & Ingo, > > Per discussion: > > https://lore.kernel.org/lkml/20240802151619.GN39708@noisy.programming.kicks-ass.net/ > > I'm sending a PR with some lockdep changes to tip. > > > The following changes since commit d5934e76316e84eced836b6b2bafae1837d1cd58: > > cleanup: Add usage and style documentation (2024-08-05 16:54:41 +0200) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux tags/lockdep-for-tip.20240806 > Right, so a few things for next time, could you read Documentation/process/maintainer-tip.rst and make sure patches more or less adhere to the things outlined there. Things I noticed in the few seconds I looked at things: Subjects don't start with a capital letter after the ':' The Changelog for the lockdep-vs-rcu thing can be much condensed by not including full stack dumps but only the relevant information. If you don't want to edit patches by hand, you're free to push back and get the submitter to do things before applying them. Anyway, since I'm about to head out to the beach, I'm pulling this. Also I need to figure out how git works with remotes and tags... stupid things :-)
On Thu, Aug 08, 2024 at 12:19:39PM +0200, Peter Zijlstra wrote: > On Wed, Aug 07, 2024 at 08:39:25PM -0700, Boqun Feng wrote: > > Hi Peter & Ingo, > > > > Per discussion: > > > > https://lore.kernel.org/lkml/20240802151619.GN39708@noisy.programming.kicks-ass.net/ > > > > I'm sending a PR with some lockdep changes to tip. > > > > > > The following changes since commit d5934e76316e84eced836b6b2bafae1837d1cd58: > > > > cleanup: Add usage and style documentation (2024-08-05 16:54:41 +0200) > > > > are available in the Git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux tags/lockdep-for-tip.20240806 > > > > Right, so a few things for next time, could you read > Documentation/process/maintainer-tip.rst and make sure patches more or > less adhere to the things outlined there. > My bad! I will definitely do a better job next time. > Things I noticed in the few seconds I looked at things: > > Subjects don't start with a capital letter after the ':' > > The Changelog for the lockdep-vs-rcu thing can be much condensed by not > including full stack dumps but only the relevant information. > > If you don't want to edit patches by hand, you're free to push back and > get the submitter to do things before applying them. > Got it. > Anyway, since I'm about to head out to the beach, I'm pulling this. Also > I need to figure out how git works with remotes and tags... stupid > things :-) > Enjoy the beach ;-) Regards, Boqun
Hi Peter & Ingo, Per discussion: https://lore.kernel.org/lkml/20240802151619.GN39708@noisy.programming.kicks-ass.net/ I'm sending a PR with some lockdep changes to tip. The following changes since commit d5934e76316e84eced836b6b2bafae1837d1cd58: cleanup: Add usage and style documentation (2024-08-05 16:54:41 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux tags/lockdep-for-tip.20240806 for you to fetch changes up to 39dea484e2bb9066abbc01e2c5e03b6917b0b775: locking/lockdep: Simplify character output in seq_line() (2024-08-06 10:46:43 -0700) I've reviewed and tested these changes from my end, but since I don't have a branch tracked by linux-next, so that part of testing is missing. It does pass the 0day build test though. RCU is Cced since I believe patch: lockdep: fix deadlock issue between lockdep and rcu is also queued in the upcoming RCU PR for v6.12. However, since it's a bug fix in lockdep, I feel it makes more sense to go via tip. Worst case, git merge will eventually find the duplicate commit, so not a problem. I'm doing this "sub-maintenance" via a PR, but I'm also OK to send them as patch series, whatever makes your life easier. ;-) Also since this is a sub-maintenance, I plan to stop pusing anything new after -rc2 for a particular release (i.e. anything new after -rc3 will be in a PR from me in the later release), mostly due to lockdep shouldn't have anything urgent (famous last words though), and give you guys more time to prepare the PRs from the tip tree, but again I'm open to any suggestion as well. ---------------------------------------------------------------- Lockdep changes for v6.12: - Fixes a deadlock in lockdep by avoiding calling rcu with the graph lock held. - Uses str_plural() to fix Coccinelle warning. - Uses seq_putc() instead of seq_printf() to print a single character in lockdep proc file. Regards, Boqun ---------------------------------------------------------------- Markus Elfring (1): locking/lockdep: Simplify character output in seq_line() Thorsten Blum (1): lockdep: Use str_plural() to fix Coccinelle warning Zhiguo Niu (1): lockdep: fix deadlock issue between lockdep and rcu kernel/locking/lockdep.c | 50 ++++++++++++++++++++++++++++--------------- kernel/locking/lockdep_proc.c | 2 +- 2 files changed, 34 insertions(+), 18 deletions(-)