mbox series

[v2,00/13] Fix some issues found by flake8

Message ID 20180812202522.3743-1-nicolas.iooss@m4x.org (mailing list archive)
Headers show
Series Fix some issues found by flake8 | expand

Message

Nicolas Iooss Aug. 12, 2018, 8:25 p.m. UTC
Here is the second revision of this patchset. The changes were:

* I removed the buggy code instead of commenting it, in python/sepolgen.
* I fixed a typo in the description of a patch.


Nicolas Iooss (13):
  libselinux: fix flake8 warnings in SWIG-generated code
  python/sepolgen: do not import twice the modules
  python/sepolgen: return NotImplemented instead of raising it
  python/sepolicy: drop unused CheckPolicyType
  python/sepolicy: use lowercase variable name
  python/sepolgen: fix refpolicy parsing of "permissive"
  python/sepolgen: silence linter warning about has_key
  python/sepolgen: remove buggy code
  python/sepolgen: use self when accessing members in FilesystemUse
  python/sepolicy: fix "procotol" misspelling
  python/sepolicy: use variables which exist in the gui.py
  python/sepolicy: do not import sepolicy.generate.DAEMON twice
  python/sepolicy: do not import types

 libselinux/src/selinuxswig_python.i        |  5 +++--
 python/sepolgen/src/sepolgen/interfaces.py |  7 +------
 python/sepolgen/src/sepolgen/refparser.py  |  4 ++--
 python/sepolgen/src/sepolgen/refpolicy.py  |  6 +++---
 python/sepolgen/src/sepolgen/util.py       |  6 +-----
 python/sepolicy/sepolicy.py                | 12 +-----------
 python/sepolicy/sepolicy/generate.py       |  1 -
 python/sepolicy/sepolicy/gui.py            | 12 ++++++------
 8 files changed, 17 insertions(+), 36 deletions(-)

Comments

William Roberts Aug. 13, 2018, 3:21 p.m. UTC | #1
On Sun, Aug 12, 2018 at 1:25 PM, Nicolas Iooss <nicolas.iooss@m4x.org>
wrote:

> Here is the second revision of this patchset. The changes were:
>
> * I removed the buggy code instead of commenting it, in python/sepolgen.
> * I fixed a typo in the description of a patch.
>
>
Ack on the patchset from me.


>
> Nicolas Iooss (13):
>   libselinux: fix flake8 warnings in SWIG-generated code
>   python/sepolgen: do not import twice the modules
>   python/sepolgen: return NotImplemented instead of raising it
>   python/sepolicy: drop unused CheckPolicyType
>   python/sepolicy: use lowercase variable name
>   python/sepolgen: fix refpolicy parsing of "permissive"
>   python/sepolgen: silence linter warning about has_key
>   python/sepolgen: remove buggy code
>   python/sepolgen: use self when accessing members in FilesystemUse
>   python/sepolicy: fix "procotol" misspelling
>   python/sepolicy: use variables which exist in the gui.py
>   python/sepolicy: do not import sepolicy.generate.DAEMON twice
>   python/sepolicy: do not import types
>
>  libselinux/src/selinuxswig_python.i        |  5 +++--
>  python/sepolgen/src/sepolgen/interfaces.py |  7 +------
>  python/sepolgen/src/sepolgen/refparser.py  |  4 ++--
>  python/sepolgen/src/sepolgen/refpolicy.py  |  6 +++---
>  python/sepolgen/src/sepolgen/util.py       |  6 +-----
>  python/sepolicy/sepolicy.py                | 12 +-----------
>  python/sepolicy/sepolicy/generate.py       |  1 -
>  python/sepolicy/sepolicy/gui.py            | 12 ++++++------
>  8 files changed, 17 insertions(+), 36 deletions(-)
>
> --
> 2.18.0
>
> _______________________________________________
> Selinux mailing list
> Selinux@tycho.nsa.gov
> To unsubscribe, send email to Selinux-leave@tycho.nsa.gov.
> To get help, send an email containing "help" to
> Selinux-request@tycho.nsa.gov.
>
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Aug 12, 2018 at 1:25 PM, Nicolas Iooss <span dir="ltr">&lt;<a href="mailto:nicolas.iooss@m4x.org" target="_blank">nicolas.iooss@m4x.org</a>&gt;</span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Here is the second revision of this patchset. The changes were:<br>
<br>
* I removed the buggy code instead of commenting it, in python/sepolgen.<br>
* I fixed a typo in the description of a patch.<br>
<br></blockquote><div><br></div><div>Ack on the patchset from me.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Nicolas Iooss (13):<br>
  libselinux: fix flake8 warnings in SWIG-generated code<br>
  python/sepolgen: do not import twice the modules<br>
  python/sepolgen: return NotImplemented instead of raising it<br>
  python/sepolicy: drop unused CheckPolicyType<br>
  python/sepolicy: use lowercase variable name<br>
  python/sepolgen: fix refpolicy parsing of &quot;permissive&quot;<br>
  python/sepolgen: silence linter warning about has_key<br>
  python/sepolgen: remove buggy code<br>
  python/sepolgen: use self when accessing members in FilesystemUse<br>
  python/sepolicy: fix &quot;procotol&quot; misspelling<br>
  python/sepolicy: use variables which exist in the gui.py<br>
  python/sepolicy: do not import sepolicy.generate.DAEMON twice<br>
  python/sepolicy: do not import types<br>
<br>
 libselinux/src/selinuxswig_<wbr>python.i        |  5 +++--<br>
 python/sepolgen/src/sepolgen/<wbr>interfaces.py |  7 +------<br>
 python/sepolgen/src/sepolgen/<wbr>refparser.py  |  4 ++--<br>
 python/sepolgen/src/sepolgen/<wbr>refpolicy.py  |  6 +++---<br>
 python/sepolgen/src/sepolgen/<wbr>util.py       |  6 +-----<br>
 python/sepolicy/sepolicy.py                | 12 +-----------<br>
 python/sepolicy/sepolicy/<wbr>generate.py       |  1 -<br>
 python/sepolicy/sepolicy/gui.<wbr>py            | 12 ++++++------<br>
 8 files changed, 17 insertions(+), 36 deletions(-)<br>
<span class="HOEnZb"><font color="#888888"><br>
-- <br>
2.18.0<br>
<br>
______________________________<wbr>_________________<br>
Selinux mailing list<br>
<a href="mailto:Selinux@tycho.nsa.gov">Selinux@tycho.nsa.gov</a><br>
To unsubscribe, send email to <a href="mailto:Selinux-leave@tycho.nsa.gov">Selinux-leave@tycho.nsa.gov</a>.<br>
To get help, send an email containing &quot;help&quot; to <a href="mailto:Selinux-request@tycho.nsa.gov">Selinux-request@tycho.nsa.gov</a>.<br>
</font></span></blockquote></div><br></div></div>
Nicolas Iooss Aug. 15, 2018, 8:22 p.m. UTC | #2
On Mon, Aug 13, 2018 at 5:21 PM William Roberts
<bill.c.roberts@gmail.com> wrote:
> On Sun, Aug 12, 2018 at 1:25 PM, Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
>>
>> Here is the second revision of this patchset. The changes were:
>>
>> * I removed the buggy code instead of commenting it, in python/sepolgen.
>> * I fixed a typo in the description of a patch.
>>
>
> Ack on the patchset from me.

Thanks. I applied it.

Nicolas