mbox series

[0/3] Support flake8 version 3.7

Message ID 20190131210753.11221-1-nicolas.iooss@m4x.org (mailing list archive)
Headers show
Series Support flake8 version 3.7 | expand

Message

Nicolas Iooss Jan. 31, 2019, 9:07 p.m. UTC
flake8 3.7.0, 3.7.1, 3.7.2 and 3.7.3 were released on 2019-01-29 and
2019-01-30 (cf. http://flake8.pycqa.org/en/latest/release-notes/3.7.0.html).
These releases introduced new warnings, which broke building with
Travis-CI (cf. https://travis-ci.org/fishilico/selinux/builds/487098420).

Fix Travis-CI's builds by fixing the warnings that are now reported.
The first two commits are related to coding style and the third one is
a fix for an actual bug.


Nicolas Iooss (3):
  python: reindent lines that were over-indented
  python: use == or != when comparing a variable with a string or a
    integer
  python/sepolicy: fix variable name

 python/semanage/semanage                  | 118 ++++++------
 python/sepolgen/src/sepolgen/output.py    |   6 +-
 python/sepolgen/src/sepolgen/refparser.py |   2 +-
 python/sepolgen/src/sepolgen/yacc.py      | 214 +++++++++++-----------
 python/sepolicy/sepolicy/generate.py      |   4 +-
 python/sepolicy/sepolicy/gui.py           |   2 +-
 python/sepolicy/sepolicy/interface.py     |   8 +-
 python/sepolicy/sepolicy/manpage.py       |   4 +-
 8 files changed, 179 insertions(+), 179 deletions(-)

Comments

Petr Lautrbach Feb. 4, 2019, 3:21 p.m. UTC | #1
flake8 3.7.0, 3.7.1, 3.7.2 and 3.7.3 were released on 2019-01-29 and
2019-01-30 (cf. http://flake8.pycqa.org/en/latest/release-notes/3.7.0.html).
These releases introduced new warnings, which broke building with
Travis-CI (cf. https://travis-ci.org/fishilico/selinux/builds/487098420).

Fix Travis-CI's builds by fixing the warnings that are now reported.
The first two commits are related to coding style and the third one is
a fix for an actual bug.


Nicolas Iooss (3):
  python: reindent lines that were over-indented
  python: use == or != when comparing a variable with a string or a
    integer
  python/sepolicy: fix variable name

 python/semanage/semanage                  | 118 ++++++------
 python/sepolgen/src/sepolgen/output.py    |   6 +-
 python/sepolgen/src/sepolgen/refparser.py |   2 +-
 python/sepolgen/src/sepolgen/yacc.py      | 214 +++++++++++-----------
 python/sepolicy/sepolicy/generate.py      |   4 +-
 python/sepolicy/sepolicy/gui.py           |   2 +-
 python/sepolicy/sepolicy/interface.py     |   8 +-
 python/sepolicy/sepolicy/manpage.py       |   4 +-
 8 files changed, 179 insertions(+), 179 deletions(-)



Acked-by: Petr Lautrbach <plautrba@redhat.com>
Nicolas Iooss Feb. 4, 2019, 7:22 p.m. UTC | #2
On Mon, Feb 4, 2019 at 4:21 PM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> flake8 3.7.0, 3.7.1, 3.7.2 and 3.7.3 were released on 2019-01-29 and
> 2019-01-30 (cf. http://flake8.pycqa.org/en/latest/release-notes/3.7.0.html).
> These releases introduced new warnings, which broke building with
> Travis-CI (cf. https://travis-ci.org/fishilico/selinux/builds/487098420).
>
> Fix Travis-CI's builds by fixing the warnings that are now reported.
> The first two commits are related to coding style and the third one is
> a fix for an actual bug.
>
>
> Nicolas Iooss (3):
>   python: reindent lines that were over-indented
>   python: use == or != when comparing a variable with a string or a
>     integer
>   python/sepolicy: fix variable name
>
>  python/semanage/semanage                  | 118 ++++++------
>  python/sepolgen/src/sepolgen/output.py    |   6 +-
>  python/sepolgen/src/sepolgen/refparser.py |   2 +-
>  python/sepolgen/src/sepolgen/yacc.py      | 214 +++++++++++-----------
>  python/sepolicy/sepolicy/generate.py      |   4 +-
>  python/sepolicy/sepolicy/gui.py           |   2 +-
>  python/sepolicy/sepolicy/interface.py     |   8 +-
>  python/sepolicy/sepolicy/manpage.py       |   4 +-
>  8 files changed, 179 insertions(+), 179 deletions(-)
>
>
>
> Acked-by: Petr Lautrbach <plautrba@redhat.com>

Thanks, merged.

Nicolas