| Message ID | 20201116220702.174765-1-jwcart2@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | libsepol/cil: Various CIL cleanups | expand |
On Mon, Nov 16, 2020 at 11:07 PM James Carter <jwcart2@gmail.com> wrote: > > Cleaning up the CIL codebase a bit. No changes to how CIL works. > > James Carter (6): > libsepol/cil: cil_tree_walk() helpers should use CIL_TREE_SKIP_* > libsepol/cil: Git rid of unnecessary check in cil_gen_node() > libsepol/cil: Remove unused field from struct cil_args_resolve > libsepol/cil: Remove unnecessary assignment in > cil_resolve_name_keep_aliases() > libsepol/cil: Use the macro NODE() whenever possible > libspepol/cil: Use the macro FLAVOR() whenever possible > > libsepol/cil/src/cil.c | 2 +- > libsepol/cil/src/cil_binary.c | 12 +++---- > libsepol/cil/src/cil_build_ast.c | 6 ++-- > libsepol/cil/src/cil_find.c | 10 +++--- > libsepol/cil/src/cil_post.c | 2 +- > libsepol/cil/src/cil_resolve_ast.c | 55 +++++++++++++----------------- > libsepol/cil/src/cil_tree.c | 2 +- > 7 files changed, 41 insertions(+), 48 deletions(-) > > -- > 2.25.4 > Hello, The content of these patches look good but there are two misspellings in the commit messages: * Patch 2 : "libsepol/cil: Git rid of unnecessary check in cil_gen_node()" -> "Get" instead of "Git" * Patch 6 : "libspepol/cil: Use the macro FLAVOR() whenever possible" -> "libsepol" With these changes: Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org> Feel free to apply the patches yourself, with the misspellings fixes. Thanks, Nicolas
On Tue, Nov 24, 2020 at 8:25 AM Nicolas Iooss <nicolas.iooss@m4x.org> wrote: > > On Mon, Nov 16, 2020 at 11:07 PM James Carter <jwcart2@gmail.com> wrote: > > > > Cleaning up the CIL codebase a bit. No changes to how CIL works. > > > > James Carter (6): > > libsepol/cil: cil_tree_walk() helpers should use CIL_TREE_SKIP_* > > libsepol/cil: Git rid of unnecessary check in cil_gen_node() > > libsepol/cil: Remove unused field from struct cil_args_resolve > > libsepol/cil: Remove unnecessary assignment in > > cil_resolve_name_keep_aliases() > > libsepol/cil: Use the macro NODE() whenever possible > > libspepol/cil: Use the macro FLAVOR() whenever possible > > > > libsepol/cil/src/cil.c | 2 +- > > libsepol/cil/src/cil_binary.c | 12 +++---- > > libsepol/cil/src/cil_build_ast.c | 6 ++-- > > libsepol/cil/src/cil_find.c | 10 +++--- > > libsepol/cil/src/cil_post.c | 2 +- > > libsepol/cil/src/cil_resolve_ast.c | 55 +++++++++++++----------------- > > libsepol/cil/src/cil_tree.c | 2 +- > > 7 files changed, 41 insertions(+), 48 deletions(-) > > > > -- > > 2.25.4 > > > > Hello, > The content of these patches look good but there are two misspellings > in the commit messages: > > * Patch 2 : "libsepol/cil: Git rid of unnecessary check in > cil_gen_node()" -> "Get" instead of "Git" > * Patch 6 : "libspepol/cil: Use the macro FLAVOR() whenever possible" > -> "libsepol" > > With these changes: > Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org> > > Feel free to apply the patches yourself, with the misspellings fixes. Merged, with the two spelling fixes. Thanks, Nicolas
Cleaning up the CIL codebase a bit. No changes to how CIL works. James Carter (6): libsepol/cil: cil_tree_walk() helpers should use CIL_TREE_SKIP_* libsepol/cil: Git rid of unnecessary check in cil_gen_node() libsepol/cil: Remove unused field from struct cil_args_resolve libsepol/cil: Remove unnecessary assignment in cil_resolve_name_keep_aliases() libsepol/cil: Use the macro NODE() whenever possible libspepol/cil: Use the macro FLAVOR() whenever possible libsepol/cil/src/cil.c | 2 +- libsepol/cil/src/cil_binary.c | 12 +++---- libsepol/cil/src/cil_build_ast.c | 6 ++-- libsepol/cil/src/cil_find.c | 10 +++--- libsepol/cil/src/cil_post.c | 2 +- libsepol/cil/src/cil_resolve_ast.c | 55 +++++++++++++----------------- libsepol/cil/src/cil_tree.c | 2 +- 7 files changed, 41 insertions(+), 48 deletions(-)