From patchwork Tue Nov 17 16:39:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seth Forshee X-Patchwork-Id: 7640041 Return-Path: X-Original-To: patchwork-selinux@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A9442BF90C for ; Tue, 17 Nov 2015 17:23:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D3D962049E for ; Tue, 17 Nov 2015 17:23:32 +0000 (UTC) Received: from emvm-gh1-uea08.nsa.gov (emvm-gh1-uea08.nsa.gov [63.239.67.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7DEE204EC for ; Tue, 17 Nov 2015 17:23:30 +0000 (UTC) X-TM-IMSS-Message-ID: <325752f800055558@nsa.gov> Received: from tarius.tycho.ncsc.mil ([144.51.242.1]) by nsa.gov ([63.239.67.9]) with ESMTP (TREND IMSS SMTP Service 7.1) id 325752f800055558 ; Tue, 17 Nov 2015 12:21:38 -0500 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id tAHHLXIw010200; Tue, 17 Nov 2015 12:21:36 -0500 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id tAHGeMML018628 for ; Tue, 17 Nov 2015 11:40:22 -0500 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id tAHGeCpp005521 for ; Tue, 17 Nov 2015 11:40:22 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A1B5AACOVktWm6vVVdFeGQEBAg8BAQEBhE28R4QNhg8CgVBMAQEBAQEBEgEBAQEBBgsLCSGEYwEBAQMSFRkBATcBDyAxNAEFARwGARIiiAwFngiBMT4xileFVAEFi08BAQEBAQEBAwIBGgYKhDqCEI43jhaIOJY4kWs2gReCZw0WB4F1UwGFCQEBAQ X-IPAS-Result: A1B5AACOVktWm6vVVdFeGQEBAg8BAQEBhE28R4QNhg8CgVBMAQEBAQEBEgEBAQEBBgsLCSGEYwEBAQMSFRkBATcBDyAxNAEFARwGARIiiAwFngiBMT4xileFVAEFi08BAQEBAQEBAwIBGgYKhDqCEI43jhaIOJY4kWs2gReCZw0WB4F1UwGFCQEBAQ X-IronPort-AV: E=Sophos;i="5.20,308,1444708800"; d="scan'208";a="4940870" Received: from emvm-gh1-uea09.nsa.gov ([63.239.67.10]) by goalie.tycho.ncsc.mil with ESMTP; 17 Nov 2015 11:40:10 -0500 X-TM-IMSS-Message-ID: <322a767e000515ff@nsa.gov> Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) by nsa.gov ([63.239.67.10]) with ESMTP (TREND IMSS SMTP Service 7.1; TLSv1/SSLv3 AES128-SHA (128/128)) id 322a767e000515ff ; Tue, 17 Nov 2015 11:41:24 -0500 Received: by igvg19 with SMTP id g19so99527776igv.1 for ; Tue, 17 Nov 2015 08:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2J5/qzveZZ4iSRdgZfp6/6fQf8H3EU+TcJw7M4NG4+c=; b=H6ThVHqykcEZStlvAuleTmyEVzjhvl+XmrQKAiSP2UlEImKH6eHK7KHecVwY1suRLw gSdGYBEUsJCfnvdLaq3jtHSVDoac23eBea+wlOlIoT81pnr77Ug0XDwDhVLBk3eBIvvL GwGR9Ddq+q4UOApXYxLYP/Ah7hT683ikTJ4jwLlcVZ4sXc/7g6KNpFepAHPQARzpXhN7 x6rvFAY5RilMHwG7liipYpJ9180n9Oh3B4qH3j7Pr3G1q15t5xH7xjWeQ4e8p9z/UYtI Sy0ZtvEADM+zjJlrXt7raEpWsDbvzq+yffu4Xqlv9O43WkMdl/frJnl+cf8Gt+6mSADF uydw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2J5/qzveZZ4iSRdgZfp6/6fQf8H3EU+TcJw7M4NG4+c=; b=mt+p22shY3zkfxhDfPkCYgMzQcp47Sriu0GeIhfYJ0W3SHhv3+tRp+T3PBTflOLevq baa+ye9WXEWtcooA564F7i2spnIiEGVRV/wA37mAa3qT8EpCE5H2zLyZM99qCD54pCz8 7vQ0xE4nWqSkGlonagGPLrWrqWEPNAIsXY8l6IOfFvs23J/K0EZE3+mJWrAf4tUOdvHv 8iNjOG1RniTspDnatj7CuE4hbWvDltqa0kKTDleTXVZGIor+aGma1Rh/EvNfjBr0CGTp lS969NlUxfNluT+9eZh1HyPa1ayLkCA0Q/oonNgrAA9/2y8oxQfdzR8yJ8+eMAP9G3Kt GfOQ== X-Gm-Message-State: ALoCoQnfuwQm1Nbo67MUiGA1zX1Htl1JZ+AP+oJvd9LQOiXi8/N4VP+WQWZ43AYpXm5xW4pt7N8N X-Received: by 10.50.150.37 with SMTP id uf5mr3073426igb.10.1447778408667; Tue, 17 Nov 2015 08:40:08 -0800 (PST) Received: from localhost (199-87-125-144.dyn.kc.surewest.net. [199.87.125.144]) by smtp.gmail.com with ESMTPSA id a5sm205074iga.7.2015.11.17.08.40.07 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 17 Nov 2015 08:40:07 -0800 (PST) From: Seth Forshee To: "Eric W. Biederman" , Alexander Viro , Serge Hallyn , James Morris , "Serge E. Hallyn" , Paul Moore , Stephen Smalley , Eric Paris Subject: [PATCH v3 4/7] fs: Treat foreign mounts as nosuid Date: Tue, 17 Nov 2015 10:39:07 -0600 Message-Id: <1447778351-118699-5-git-send-email-seth.forshee@canonical.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1447778351-118699-1-git-send-email-seth.forshee@canonical.com> References: <1447778351-118699-1-git-send-email-seth.forshee@canonical.com> X-TM-AS-MML: disable X-Mailman-Approved-At: Tue, 17 Nov 2015 12:08:00 -0500 X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: Cc: linux-security-module@vger.kernel.org, dm-devel@redhat.com, linux-kernel@vger.kernel.org, Andy Lutomirski , linux-raid@vger.kernel.org, Seth Forshee , linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, selinux@tycho.nsa.gov, linux-fsdevel@vger.kernel.org MIME-Version: 1.0 Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Andy Lutomirski If a process gets access to a mount from a different user namespace, that process should not be able to take advantage of setuid files or selinux entrypoints from that filesystem. Prevent this by treating mounts from other mount namespaces and those not owned by current_user_ns() or an ancestor as nosuid. This will make it safer to allow more complex filesystems to be mounted in non-root user namespaces. This does not remove the need for MNT_LOCK_NOSUID. The setuid, setgid, and file capability bits can no longer be abused if code in a user namespace were to clear nosuid on an untrusted filesystem, but this patch, by itself, is insufficient to protect the system from abuse of files that, when execed, would increase MAC privilege. As a more concrete explanation, any task that can manipulate a vfsmount associated with a given user namespace already has capabilities in that namespace and all of its descendents. If they can cause a malicious setuid, setgid, or file-caps executable to appear in that mount, then that executable will only allow them to elevate privileges in exactly the set of namespaces in which they are already privileges. On the other hand, if they can cause a malicious executable to appear with a dangerous MAC label, running it could change the caller's security context in a way that should not have been possible, even inside the namespace in which the task is confined. As a hardening measure, this would have made CVE-2014-5207 much more difficult to exploit. Signed-off-by: Andy Lutomirski Signed-off-by: Seth Forshee Acked-by: James Morris --- fs/exec.c | 2 +- fs/namespace.c | 13 +++++++++++++ include/linux/mount.h | 1 + security/commoncap.c | 2 +- security/selinux/hooks.c | 2 +- 5 files changed, 17 insertions(+), 3 deletions(-) diff --git a/fs/exec.c b/fs/exec.c index b06623a9347f..ea7311d72cc3 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1295,7 +1295,7 @@ static void bprm_fill_uid(struct linux_binprm *bprm) bprm->cred->euid = current_euid(); bprm->cred->egid = current_egid(); - if (bprm->file->f_path.mnt->mnt_flags & MNT_NOSUID) + if (!mnt_may_suid(bprm->file->f_path.mnt)) return; if (task_no_new_privs(current)) diff --git a/fs/namespace.c b/fs/namespace.c index da70f7c4ece1..2101ce7b96ab 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -3276,6 +3276,19 @@ found: return visible; } +bool mnt_may_suid(struct vfsmount *mnt) +{ + /* + * Foreign mounts (accessed via fchdir or through /proc + * symlinks) are always treated as if they are nosuid. This + * prevents namespaces from trusting potentially unsafe + * suid/sgid bits, file caps, or security labels that originate + * in other namespaces. + */ + return !(mnt->mnt_flags & MNT_NOSUID) && check_mnt(real_mount(mnt)) && + in_userns(current_user_ns(), mnt->mnt_sb->s_user_ns); +} + static struct ns_common *mntns_get(struct task_struct *task) { struct ns_common *ns = NULL; diff --git a/include/linux/mount.h b/include/linux/mount.h index f822c3c11377..54a594d49733 100644 --- a/include/linux/mount.h +++ b/include/linux/mount.h @@ -81,6 +81,7 @@ extern void mntput(struct vfsmount *mnt); extern struct vfsmount *mntget(struct vfsmount *mnt); extern struct vfsmount *mnt_clone_internal(struct path *path); extern int __mnt_is_readonly(struct vfsmount *mnt); +extern bool mnt_may_suid(struct vfsmount *mnt); struct path; extern struct vfsmount *clone_private_mount(struct path *path); diff --git a/security/commoncap.c b/security/commoncap.c index 400aa224b491..6243aef5860e 100644 --- a/security/commoncap.c +++ b/security/commoncap.c @@ -448,7 +448,7 @@ static int get_file_caps(struct linux_binprm *bprm, bool *effective, bool *has_c if (!file_caps_enabled) return 0; - if (bprm->file->f_path.mnt->mnt_flags & MNT_NOSUID) + if (!mnt_may_suid(bprm->file->f_path.mnt)) return 0; if (!in_userns(current_user_ns(), bprm->file->f_path.mnt->mnt_sb->s_user_ns)) return 0; diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index e4369d86e588..de05207eb665 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -2171,7 +2171,7 @@ static int check_nnp_nosuid(const struct linux_binprm *bprm, const struct task_security_struct *new_tsec) { int nnp = (bprm->unsafe & LSM_UNSAFE_NO_NEW_PRIVS); - int nosuid = (bprm->file->f_path.mnt->mnt_flags & MNT_NOSUID); + int nosuid = !mnt_may_suid(bprm->file->f_path.mnt); int rc; if (!nnp && !nosuid)