From patchwork Mon Aug 22 21:03:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gary Tierney X-Patchwork-Id: 9294387 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D2485607FF for ; Mon, 22 Aug 2016 21:03:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C177C28A82 for ; Mon, 22 Aug 2016 21:03:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B632728AA9; Mon, 22 Aug 2016 21:03:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from emsm-gh1-uea11.nsa.gov (emsm-gh1-uea11.nsa.gov [8.44.101.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 16F6F28A82 for ; Mon, 22 Aug 2016 21:03:34 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.28,562,1464652800"; d="scan'208";a="18662342" IronPort-PHdr: =?us-ascii?q?9a23=3A3qBQ1hdEbCDN0psfvPuC/vLqlGMj4u6mDksu8pMi?= =?us-ascii?q?zoh2WeGdxc69Zx7h7PlgxGXEQZ/co6odzbGH6ua7Aydevd7B6ClEK80UEUddyI?= =?us-ascii?q?0/pE8JOIa9E0r1LfrnPWQRPf9pcxtbxUy9KlVfA83kZlff8TWY5D8WHQjjZ0Iu?= =?us-ascii?q?frymUrDbg8n/7e2u4ZqbO1wO32vkJ+goZ0vq5UWJ749N0NMkcv5wgjLy4VJwM9?= =?us-ascii?q?xMwm1pIV/B1z3d3eyXuKBZziJLpvg6/NRBW6ipN44xTLhfESh0ezttvJ6jiAPH?= =?us-ascii?q?BTeryjNcFzxO00kAPw+Q9xz+X5HsogPmp+F932+cJsSwQrcqChq46KI+ZxbymW?= =?us-ascii?q?87NjMj9mzGwph/hbhK5g6gqgZ5zp/8b4SFcvF5e/WOLpshWWNdU5MJBGR6CYSm?= =?us-ascii?q?Yt5KVrIM?= X-IPAS-Result: =?us-ascii?q?A2GJBABgaLtX/wHyM5BdGgEBAQGDJoFSuXkjh21MAQEBAQE?= =?us-ascii?q?BAQIBAlsngjIEAxGCFQIEAQIkExQgDgMJAQEXKQgIAwEtCwoRDgsFGASHdQEDF?= =?us-ascii?q?wSiL5cSAYUWHoYNhxCBTxEBaIUPBY4fiymBZI09iW6FYJA3VIJFgTZvhUWBNgE?= =?us-ascii?q?BAQ?= Received: from unknown (HELO tarius.tycho.ncsc.mil) ([144.51.242.1]) by emsm-gh1-uea11.nsa.gov with ESMTP; 22 Aug 2016 21:03:23 +0000 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u7ML3EiE019978; Mon, 22 Aug 2016 17:03:16 -0400 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id u7ML3DV0107584 for ; Mon, 22 Aug 2016 17:03:13 -0400 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u7ML3CfA019975 for ; Mon, 22 Aug 2016 17:03:12 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A1AkAwAvZ7tXhxMP49RdGgEBAQGEeKRSBJEhhAyGHQKBZ0wBAQEBAQEBAhMBAQEIDQkJGYUOAgEDJ1IQUTwbGYgWAQMboi6XEwGEZQEBCCcehg2HEIJJhQ8Fjh+LKYFkjT2PTpA3gncigTZvhnsBAQE X-IPAS-Result: A1AkAwAvZ7tXhxMP49RdGgEBAQGEeKRSBJEhhAyGHQKBZ0wBAQEBAQEBAhMBAQEIDQkJGYUOAgEDJ1IQUTwbGYgWAQMboi6XEwGEZQEBCCcehg2HEIJJhQ8Fjh+LKYFkjT2PTpA3gncigTZvhnsBAQE X-IronPort-AV: E=Sophos;i="5.28,562,1464667200"; d="scan'208";a="5658915" Received: from emsm-gh1-uea10.corp.nsa.gov (HELO emsm-gh1-uea10.nsa.gov) ([10.208.41.36]) by goalie.tycho.ncsc.mil with ESMTP; 22 Aug 2016 17:03:12 -0400 IronPort-PHdr: =?us-ascii?q?9a23=3AbMVQOxD7HuiVj3Sr+HDNUyQJP3N1i/DPJgcQr6Af?= =?us-ascii?q?oPdwSP7+r8bcNUDSrc9gkEXOFd2CrakV0qyN6eu+BSRAuc/H6yFaNsQUFlcsso?= =?us-ascii?q?Y/p0QYGsmLCEn2frbBThcRO4B8bmJj5GyxKkNPGczzNBX4q3y26iMOSF2kbVIm?= =?us-ascii?q?btr8FoOatcmrzef6o8SVOFQRwmHnKu0uZFXu9EOK55FQ2dMjYo8KiTLx6kNSfO?= =?us-ascii?q?pXwW46bXmypD3bovmKwZh47i5LsOgg/cMTGY/zfqA/UKAKRG9+azN9t4XXskzY?= =?us-ascii?q?QA+O4GYMenkHmRpPRQ7e5Vf1WYminDH9s79S0TOLdfH3QKoyVCXqu6hiUg6ulC?= =?us-ascii?q?YKLTg04UnYj9w2h6Ve9kHy7ydjypLZNdnGfMF1ebnQKIsX?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0HjAgAYaLtXhxMP49RdGwEBAYR4pFIEk?= =?us-ascii?q?SGEDIYdAoFnTAEBAQEBAQECAQIQAQEBCA0JCRkvgjIWghcCAQMnUhBRPBsZiBY?= =?us-ascii?q?BAxuiL5cTAYRlAQEIJx6GDYcQgkmFDwWOH4spgWSNPY9OkDeCdyKBNm+GewEBA?= =?us-ascii?q?Q?= X-IPAS-Result: =?us-ascii?q?A0HjAgAYaLtXhxMP49RdGwEBAYR4pFIEkSGEDIYdAoFnTAE?= =?us-ascii?q?BAQEBAQECAQIQAQEBCA0JCRkvgjIWghcCAQMnUhBRPBsZiBYBAxuiL5cTAYRlA?= =?us-ascii?q?QEIJx6GDYcQgkmFDwWOH4spgWSNPY9OkDeCdyKBNm+GewEBAQ?= X-IronPort-AV: E=Sophos;i="5.28,562,1464652800"; d="scan'208";a="16828354" Received: from mout.gmx.net ([212.227.15.19]) by emsm-gh1-uea10.nsa.gov with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2016 21:03:11 +0000 Received: from home ([79.71.36.116]) by mail.gmx.com (mrgmx002) with ESMTPA (Nemesis) id 0MYOkT-1bfysG38xV-00V7uQ; Mon, 22 Aug 2016 23:03:09 +0200 From: Gary Tierney To: selinux@tycho.nsa.gov Subject: [PATCH v3 1/2] genhomedircon: generate contexts for logins mapped to the default user Date: Mon, 22 Aug 2016 22:03:04 +0100 Message-Id: <1471899785-22194-2-git-send-email-gary.tierney@gmx.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1471899785-22194-1-git-send-email-gary.tierney@gmx.com> References: <1471899785-22194-1-git-send-email-gary.tierney@gmx.com> X-Provags-ID: V03:K0:T0uT+cOsp/yEHTl9B6V7zFIBckqnPr+YK+xeAzhHbvPnFUcp+2Q 1ajst3q6j8WVzxHoPdj1MVGwL+RnE+hh1/n17qNSIzKCccm3JJyAWwFuHGoHTwlkKeLzP4Z k6UkV9UEhLHbFM6fKdyAAk3EbMbNpq6FRKrmH4vmacWNbXgZdWHMYTQ1xsuLdYikMXF2jNT jWBcMaVL0+d2fU3X2oWTg== X-UI-Out-Filterresults: notjunk:1; V01:K0:HK3Jce1FCRY=:QjVohUsOG1QdqxUdAxhW+S eJtd0kqFFFHPZWcwT1aMNsux9M1GdTXWbeaiMC4cyaGsNecCBu4VkPaNEvms8jSfe9h4X18K3 +it4Q7dIjzRU760dYiRqowGtyhT59vEUvBtWXkgrHwWlAu+kjugAbAej+wmIfGKaA/Yci2dZ1 dRazvIKyOYmDMER/nSs7Sr67Ag7z6q7g9rVLu/CxlSAInh/5wNBLm7Ig9BTrSMxIYA2Ncixl1 OFWk5nH55UqOuxM+gAWW0NEOyss01587ShaTEPU25pZfDHCBZfWfyTOwrX3fkwnXvXYre7akK xO+61m6uqVDGkIChaNvy1cByrgZFhd+YS6QDqMtJX4MZQgxzKpvkLpxBwAHHGzqpkR5AqsnHF zozZTHP/DE7OzVym1WWH2azdhxTLlSNhnW9VLeC//Bid0pJLxLHvZTZurwqX10Pp1U8yX6S8D Zq0V34SXMAc3gv96kpnI+FRc04Ko2IAto64ltUJkyCDkfU23RHYnc/mNK142IArkhHBylHgHi GkTmHQOOLtWGmdp42mUdKQn1DnkUNLBh4YZPsEKmvBh3ESivRvIHAuXGT1zhPEJ2X6vjfAUuW jg/FHz0cckHs9PcMCMaL/zZofNatIJnHlh5Gmn3GnVAMzE70P8FHT7G2fIZjEHs1xwj+h4ByZ xW0KWyQyKC6mYXDhOpejT+A8mhuRncgZKVjFwmsHv5O5GxK5PBoOagZPJdnWqTKWCfJgNi/xB 58dBe/qBxdiqT1MGO4WPPS50NIv58FgEk4ZGgv0g+sZKJWQFwf2PM7kFBHU= X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: MIME-Version: 1.0 Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Virus-Scanned: ClamAV using ClamSMTP Removes a test in get_users() which excludes any logins that are explicitly mapped to the default user from file context generation, which results in logins mapped to the fallback user with home directories outside of LU_HOMEDIRECTORY (in the absence of usepasswd=True) having no matching file_contexts.homedirs entries. Signed-off-by: Gary Tierney --- libsemanage/src/genhomedircon.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libsemanage/src/genhomedircon.c b/libsemanage/src/genhomedircon.c index c5ea436..698b907 100644 --- a/libsemanage/src/genhomedircon.c +++ b/libsemanage/src/genhomedircon.c @@ -853,9 +853,6 @@ static genhomedircon_user_entry_t *get_users(genhomedircon_settings_t * s, seuname = semanage_seuser_get_sename(seuser_list[i]); name = semanage_seuser_get_name(seuser_list[i]); - if (strcmp(name,"root") && strcmp(seuname, s->fallback->sename) == 0) - continue; - if (strcmp(name, DEFAULT_LOGIN) == 0) continue;