diff mbox

[v2] selinux: add security in-core xattr support for tracefs

Message ID 1481048370-19930-1-git-send-email-william.c.roberts@intel.com (mailing list archive)
State Superseded
Headers show

Commit Message

Roberts, William C Dec. 6, 2016, 6:19 p.m. UTC 
From: Yongqin Liu <yongqin.liu@linaro.org>

Support setting the security.selinux xattr from userspace
for tracefs. This is required for restorecon/setcon
functionality.

Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
Signed-off-by: William Roberts <william.c.roberts@intel.com>
---
 security/selinux/hooks.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Smalley Dec. 6, 2016, 6:28 p.m. UTC | #1 
On 12/06/2016 01:19 PM, william.c.roberts@intel.com wrote:
> From: Yongqin Liu <yongqin.liu@linaro.org>
> 
> Support setting the security.selinux xattr from userspace
> for tracefs. This is required for restorecon/setcon
> functionality.

Drop "setcon" (not to be confused with setfilecon, but unimportant
regardless).  Maybe add a note along these lines based on the
corresponding policy commit in Android:

    Since kernel 4.1 ftrace is supported as a new separate filesystem. It
    gets automatically mounted by the kernel under the old path
    /sys/kernel/debug/tracing. Because it lives now on a separate filesystem
    SELinux needs to be updated to also support setting SELinux labels
    on tracefs inodes.  This is required for compatibility in Android
    when moving to Linux 4.1 or newer.

> 
> Signed-off-by: Yongqin Liu <yongqin.liu@linaro.org>
> Signed-off-by: William Roberts <william.c.roberts@intel.com>
> ---
>  security/selinux/hooks.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 09fd610..24bd84d 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -491,6 +491,7 @@ static int selinux_is_sblabel_mnt(struct super_block *sb)
>  		!strcmp(sb->s_type->name, "sysfs") ||
>  		!strcmp(sb->s_type->name, "pstore") ||
>  		!strcmp(sb->s_type->name, "debugfs") ||
> +		!strcmp(sb->s_type->name, "tracefs") ||
>  		!strcmp(sb->s_type->name, "rootfs");
>  }
>  
>
diff mbox

Patch

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 09fd610..24bd84d 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -491,6 +491,7 @@  static int selinux_is_sblabel_mnt(struct super_block *sb)
 		!strcmp(sb->s_type->name, "sysfs") ||
 		!strcmp(sb->s_type->name, "pstore") ||
 		!strcmp(sb->s_type->name, "debugfs") ||
+		!strcmp(sb->s_type->name, "tracefs") ||
 		!strcmp(sb->s_type->name, "rootfs");
 }