| Message ID | 1619263085-5047-1-git-send-email-jrdr.linux@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | selinux: Corrected comment to match kernel-doc comment | expand |
On 4/24/21 4:18 AM, Souptick Joarder wrote: > Kernel test robot throws below warning -> > > security/selinux/avc.c:822: warning: This comment starts with '/**', but > isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst > > Updated the comment to align with kernel-doc comment. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > --- > security/selinux/avc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/avc.c b/security/selinux/avc.c > index ad451cf..04a886b 100644 > --- a/security/selinux/avc.c > +++ b/security/selinux/avc.c > @@ -818,7 +818,7 @@ int __init avc_add_callback(int (*callback)(u32 event), u32 events) > return rc; > } > > -/** > +/* > * avc_update_node Update an AVC entry or * avc_update_node - Update an AVC entry would work also. :) And leave the /**. Mostly we want to have kernel-doc for exported (non-static) functions, but this file doesn't exactly conform to that, so the latter fix is more preferable IMO. > * @event : Updating event > * @perms : Permission mask bits >
diff --git a/security/selinux/avc.c b/security/selinux/avc.c index ad451cf..04a886b 100644 --- a/security/selinux/avc.c +++ b/security/selinux/avc.c @@ -818,7 +818,7 @@ int __init avc_add_callback(int (*callback)(u32 event), u32 events) return rc; } -/** +/* * avc_update_node Update an AVC entry * @event : Updating event * @perms : Permission mask bits
Kernel test robot throws below warning -> security/selinux/avc.c:822: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Updated the comment to align with kernel-doc comment. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> --- security/selinux/avc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)