| Message ID | 20170209160242.23405-1-amurdaca@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Feb 9, 2017 at 11:02 AM, Antonio Murdaca <amurdaca@redhat.com> wrote: > From: Antonio Murdaca <runcom@redhat.com> > > This patch allows genfscon per-file labeling for cgroupfs. For instance, > this allows to label the "release_agent" file within each > cgroup mount and limit writes to it. > > Signed-off-by: Antonio Murdaca <amurdaca@redhat.com> > --- > security/selinux/hooks.c | 2 ++ > 1 file changed, 2 insertions(+) This was already merged ... ? * https://marc.info/?l=selinux&m=148652458620202&w=2 > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 9a8f12f..5a3138e 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -808,6 +808,8 @@ static int selinux_set_mnt_opts(struct super_block *sb, > > if (!strcmp(sb->s_type->name, "debugfs") || > !strcmp(sb->s_type->name, "sysfs") || > + !strcmp(sb->s_type->name, "cgroup") || > + !strcmp(sb->s_type->name, "cgroup2") || > !strcmp(sb->s_type->name, "pstore")) > sbsec->flags |= SE_SBGENFS; > > -- > 2.9.3
On Feb 9, 2017 17:14, "Paul Moore" <paul@paul-moore.com> wrote: On Thu, Feb 9, 2017 at 11:02 AM, Antonio Murdaca <amurdaca@redhat.com> wrote: > From: Antonio Murdaca <runcom@redhat.com> > > This patch allows genfscon per-file labeling for cgroupfs. For instance, > this allows to label the "release_agent" file within each > cgroup mount and limit writes to it. > > Signed-off-by: Antonio Murdaca <amurdaca@redhat.com> > --- > security/selinux/hooks.c | 2 ++ > 1 file changed, 2 insertions(+) This was already merged ... ? This is adding cgroup and cgroup2 to the other whitelist (afaict). * https://marc.info/?l=selinux&m=148652458620202&w=2 > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 9a8f12f..5a3138e 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -808,6 +808,8 @@ static int selinux_set_mnt_opts(struct super_block *sb, > > if (!strcmp(sb->s_type->name, "debugfs") || > !strcmp(sb->s_type->name, "sysfs") || > + !strcmp(sb->s_type->name, "cgroup") || > + !strcmp(sb->s_type->name, "cgroup2") || > !strcmp(sb->s_type->name, "pstore")) > sbsec->flags |= SE_SBGENFS; > > -- > 2.9.3 -- paul moore www.paul-moore.com
On Thu, Feb 9, 2017 at 12:39 PM, Antonio Murdaca <amurdaca@redhat.com> wrote: > On Feb 9, 2017 17:14, "Paul Moore" <paul@paul-moore.com> wrote: > On Thu, Feb 9, 2017 at 11:02 AM, Antonio Murdaca <amurdaca@redhat.com> > wrote: >> From: Antonio Murdaca <runcom@redhat.com> >> >> This patch allows genfscon per-file labeling for cgroupfs. For instance, >> this allows to label the "release_agent" file within each >> cgroup mount and limit writes to it. >> >> Signed-off-by: Antonio Murdaca <amurdaca@redhat.com> >> --- >> security/selinux/hooks.c | 2 ++ >> 1 file changed, 2 insertions(+) > > This was already merged ... ? > > > This is adding cgroup and cgroup2 to the other whitelist (afaict). Yes, my apologies, I read this patch too quickly and confused it with the previous cgroups patch. Just to set expectations, this patch is too late for the upcoming merge window, we can consider it in a few weeks once the merge window has closed. This should give you some time to do some further testing (hint, hint).
On Feb 9, 2017 20:23, "Paul Moore" <paul@paul-moore.com> wrote: On Thu, Feb 9, 2017 at 12:39 PM, Antonio Murdaca <amurdaca@redhat.com> wrote: > On Feb 9, 2017 17:14, "Paul Moore" <paul@paul-moore.com> wrote: > On Thu, Feb 9, 2017 at 11:02 AM, Antonio Murdaca <amurdaca@redhat.com> > wrote: >> From: Antonio Murdaca <runcom@redhat.com> >> >> This patch allows genfscon per-file labeling for cgroupfs. For instance, >> this allows to label the "release_agent" file within each >> cgroup mount and limit writes to it. >> >> Signed-off-by: Antonio Murdaca <amurdaca@redhat.com> >> --- >> security/selinux/hooks.c | 2 ++ >> 1 file changed, 2 insertions(+) > > This was already merged ... ? > > > This is adding cgroup and cgroup2 to the other whitelist (afaict). Yes, my apologies, I read this patch too quickly and confused it with the previous cgroups patch. Just to set expectations, this patch is too late for the upcoming merge window, we can consider it in a few weeks once the merge window has closed. This should give you some time to do some further testing (hint, hint). Sure, I'm going to test this and add tests in selinux-testsuite as well -- paul moore www.paul-moore.com
On Thu, Feb 9, 2017 at 5:32 PM, Antonio Murdaca <amurdaca@redhat.com> wrote: > > > On Feb 9, 2017 20:23, "Paul Moore" <paul@paul-moore.com> wrote: > > On Thu, Feb 9, 2017 at 12:39 PM, Antonio Murdaca <amurdaca@redhat.com> > wrote: >> On Feb 9, 2017 17:14, "Paul Moore" <paul@paul-moore.com> wrote: >> On Thu, Feb 9, 2017 at 11:02 AM, Antonio Murdaca <amurdaca@redhat.com> >> wrote: >>> From: Antonio Murdaca <runcom@redhat.com> >>> >>> This patch allows genfscon per-file labeling for cgroupfs. For instance, >>> this allows to label the "release_agent" file within each >>> cgroup mount and limit writes to it. >>> >>> Signed-off-by: Antonio Murdaca <amurdaca@redhat.com> >>> --- >>> security/selinux/hooks.c | 2 ++ >>> 1 file changed, 2 insertions(+) >> >> This was already merged ... ? >> >> >> This is adding cgroup and cgroup2 to the other whitelist (afaict). > > Yes, my apologies, I read this patch too quickly and confused it with > the previous cgroups patch. > > Just to set expectations, this patch is too late for the upcoming > merge window, we can consider it in a few weeks once the merge window > has closed. This should give you some time to do some further testing > (hint, hint). > > > Sure, I'm going to test this and add tests in selinux-testsuite as well Great, thank you.
On 02/09/2017 06:04 PM, Paul Moore wrote: > On Thu, Feb 9, 2017 at 5:32 PM, Antonio Murdaca <amurdaca@redhat.com> wrote: >> >> On Feb 9, 2017 20:23, "Paul Moore" <paul@paul-moore.com> wrote: >> >> On Thu, Feb 9, 2017 at 12:39 PM, Antonio Murdaca <amurdaca@redhat.com> >> wrote: >>> On Feb 9, 2017 17:14, "Paul Moore" <paul@paul-moore.com> wrote: >>> On Thu, Feb 9, 2017 at 11:02 AM, Antonio Murdaca <amurdaca@redhat.com> >>> wrote: >>>> From: Antonio Murdaca <runcom@redhat.com> >>>> >>>> This patch allows genfscon per-file labeling for cgroupfs. For instance, >>>> this allows to label the "release_agent" file within each >>>> cgroup mount and limit writes to it. >>>> >>>> Signed-off-by: Antonio Murdaca <amurdaca@redhat.com> >>>> --- >>>> security/selinux/hooks.c | 2 ++ >>>> 1 file changed, 2 insertions(+) >>> This was already merged ... ? >>> >>> >>> This is adding cgroup and cgroup2 to the other whitelist (afaict). >> Yes, my apologies, I read this patch too quickly and confused it with >> the previous cgroups patch. >> >> Just to set expectations, this patch is too late for the upcoming >> merge window, we can consider it in a few weeks once the merge window >> has closed. This should give you some time to do some further testing >> (hint, hint). >> >> >> Sure, I'm going to test this and add tests in selinux-testsuite as well > Great, thank you. > No problem on waiting for this patch. Stephen asked for this, but this is not something we are currently planning on using with containers.
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 9a8f12f..5a3138e 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -808,6 +808,8 @@ static int selinux_set_mnt_opts(struct super_block *sb, if (!strcmp(sb->s_type->name, "debugfs") || !strcmp(sb->s_type->name, "sysfs") || + !strcmp(sb->s_type->name, "cgroup") || + !strcmp(sb->s_type->name, "cgroup2") || !strcmp(sb->s_type->name, "pstore")) sbsec->flags |= SE_SBGENFS;