From patchwork Wed Sep 13 08:16:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan.Zarsky.jzarsky@redhat.com X-Patchwork-Id: 9953189 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3D9DB6024A for ; Thu, 14 Sep 2017 14:26:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 27DAC29108 for ; Thu, 14 Sep 2017 14:26:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1C60C2910F; Thu, 14 Sep 2017 14:26:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from uhil19pa10.eemsg.mail.mil (uhil19pa10.eemsg.mail.mil [214.24.21.83]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 11EFB29108 for ; Thu, 14 Sep 2017 14:26:24 +0000 (UTC) Received: from emsm-gh1-uea10.ncsc.mil ([214.29.60.2]) by uhil19pa10.eemsg.mail.mil with ESMTP/TLS/AES256-SHA; 14 Sep 2017 14:26:24 +0000 X-IronPort-AV: E=Sophos;i="5.42,393,1500940800"; d="scan'208";a="2142515" Received: from unknown (HELO tarius.tycho.ncsc.mil) ([144.51.242.1]) by EMSM-GH1-UEA10.NCSC.MIL with ESMTP; 14 Sep 2017 14:24:36 +0000 Received: from prometheus.infosec.tycho.ncsc.mil (prometheus [192.168.25.40]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id v8EE8sNG030128; Thu, 14 Sep 2017 10:15:35 -0400 Received: from tarius.tycho.ncsc.mil (tarius.infosec.tycho.ncsc.mil [144.51.242.1]) by prometheus.infosec.tycho.ncsc.mil (8.15.2/8.15.2) with ESMTP id v8D8H0Za085406 for ; Wed, 13 Sep 2017 04:17:00 -0400 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id v8D8H0Jn032251 for ; Wed, 13 Sep 2017 04:17:00 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A1D+AgC16LhZf3IbGNZdHAEBBAEBCgEBg?= =?us-ascii?q?y8oV34njw2PMYJrgXgBjlKHAhOJdFcBAgEBAQEBAhMBAQsWhiOBAoEhiF+BUgO?= =?us-ascii?q?cUZF9OotogyuCAoMzgnOFeIUoAQSRJ49NlEUNi0SHLkiUZ4E5gWR3hScBCwGCS?= =?us-ascii?q?HSKBgEBAQ?= X-IPAS-Result: =?us-ascii?q?A1D+AgC16LhZf3IbGNZdHAEBBAEBCgEBgy8oV34njw2PMYJ?= =?us-ascii?q?rgXgBjlKHAhOJdFcBAgEBAQEBAhMBAQsWhiOBAoEhiF+BUgOcUZF9OotogyuCA?= =?us-ascii?q?oMzgnOFeIUoAQSRJ49NlEUNi0SHLkiUZ4E5gWR3hScBCwGCSHSKBgEBAQ?= X-IronPort-AV: E=Sophos;i="5.42,386,1500955200"; d="scan'208";a="50286" Received: from emsm-gh1-uea10.ncsc.mil ([214.29.60.34]) by goalie.tycho.ncsc.mil with ESMTP; 13 Sep 2017 04:16:59 -0400 IronPort-PHdr: =?us-ascii?q?9a23=3ATOiGVhXpCc0oVe2CFL4UBSW9a+XV8LGtZVwlr6E/?= =?us-ascii?q?grcLSJyIuqrYYxePt8tkgFKBZ4jH8fUM07OQ6PGxHzBcqs7Y+Fk5M7V0Hycfjs?= =?us-ascii?q?sXmwFySOWkMmbcaMDQUiohAc5ZX0Vk9XzoeWJcGcL5ekGA6ibqtW1aFRrwLxd6?= =?us-ascii?q?KfroEYDOkcu3y/qy+5rOaAlUmTaxe71/IRGyoAnLucQbjoRuJrosxhDUvnZGZu?= =?us-ascii?q?NayH9yK1mOhRj8/MCw/JBi8yRUpf0s8tNLXLv5caolU7FWFSwqPG8p6sLlsxnD?= =?us-ascii?q?VhaP6WAHUmoKiBpIAhPK4w/8U5zsryb1rOt92C2dPc3rUbA5XCmp4ql3RBP0ji?= =?us-ascii?q?oMKjk2/XzNhcNtla5VoAihpxt6w4XJZI2YN+ZycqbbcNgHR2ROQ9xRWjRcDI28?= =?us-ascii?q?cYUBAekPMP1Eo4XhvVYCsQeyCRWwCO7p1zRGhmX23ao/0+k5FQ/JxgogFM8Nv3?= =?us-ascii?q?vOttX1L6QSUOCox6nKzDTMdelW2Sz+6InIaR0hu++DUq9wccXL1UkjDR/KjlKV?= =?us-ascii?q?qYH8OT6ey+cDs3CD4uZ+SO6ihHQrpx9+rzS12MshiJPFip8Ixl3L7Sl13po5KN?= =?us-ascii?q?miREJmb9OoDoFcuzyZOoZ4WM8uXWJltSAnwbMco5G7ZjIFyJE/yh7fdfOHd4+I?= =?us-ascii?q?7wrtW+iLPDp2im9pdbaliRuu7EStxffwWdeq31ZPtSpFncPAtnUX2BzS7siLUP?= =?us-ascii?q?59/kal2TqX1gDT7P9LIVwsmKbFNpIszaQ8moQcvEjZACP7ml/6gLKLekgr4uSo?= =?us-ascii?q?7v7oYrTipp+SLY90jQT+P7wsms2+G+s4KBMOX2ub+Omnzr3s41D2QLVQgf0qiK?= =?us-ascii?q?XWrJfaJcEDqq6jHwBVypoj6wq4Dzq+y9QXg30HLFNDeBKagInkIE3OIfDkAve/?= =?us-ascii?q?hFSgijFrx+vcMbH7DZXNKWbDw//deuNm5kpdzhcj5cxO7JJTTLcaKbT8XVGims?= =?us-ascii?q?bfC0obOgr88e/9E9ZsnoEMUHiUAb6xKq7esVaUoOkoJr/fN8cupD/hJq19tLbV?= =?us-ascii?q?hngjlApNJaQ=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AAAwAp6bhZf3IbGNZdHAEBBAEBCgEBF?= =?us-ascii?q?wEBBAEBCgEBgwQoV34njw2PMIJrgXgBjlKHAooHVwEBAQEBAQEBAgESAQELFl2?= =?us-ascii?q?CMwwMAwMBgnSBAoEhiF+BUgOcUZF9OotogyuCAoMzgnOFeIUoBZEnj02URQ2LR?= =?us-ascii?q?IcuSJRngTmBZHeFJwELAYJIdIoGAQEB?= X-IronPort-AV: E=Sophos;i="5.42,386,1500940800"; d="scan'208";a="2074755" Received: from upbd19pa14.eemsg.mail.mil ([214.24.27.114]) by EMSM-GH1-UEA10.NCSC.MIL with ESMTP; 13 Sep 2017 08:16:58 +0000 X-EEMSG-check-005: 0 X-EEMSG-check-006: 000-001;d98eec76-a7e5-4862-b2e7-eb5d1ea8bbbf Authentication-Results: upbd19pa12.eemsg.mail.mil; dkim=neutral (message not signed) header.i=none X-EEMSG-check-008: 79395666|UPBD19PA12_EEMSG_MP12.csd.disa.mil X-EEMSG-SBRS: 3.5 X-EEMSG-ORIG-IP: 209.132.183.28 X-EEMSG-check-002: true X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DYAAB56LhZhxy3hNFdHAEBBAEBCgEBgy8oAVZ+J44ZdI8xgmuBeI5ThGaCHBOJdD8YAQIBAQEBAQEBEwEBAQoLCQgoL4VGgQKBIYhfgVKuTjqLaIMrggKDM4JzhXiFKAEEkSePTZRFDYF7iUmHLAJIlGeBOR+BRXeFJwELAYJIPjaKBgEBAQ X-IPAS-Result: A0DYAAB56LhZhxy3hNFdHAEBBAEBCgEBgy8oAVZ+J44ZdI8xgmuBeI5ThGaCHBOJdD8YAQIBAQEBAQEBEwEBAQoLCQgoL4VGgQKBIYhfgVKuTjqLaIMrggKDM4JzhXiFKAEEkSePTZRFDYF7iUmHLAJIlGeBOR+BRXeFJwELAYJIPjaKBgEBAQ Received: from mx1.redhat.com ([209.132.183.28]) by upbd19pa12.eemsg.mail.mil with ESMTP; 13 Sep 2017 08:16:56 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A22074ACBB for ; Wed, 13 Sep 2017 08:16:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A22074ACBB DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A22074ACBB Received: from dhcp-24-158.brq.redhat.com (unknown [10.43.12.169]) by smtp.corp.redhat.com (Postfix) with ESMTP id 260A65C6D7 for ; Wed, 13 Sep 2017 08:16:51 +0000 (UTC) From: Jan.Zarsky.jzarsky@redhat.com To: selinux@tycho.nsa.gov Date: Wed, 13 Sep 2017 10:16:42 +0200 Message-Id: <20170913081642.7260-1-jzarsky@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 13 Sep 2017 08:16:52 +0000 (UTC) X-Mailman-Approved-At: Thu, 14 Sep 2017 10:08:51 -0400 Subject: [PATCH] libsepol: fix memory leak in sepol_bool_query() X-BeenThere: selinux@tycho.nsa.gov X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: Errors-To: selinux-bounces@tycho.nsa.gov Sender: "Selinux" X-Virus-Scanned: ClamAV using ClamSMTP From: Jan Zarsky When sepol_bool_query() returns NULL response, variable name is not freed. Fix this by calling free() before returning. Signed-off-by: Jan Zarsky --- libsepol/src/booleans.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libsepol/src/booleans.c b/libsepol/src/booleans.c index c914a28..30fcf29 100644 --- a/libsepol/src/booleans.c +++ b/libsepol/src/booleans.c @@ -155,6 +155,7 @@ int sepol_bool_query(sepol_handle_t * handle, booldatum = hashtab_search(policydb->p_bools.table, name); if (!booldatum) { *response = NULL; + free(name); return STATUS_SUCCESS; }