diff mbox series

[selinux.wiki] Mention Signed-off-by in Contributing.md

Message ID 20190529155607.3849-1-plautrba@redhat.com (mailing list archive)
State Changes Requested
Headers show
Series [selinux.wiki] Mention Signed-off-by in Contributing.md | expand

Commit Message

Petr Lautrbach May 29, 2019, 3:56 p.m. UTC
Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
---

Currently Signed-of-by line is not mentioned anywhere.

The same CONTRIBUTING file should be also directly in sources.

 Contributing.md | 1 +
 1 file changed, 1 insertion(+)

Comments

Paul Moore May 29, 2019, 4:07 p.m. UTC | #1
On Wed, May 29, 2019 at 11:56 AM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
> ---
>
> Currently Signed-of-by line is not mentioned anywhere.
>
> The same CONTRIBUTING file should be also directly in sources.
>
>  Contributing.md | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Contributing.md b/Contributing.md
> index 9a798b2..0240e7e 100644
> --- a/Contributing.md
> +++ b/Contributing.md
> @@ -46,6 +46,7 @@ patches, please follow these guidelines:
>  -   Patches should apply with -p1
>  -   Must apply against HEAD of the master branch
>  -   Separate large patches into logical patches
> +-   Patch descriptions must end with your "Signed-off-by" line. This means your code meets the [Developer's certificate of origin](https://developercertificate.org/).

I would suggest explicitly including the DCO in this file in case the
URL goes away or the contents change.

>  When adding new, large features or tools it is best to discuss the
>  design on the mailing list prior to submitting the patch.
> --
> 2.22.0.rc1
diff mbox series

Patch

diff --git a/Contributing.md b/Contributing.md
index 9a798b2..0240e7e 100644
--- a/Contributing.md
+++ b/Contributing.md
@@ -46,6 +46,7 @@  patches, please follow these guidelines:
 -   Patches should apply with -p1
 -   Must apply against HEAD of the master branch
 -   Separate large patches into logical patches
+-   Patch descriptions must end with your "Signed-off-by" line. This means your code meets the [Developer's certificate of origin](https://developercertificate.org/).
 
 When adding new, large features or tools it is best to discuss the
 design on the mailing list prior to submitting the patch.