| Message ID | 20191011070716.198563-1-plautrba@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | libsepol: Use LIBSEPOL_3.0 and fix sepol_policydb_optimize symbol mapping | expand |
On Fri, Oct 11, 2019 at 9:07 AM Petr Lautrbach <plautrba@redhat.com> wrote: > There's a typo in commit b8213acff837101 ("libsepol: add a function to optimize > kernel policy") which added new function sepol_policydb_optimize(), but there's > sepol_optimize_policy in libsepol.map. > > LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0 > > Signed-off-by: Petr Lautrbach <plautrba@redhat.com> Acked-by: Ondrej Mosnacek <omosnace@redhat.com> Thanks for spotting it! > --- > libsepol/src/libsepol.map.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in > index 6358e51f..f4946a79 100644 > --- a/libsepol/src/libsepol.map.in > +++ b/libsepol/src/libsepol.map.in > @@ -60,7 +60,7 @@ LIBSEPOL_1.1 { > sepol_polcap_getname; > } LIBSEPOL_1.0; > > -LIBSEPOL_1.2 { > +LIBSEPOL_3.0 { > global: > - sepol_optimize_policy; > + sepol_policydb_optimize; > } LIBSEPOL_1.1; > -- > 2.23.0 >
On 10/11/19 3:07 AM, Petr Lautrbach wrote: > There's a typo in commit b8213acff837101 ("libsepol: add a function to optimize > kernel policy") which added new function sepol_policydb_optimize(), but there's > sepol_optimize_policy in libsepol.map. > > LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0 > > Signed-off-by: Petr Lautrbach <plautrba@redhat.com> Acked-by: Stephen Smalley <sds@tycho.nsa.gov> > --- > libsepol/src/libsepol.map.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in > index 6358e51f..f4946a79 100644 > --- a/libsepol/src/libsepol.map.in > +++ b/libsepol/src/libsepol.map.in > @@ -60,7 +60,7 @@ LIBSEPOL_1.1 { > sepol_polcap_getname; > } LIBSEPOL_1.0; > > -LIBSEPOL_1.2 { > +LIBSEPOL_3.0 { > global: > - sepol_optimize_policy; > + sepol_policydb_optimize; > } LIBSEPOL_1.1; >
On 10/15/19 10:22 AM, Stephen Smalley wrote: > On 10/11/19 3:07 AM, Petr Lautrbach wrote: >> There's a typo in commit b8213acff837101 ("libsepol: add a function to >> optimize >> kernel policy") which added new function sepol_policydb_optimize(), >> but there's >> sepol_optimize_policy in libsepol.map. >> >> LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0 >> >> Signed-off-by: Petr Lautrbach <plautrba@redhat.com> > > Acked-by: Stephen Smalley <sds@tycho.nsa.gov> Thanks, applied. > >> --- >> libsepol/src/libsepol.map.in | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in >> index 6358e51f..f4946a79 100644 >> --- a/libsepol/src/libsepol.map.in >> +++ b/libsepol/src/libsepol.map.in >> @@ -60,7 +60,7 @@ LIBSEPOL_1.1 { >> sepol_polcap_getname; >> } LIBSEPOL_1.0; >> -LIBSEPOL_1.2 { >> +LIBSEPOL_3.0 { >> global: >> - sepol_optimize_policy; >> + sepol_policydb_optimize; >> } LIBSEPOL_1.1; >> >
diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in index 6358e51f..f4946a79 100644 --- a/libsepol/src/libsepol.map.in +++ b/libsepol/src/libsepol.map.in @@ -60,7 +60,7 @@ LIBSEPOL_1.1 { sepol_polcap_getname; } LIBSEPOL_1.0; -LIBSEPOL_1.2 { +LIBSEPOL_3.0 { global: - sepol_optimize_policy; + sepol_policydb_optimize; } LIBSEPOL_1.1;
There's a typo in commit b8213acff837101 ("libsepol: add a function to optimize kernel policy") which added new function sepol_policydb_optimize(), but there's sepol_optimize_policy in libsepol.map. LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0 Signed-off-by: Petr Lautrbach <plautrba@redhat.com> --- libsepol/src/libsepol.map.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)