[RFC,2/8] selinux-access: log warning on context acquisition failure

Commit Message

Christian Göttsche Dec. 18, 2019, 2:28 p.m. UTC

Relevant when testing in permissive mode, where the function does not return a failure.
This helps to configure a system in permissive mode, without getting surprising failures when switching to enforced mode.
---
 src/core/selinux-access.c | 2 ++
 1 file changed, 2 insertions(+)

Patch

diff --git a/src/core/selinux-access.c b/src/core/selinux-access.c
index 9fd3099fea..4500e4452f 100644
--- a/src/core/selinux-access.c
+++ b/src/core/selinux-access.c
@@ -223,6 +223,7 @@  int mac_selinux_generic_access_check(
 
                 r = getfilecon_raw(path, &fcon);
                 if (r < 0) {
+                        log_warning_errno(errno, "SELinux getfilecon_raw on '%s' failed: %m (tclass=%s perm=%s)", path, tclass, permission);
                         r = sd_bus_error_setf(error, SD_BUS_ERROR_ACCESS_DENIED, "Failed to get file context on %s.", path);
                         goto finish;
                 }
@@ -231,6 +232,7 @@  int mac_selinux_generic_access_check(
         } else {
                 r = getcon_raw(&fcon);
                 if (r < 0) {
+                        log_warning_errno(errno, "SELinux getcon_raw failed: %m (tclass=%s perm=%s)", tclass, permission);
                         r = sd_bus_error_setf(error, SD_BUS_ERROR_ACCESS_DENIED, "Failed to get current context.");
                         goto finish;
                 }