| Message ID | 20200202014624.75356-1-hridya@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | selinux: Fix typo in filesystem name | expand |
On 2/1/20 8:46 PM, Hridya Valsaraju wrote: > Correct the filesystem name to "binder" to enable > genfscon per-file labelling for binderfs. > > Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs") > Signed-off-by: Hridya Valsaraju <hridya@google.com> Acked-by: Stephen Smalley <sds@tycho.nsa.gov> > --- > > Hello, > > I seem to have made the typo/mistake during a rebase. Sorry about that > :( > > Thanks, > Hridya > > security/selinux/hooks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 89fe3a805129..d67a80b0d8a8 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb, > > if (!strcmp(sb->s_type->name, "debugfs") || > !strcmp(sb->s_type->name, "tracefs") || > - !strcmp(sb->s_type->name, "binderfs") || > + !strcmp(sb->s_type->name, "binder") || > !strcmp(sb->s_type->name, "pstore")) > sbsec->flags |= SE_SBGENFS; > >
On Sat, Feb 1, 2020 at 8:46 PM Hridya Valsaraju <hridya@google.com> wrote: > > Correct the filesystem name to "binder" to enable > genfscon per-file labelling for binderfs. > > Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs") > Signed-off-by: Hridya Valsaraju <hridya@google.com> > --- > > Hello, > > I seem to have made the typo/mistake during a rebase. Sorry about that > :( > > Thanks, > Hridya > > security/selinux/hooks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Ooops :/ Thanks for the fix. I've merged this into selinux/stable-5.6, but due to some personal scheduling issues on my end I'm going to refrain from sending this to Linus until next week. > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index 89fe3a805129..d67a80b0d8a8 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb, > > if (!strcmp(sb->s_type->name, "debugfs") || > !strcmp(sb->s_type->name, "tracefs") || > - !strcmp(sb->s_type->name, "binderfs") || > + !strcmp(sb->s_type->name, "binder") || > !strcmp(sb->s_type->name, "pstore")) > sbsec->flags |= SE_SBGENFS; > > -- > 2.25.0.341.g760bfbb309-goog
On Wed, Feb 5, 2020 at 3:28 PM Paul Moore <paul@paul-moore.com> wrote: > > On Sat, Feb 1, 2020 at 8:46 PM Hridya Valsaraju <hridya@google.com> wrote: > > > > Correct the filesystem name to "binder" to enable > > genfscon per-file labelling for binderfs. > > > > Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs") > > Signed-off-by: Hridya Valsaraju <hridya@google.com> > > --- > > > > Hello, > > > > I seem to have made the typo/mistake during a rebase. Sorry about that > > :( > > > > Thanks, > > Hridya > > > > security/selinux/hooks.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Ooops :/ > > Thanks for the fix. I've merged this into selinux/stable-5.6, but due > to some personal scheduling issues on my end I'm going to refrain from > sending this to Linus until next week. Thank you Paul and Stephen! Regards, Hridya > > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > > index 89fe3a805129..d67a80b0d8a8 100644 > > --- a/security/selinux/hooks.c > > +++ b/security/selinux/hooks.c > > @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb, > > > > if (!strcmp(sb->s_type->name, "debugfs") || > > !strcmp(sb->s_type->name, "tracefs") || > > - !strcmp(sb->s_type->name, "binderfs") || > > + !strcmp(sb->s_type->name, "binder") || > > !strcmp(sb->s_type->name, "pstore")) > > sbsec->flags |= SE_SBGENFS; > > > > -- > > 2.25.0.341.g760bfbb309-goog > > -- > paul moore > www.paul-moore.com
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 89fe3a805129..d67a80b0d8a8 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb, if (!strcmp(sb->s_type->name, "debugfs") || !strcmp(sb->s_type->name, "tracefs") || - !strcmp(sb->s_type->name, "binderfs") || + !strcmp(sb->s_type->name, "binder") || !strcmp(sb->s_type->name, "pstore")) sbsec->flags |= SE_SBGENFS;
Correct the filesystem name to "binder" to enable genfscon per-file labelling for binderfs. Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs") Signed-off-by: Hridya Valsaraju <hridya@google.com> --- Hello, I seem to have made the typo/mistake during a rebase. Sorry about that :( Thanks, Hridya security/selinux/hooks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)