diff mbox series

[2/2] Travis-CI: test that DEBUG build works

Message ID 20200206131901.535779-3-omosnace@redhat.com (mailing list archive)
State Accepted
Headers show
Series userspace: Fix DEBUG=1 build | expand

Commit Message

Ondrej Mosnacek Feb. 6, 2020, 1:19 p.m. UTC 
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
---
 .travis.yml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Stephen Smalley Feb. 7, 2020, 9:27 p.m. UTC | #1 
On 2/6/20 8:19 AM, Ondrej Mosnacek wrote:
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>

Acked-by: Stephen Smalley <sds@tycho.nsa.gov>

> ---
>   .travis.yml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index e9f86baa..918958ac 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -13,6 +13,7 @@ env:
>       # Test the last version of Python and Ruby together, with some linkers
>       - PYVER=python3.7 RUBYLIBVER=2.6
>       - PYVER=python3.7 RUBYLIBVER=2.6 TEST_FLAGS_OVERRIDE=1
> +    - PYVER=python3.7 RUBYLIBVER=2.6 TEST_DEBUG=1
>       - PYVER=python3.7 RUBYLIBVER=2.6 LINKER=gold
>       - PYVER=python3.7 RUBYLIBVER=2.6 LINKER=bfd
>   
> @@ -116,6 +117,8 @@ before_script:
>   
>     # If TEST_FLAGS_OVERRIDE is defined, test that overriding CFLAGS, LDFLAGS and other variables works fine
>     - if [ -n "$TEST_FLAGS_OVERRIDE" ]; then EXPLICIT_MAKE_VARS="CFLAGS=-I$DESTDIR/usr/include LDFLAGS=-L$DESTDIR/usr/lib LDLIBS= CPPFLAGS=" ; fi
> +  # If TEST_DEBUG is defined, test that debug build works fine
> +  - if [ -n "$TEST_DEBUG" ]; then EXPLICIT_MAKE_VARS="$EXPLICIT_MAKE_VARS DEBUG=1" ; fi
>   
>   script:
>     # Start by installing everything into $DESTDIR
>
Stephen Smalley Feb. 10, 2020, 2:36 p.m. UTC | #2 
On 2/7/20 4:27 PM, Stephen Smalley wrote:
> On 2/6/20 8:19 AM, Ondrej Mosnacek wrote:
>> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
> 
> Acked-by: Stephen Smalley <sds@tycho.nsa.gov>

Both patches applied.
diff mbox series

Patch

diff --git a/.travis.yml b/.travis.yml
index e9f86baa..918958ac 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -13,6 +13,7 @@  env:
     # Test the last version of Python and Ruby together, with some linkers
     - PYVER=python3.7 RUBYLIBVER=2.6
     - PYVER=python3.7 RUBYLIBVER=2.6 TEST_FLAGS_OVERRIDE=1
+    - PYVER=python3.7 RUBYLIBVER=2.6 TEST_DEBUG=1
     - PYVER=python3.7 RUBYLIBVER=2.6 LINKER=gold
     - PYVER=python3.7 RUBYLIBVER=2.6 LINKER=bfd
 
@@ -116,6 +117,8 @@  before_script:
 
   # If TEST_FLAGS_OVERRIDE is defined, test that overriding CFLAGS, LDFLAGS and other variables works fine
   - if [ -n "$TEST_FLAGS_OVERRIDE" ]; then EXPLICIT_MAKE_VARS="CFLAGS=-I$DESTDIR/usr/include LDFLAGS=-L$DESTDIR/usr/lib LDLIBS= CPPFLAGS=" ; fi
+  # If TEST_DEBUG is defined, test that debug build works fine
+  - if [ -n "$TEST_DEBUG" ]; then EXPLICIT_MAKE_VARS="$EXPLICIT_MAKE_VARS DEBUG=1" ; fi
 
 script:
   # Start by installing everything into $DESTDIR