| Message ID | 20200419135852.85888-1-nicolas.iooss@m4x.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] libselinux/utils: remove unneeded variable in Makefile | expand |
> -----Original Message----- > From: selinux-owner@vger.kernel.org [mailto:selinux-owner@vger.kernel.org] > On Behalf Of Nicolas Iooss > Sent: Sunday, April 19, 2020 8:59 AM > To: selinux@vger.kernel.org > Subject: [PATCH 1/1] libselinux/utils: remove unneeded variable in Makefile > > LD_SONAME_FLAGS is not used when building libselinux utils. > > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> > --- > libselinux/utils/Makefile | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libselinux/utils/Makefile b/libselinux/utils/Makefile index > a5632b7c38ec..b018a08acbe0 100644 > --- a/libselinux/utils/Makefile > +++ b/libselinux/utils/Makefile > @@ -36,8 +36,6 @@ CFLAGS ?= -O -Wall -W -Wundef -Wformat-y2k -Wformat- > security -Winit-self -Wmissi > -Werror -Wno-aggregate-return -Wno-redundant-decls -Wstrict- > overflow=5 \ > $(EXTRA_CFLAGS) > > -LD_SONAME_FLAGS=-soname,$(LIBSO),-z,defs,-z,relro > - > ifeq ($(OS), Darwin) > override CFLAGS += -I/opt/local/include -I../../libsepol/include override > LDFLAGS += -L../../libsepol/src -undefined dynamic_lookup > -- > 2.26.0 Acked-by: William Roberts <william.c.roberts@intel.com>
> -----Original Message----- > From: Roberts, William C > Sent: Monday, April 20, 2020 9:26 AM > To: Nicolas Iooss <nicolas.iooss@m4x.org>; selinux@vger.kernel.org > Subject: RE: [PATCH 1/1] libselinux/utils: remove unneeded variable in Makefile > > > -----Original Message----- > > From: selinux-owner@vger.kernel.org > > [mailto:selinux-owner@vger.kernel.org] > > On Behalf Of Nicolas Iooss > > Sent: Sunday, April 19, 2020 8:59 AM > > To: selinux@vger.kernel.org > > Subject: [PATCH 1/1] libselinux/utils: remove unneeded variable in > > Makefile > > > > LD_SONAME_FLAGS is not used when building libselinux utils. > > > > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> > > --- > > libselinux/utils/Makefile | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/libselinux/utils/Makefile b/libselinux/utils/Makefile > > index > > a5632b7c38ec..b018a08acbe0 100644 > > --- a/libselinux/utils/Makefile > > +++ b/libselinux/utils/Makefile > > @@ -36,8 +36,6 @@ CFLAGS ?= -O -Wall -W -Wundef -Wformat-y2k -Wformat- > > security -Winit-self -Wmissi > > -Werror -Wno-aggregate-return -Wno-redundant-decls > > -Wstrict- > > overflow=5 \ > > $(EXTRA_CFLAGS) > > > > -LD_SONAME_FLAGS=-soname,$(LIBSO),-z,defs,-z,relro > > - > > ifeq ($(OS), Darwin) > > override CFLAGS += -I/opt/local/include -I../../libsepol/include > > override LDFLAGS += -L../../libsepol/src -undefined dynamic_lookup > > -- > > 2.26.0 > > Acked-by: William Roberts <william.c.roberts@intel.com> Merged: https://github.com/SELinuxProject/selinux/pull/223
diff --git a/libselinux/utils/Makefile b/libselinux/utils/Makefile index a5632b7c38ec..b018a08acbe0 100644 --- a/libselinux/utils/Makefile +++ b/libselinux/utils/Makefile @@ -36,8 +36,6 @@ CFLAGS ?= -O -Wall -W -Wundef -Wformat-y2k -Wformat-security -Winit-self -Wmissi -Werror -Wno-aggregate-return -Wno-redundant-decls -Wstrict-overflow=5 \ $(EXTRA_CFLAGS) -LD_SONAME_FLAGS=-soname,$(LIBSO),-z,defs,-z,relro - ifeq ($(OS), Darwin) override CFLAGS += -I/opt/local/include -I../../libsepol/include override LDFLAGS += -L../../libsepol/src -undefined dynamic_lookup
LD_SONAME_FLAGS is not used when building libselinux utils. Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> --- libselinux/utils/Makefile | 2 -- 1 file changed, 2 deletions(-)