diff mbox series

[v2,1/2] libsepol/cil: Initialize the multiple_decls field of the cil db

Message ID 20200519142946.76861-1-jwcart2@gmail.com (mailing list archive)
State Superseded
Headers show
Series [v2,1/2] libsepol/cil: Initialize the multiple_decls field of the cil db | expand

Commit Message

James Carter May 19, 2020, 2:29 p.m. UTC
Initialize the multiple_decls field when intializing the structure
cil_db.

Issue reported by: Topi Miettinen <toiwoton@gmail.com>

Fixes: fafe4c212bf6c32c ("libsepol: cil: Add ability to redeclare
       types[attributes]")

Signed-off-by: James Carter <jwcart2@gmail.com>
---
 libsepol/cil/src/cil.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Smalley May 26, 2020, 3:41 p.m. UTC | #1
On Tue, May 19, 2020 at 10:30 AM James Carter <jwcart2@gmail.com> wrote:
>
> Initialize the multiple_decls field when intializing the structure
> cil_db.
>
> Issue reported by: Topi Miettinen <toiwoton@gmail.com>

Conventionally this is just Reported-by: ...

Otherwise,
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>

> Fixes: fafe4c212bf6c32c ("libsepol: cil: Add ability to redeclare
>        types[attributes]")
>
> Signed-off-by: James Carter <jwcart2@gmail.com>
> ---
>  libsepol/cil/src/cil.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/libsepol/cil/src/cil.c b/libsepol/cil/src/cil.c
> index 4a77aa9c..a3c6a293 100644
> --- a/libsepol/cil/src/cil.c
> +++ b/libsepol/cil/src/cil.c
> @@ -459,6 +459,7 @@ void cil_db_init(struct cil_db **db)
>         (*db)->preserve_tunables = CIL_FALSE;
>         (*db)->handle_unknown = -1;
>         (*db)->mls = -1;
> +       (*db)->multiple_decls = CIL_FALSE;
>         (*db)->target_platform = SEPOL_TARGET_SELINUX;
>         (*db)->policy_version = POLICYDB_VERSION_MAX;
>  }
> --
> 2.25.4
>
diff mbox series

Patch

diff --git a/libsepol/cil/src/cil.c b/libsepol/cil/src/cil.c
index 4a77aa9c..a3c6a293 100644
--- a/libsepol/cil/src/cil.c
+++ b/libsepol/cil/src/cil.c
@@ -459,6 +459,7 @@  void cil_db_init(struct cil_db **db)
 	(*db)->preserve_tunables = CIL_FALSE;
 	(*db)->handle_unknown = -1;
 	(*db)->mls = -1;
+	(*db)->multiple_decls = CIL_FALSE;
 	(*db)->target_platform = SEPOL_TARGET_SELINUX;
 	(*db)->policy_version = POLICYDB_VERSION_MAX;
 }