diff mbox series

[2/2] GitHub Actions: drop Ruby 2.4 from matrix

Message ID 20201206225625.3077530-2-nicolas.iooss@m4x.org (mailing list archive)
State Accepted
Headers show
Series [1/2] GitHub Actions: upgrade to Python 3.9 | expand

Commit Message

Nicolas Iooss Dec. 6, 2020, 10:56 p.m. UTC
When migrating to Ubuntu 20.04, Ruby 2.4 is no longer available. As the
migration of "ubuntu-latest" to Ubuntu 20.04 is coming soon, according
to https://github.com/actions/virtual-environments/issues/1816, remove
it now.

Moreover the support of Ruby 2.4 ended a few months ago, so there is no
point at supporting bindings (and testing them) for this version:
https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/

Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
---

I hit this on https://github.com/fishilico/selinux/runs/1507627386?check_suite_focus=true
and the fix is simple.
I would like to keep using ubuntu-latest image in order to benefit from
automatic "LTS upgrade" when they become available. I find it better
than having to update the Ubuntu version by hand (like was done for the
Travis-CI configuration), because maintainers do not have to remember
to update the configuration file for GitHub Actions.

If you prefer using fixed Ubuntu versions (or even several Ubuntu
versions!), the configuration can be modified accordingly.

 .github/workflows/run_tests.yml | 1 -
 1 file changed, 1 deletion(-)

Comments

William Roberts Dec. 7, 2020, 4:42 p.m. UTC | #1
On Sun, Dec 6, 2020 at 4:59 PM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
>
> When migrating to Ubuntu 20.04, Ruby 2.4 is no longer available. As the
> migration of "ubuntu-latest" to Ubuntu 20.04 is coming soon, according
> to https://github.com/actions/virtual-environments/issues/1816, remove
> it now.
>
> Moreover the support of Ruby 2.4 ended a few months ago, so there is no
> point at supporting bindings (and testing them) for this version:
> https://www.ruby-lang.org/en/news/2020/04/05/support-of-ruby-2-4-has-ended/
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
> ---
>
> I hit this on https://github.com/fishilico/selinux/runs/1507627386?check_suite_focus=true
> and the fix is simple.
> I would like to keep using ubuntu-latest image in order to benefit from
> automatic "LTS upgrade" when they become available. I find it better
> than having to update the Ubuntu version by hand (like was done for the
> Travis-CI configuration), because maintainers do not have to remember
> to update the configuration file for GitHub Actions.
>
> If you prefer using fixed Ubuntu versions (or even several Ubuntu
> versions!), the configuration can be modified accordingly.
>
>  .github/workflows/run_tests.yml | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml
> index d889b5d55604..ef4be8afc02f 100644
> --- a/.github/workflows/run_tests.yml
> +++ b/.github/workflows/run_tests.yml
> @@ -24,7 +24,6 @@ jobs:
>            # Test several Ruby versions with the latest Python version
>            - {python: 3.9, ruby: 2.6}
>            - {python: 3.9, ruby: 2.5}
> -          - {python: 3.9, ruby: 2.4}
>          exclude:
>            - compiler: clang
>              python-ruby-version: {python: 3.9, ruby: 2.7, other: linker-bfd}
> --
> 2.29.2
>

ack
diff mbox series

Patch

diff --git a/.github/workflows/run_tests.yml b/.github/workflows/run_tests.yml
index d889b5d55604..ef4be8afc02f 100644
--- a/.github/workflows/run_tests.yml
+++ b/.github/workflows/run_tests.yml
@@ -24,7 +24,6 @@  jobs:
           # Test several Ruby versions with the latest Python version
           - {python: 3.9, ruby: 2.6}
           - {python: 3.9, ruby: 2.5}
-          - {python: 3.9, ruby: 2.4}
         exclude:
           - compiler: clang
             python-ruby-version: {python: 3.9, ruby: 2.7, other: linker-bfd}