diff mbox series

[v3,2/3,NFS] cleanup: remove unneeded null check in nfs_fill_super()

Message ID 20210219222233.20748-2-olga.kornievskaia@gmail.com (mailing list archive)
State Accepted
Delegated to: Paul Moore
Headers show
Series [v3,1/3,security] Add new hook to compare new mount to an existing mount | expand

Commit Message

Olga Kornievskaia Feb. 19, 2021, 10:22 p.m. UTC 
From: Olga Kornievskaia <kolga@netapp.com>

In nfs_fill_super() passed in nfs_fs_context can never be NULL.

Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
 fs/nfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Paul Moore March 22, 2021, 7 p.m. UTC | #1 
On Fri, Feb 19, 2021 at 5:24 PM Olga Kornievskaia
<olga.kornievskaia@gmail.com> wrote:
>
> From: Olga Kornievskaia <kolga@netapp.com>
>
> In nfs_fill_super() passed in nfs_fs_context can never be NULL.
>
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> ---
>  fs/nfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Merged into selinux/next, thanks.
diff mbox series

Patch

diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 4034102010f0..59d846d7830f 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -1026,7 +1026,7 @@  static void nfs_fill_super(struct super_block *sb, struct nfs_fs_context *ctx)
 	sb->s_blocksize = 0;
 	sb->s_xattr = server->nfs_client->cl_nfs_mod->xattr;
 	sb->s_op = server->nfs_client->cl_nfs_mod->sops;
-	if (ctx && ctx->bsize)
+	if (ctx->bsize)
 		sb->s_blocksize = nfs_block_size(ctx->bsize, &sb->s_blocksize_bits);
 
 	if (server->nfs_client->rpc_ops->version != 2) {