| Message ID | 20210422064356.249361-1-nicolas.iooss@m4x.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | libselinux: do not duplicate make target when going into subdirectory | expand |
Nicolas Iooss <nicolas.iooss@m4x.org> writes: > When running "make install-pywrap", make displays: > > make[1]: Entering directory '/root/selinux/libselinux' > make -C src install-pywrap install-pywrap > make[2]: Entering directory '/root/selinux/libselinux/src' > > The duplicated "install-pywrap" is not expected. Remove it from the > Makefile. > > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> Acked-by: Petr Lautrbach <plautrba@redhat.com> Thanks! > --- > libselinux/Makefile | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/libselinux/Makefile b/libselinux/Makefile > index ac16c15e8d0a..439bc6a9b7fd 100644 > --- a/libselinux/Makefile > +++ b/libselinux/Makefile > @@ -50,24 +50,24 @@ all install relabel clean distclean indent: > done > > swigify: all > - $(MAKE) -C src swigify $@ > + $(MAKE) -C src $@ > > pywrap: > - $(MAKE) -C src pywrap $@ > + $(MAKE) -C src $@ > > rubywrap: > - $(MAKE) -C src rubywrap $@ > + $(MAKE) -C src $@ > > install-pywrap: > - $(MAKE) -C src install-pywrap $@ > + $(MAKE) -C src $@ > > install-rubywrap: > - $(MAKE) -C src install-rubywrap $@ > + $(MAKE) -C src $@ > > clean-pywrap: > - $(MAKE) -C src clean-pywrap $@ > + $(MAKE) -C src $@ > > clean-rubywrap: > - $(MAKE) -C src clean-rubywrap $@ > + $(MAKE) -C src $@ > > test: > -- > 2.31.0
On Mon, Apr 26, 2021 at 1:56 PM Petr Lautrbach <plautrba@redhat.com> wrote: > > Nicolas Iooss <nicolas.iooss@m4x.org> writes: > > > When running "make install-pywrap", make displays: > > > > make[1]: Entering directory '/root/selinux/libselinux' > > make -C src install-pywrap install-pywrap > > make[2]: Entering directory '/root/selinux/libselinux/src' > > > > The duplicated "install-pywrap" is not expected. Remove it from the > > Makefile. > > > > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> > > Acked-by: Petr Lautrbach <plautrba@redhat.com> > > Thanks! Applied. Thanks, Nicolas > > --- > > libselinux/Makefile | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/libselinux/Makefile b/libselinux/Makefile > > index ac16c15e8d0a..439bc6a9b7fd 100644 > > --- a/libselinux/Makefile > > +++ b/libselinux/Makefile > > @@ -50,24 +50,24 @@ all install relabel clean distclean indent: > > done > > > > swigify: all > > - $(MAKE) -C src swigify $@ > > + $(MAKE) -C src $@ > > > > pywrap: > > - $(MAKE) -C src pywrap $@ > > + $(MAKE) -C src $@ > > > > rubywrap: > > - $(MAKE) -C src rubywrap $@ > > + $(MAKE) -C src $@ > > > > install-pywrap: > > - $(MAKE) -C src install-pywrap $@ > > + $(MAKE) -C src $@ > > > > install-rubywrap: > > - $(MAKE) -C src install-rubywrap $@ > > + $(MAKE) -C src $@ > > > > clean-pywrap: > > - $(MAKE) -C src clean-pywrap $@ > > + $(MAKE) -C src $@ > > > > clean-rubywrap: > > - $(MAKE) -C src clean-rubywrap $@ > > + $(MAKE) -C src $@ > > > > test: > > -- > > 2.31.0 >
diff --git a/libselinux/Makefile b/libselinux/Makefile index ac16c15e8d0a..439bc6a9b7fd 100644 --- a/libselinux/Makefile +++ b/libselinux/Makefile @@ -50,24 +50,24 @@ all install relabel clean distclean indent: done swigify: all - $(MAKE) -C src swigify $@ + $(MAKE) -C src $@ pywrap: - $(MAKE) -C src pywrap $@ + $(MAKE) -C src $@ rubywrap: - $(MAKE) -C src rubywrap $@ + $(MAKE) -C src $@ install-pywrap: - $(MAKE) -C src install-pywrap $@ + $(MAKE) -C src $@ install-rubywrap: - $(MAKE) -C src install-rubywrap $@ + $(MAKE) -C src $@ clean-pywrap: - $(MAKE) -C src clean-pywrap $@ + $(MAKE) -C src $@ clean-rubywrap: - $(MAKE) -C src clean-rubywrap $@ + $(MAKE) -C src $@ test:
When running "make install-pywrap", make displays: make[1]: Entering directory '/root/selinux/libselinux' make -C src install-pywrap install-pywrap make[2]: Entering directory '/root/selinux/libselinux/src' The duplicated "install-pywrap" is not expected. Remove it from the Makefile. Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org> --- libselinux/Makefile | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)