[14/25] libselinux: setexecfilecon(): drop dead assignment

Message ID	20210503175350.55954-15-cgzones@googlemail.com (mailing list archive)
State	Accepted
Headers	show Return-Path: <selinux-owner@kernel.org> From: =?utf-8?q?Christian_G=C3=B6ttsche?= <cgzones@googlemail.com> To: selinux@vger.kernel.org Subject: [PATCH 14/25] libselinux: setexecfilecon(): drop dead assignment Date: Mon, 3 May 2021 19:53:39 +0200 Message-Id: <20210503175350.55954-15-cgzones@googlemail.com> In-Reply-To: <20210503175350.55954-1-cgzones@googlemail.com> References: <20210503175350.55954-1-cgzones@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	libselinux: misc compiler and static analyzer findings \| expand [00/25] libselinux: misc compiler and static analyzer findings [01/25] libselinux: sidtab_hash(): do not discard const qualifier [02/25] libselinux: selinux_file_context_cmp(): do not discard const qualifier [03/25] libselinux: label_common(): do not discard const qualifier [04/25] libselinux: Sha1Finalise(): do not discard const qualifier [05/25] libselinux: sefcontext_compile: mark local variable static [06/25] libselinux: avcstat: use standard length modifier for unsigned long long [07/25] libselinux: selinux_restorecon: mark local variable static [08/25] libselinux: selabel_get_digests_all_partial_matches: free memory after FTS_D block [09/25] libselinux: getconlist: free memory on multiple level arguments [10/25] libselinux: exclude_non_seclabel_mounts(): drop unused variable [11/25] libselinux: context_new(): drop dead assignment [12/25] libselinux: label_x::init(): drop dead assignment [13/25] libselinux: label_media::init(): drop dead assignment [14/25] libselinux: setexecfilecon(): drop dead assignment [15/25] libselinux: getdefaultcon: free memory on multiple same arguments [16/25] libselinux: store_stem(): do not free possible non-heap object [17/25] libselinux: matchmediacon(): close file on error [18/25] libselinux: init_selinux_config(): free resources on error [19/25] libselinux: label_file::init(): do not pass NULL to strdup [20/25] libselinux: matchpathcon: free memory on realloc failure [21/25] libselinux: label_db::db_init(): open file with CLOEXEC mode [22/25] libselinux: drop redundant casts to the same type [23/25] libselinux: sidtab_sid_stats(): unify parameter name [24/25] libselinux: regex: unify parameter names [25/25] libselinux: label_file.c: fix indent

Message ID

20210503175350.55954-15-cgzones@googlemail.com (mailing list archive)

State

Accepted

Headers

From: =?utf-8?q?Christian_G=C3=B6ttsche?= <cgzones@googlemail.com>
To: selinux@vger.kernel.org
Subject: [PATCH 14/25] libselinux: setexecfilecon(): drop dead assignment
Date: Mon,  3 May 2021 19:53:39 +0200
Message-Id: <20210503175350.55954-15-cgzones@googlemail.com>
In-Reply-To: <20210503175350.55954-1-cgzones@googlemail.com>
References: <20210503175350.55954-1-cgzones@googlemail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

libselinux: misc compiler and static analyzer findings | expand

Commit Message

Christian Göttsche May 3, 2021, 5:53 p.m. UTC

The variable `rc` is always unconditionally assigned by the next call of
`setexeccon()` and never read in between.

Found by clang-analyzer.

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
---
 libselinux/src/setexecfilecon.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libselinux/src/setexecfilecon.c b/libselinux/src/setexecfilecon.c
index e72ba0d9..2c6505a9 100644
--- a/libselinux/src/setexecfilecon.c
+++ b/libselinux/src/setexecfilecon.c
@@ -37,7 +37,6 @@  int setexecfilecon(const char *filename, const char *fallback_type)
 		newcon = strdup(context_str(con));
 		if (!newcon)
 			goto out;
-		rc = 0;
 	}
 
 	rc = setexeccon(newcon);

[14/25] libselinux: setexecfilecon(): drop dead assignment

Commit Message

Patch